diff mbox

[2/2] ARM: dts: dra7: remove ti,hwmod property from pcie phy

Message ID 1424422274-27946-2-git-send-email-kishon@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Kishon Vijay Abraham I Feb. 20, 2015, 8:51 a.m. UTC
Now that we don't have hwmod entry for pcie PHY remove the
ti,hwmod property from PCIE PHY's

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 arch/arm/boot/dts/dra7.dtsi |    2 --
 1 file changed, 2 deletions(-)

Comments

Grygorii Strashko March 18, 2015, 4:36 p.m. UTC | #1
Hi Tony,

As I can see Patch 1 from this series was merged in 4.0-rc4,
but this patch wasn't. As result, I can see below warning all the time during boot now:

[    0.594591] platform 4a094000.pciephy: Cannot lookup hwmod 'pcie1-phy'
 

On 02/20/2015 10:51 AM, Kishon Vijay Abraham I wrote:
> Now that we don't have hwmod entry for pcie PHY remove the
> ti,hwmod property from PCIE PHY's
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>   arch/arm/boot/dts/dra7.dtsi |    2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index 5827fed..18a904d 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -1111,7 +1111,6 @@
>   					      "wkupclk", "refclk",
>   					      "div-clk", "phy-div";
>   				#phy-cells = <0>;
> -				ti,hwmods = "pcie1-phy";
>   			};
>   
>   			pcie2_phy: pciephy@4a095000 {
> @@ -1130,7 +1129,6 @@
>   					      "wkupclk", "refclk",
>   					      "div-clk", "phy-div";
>   				#phy-cells = <0>;
> -				ti,hwmods = "pcie2-phy";
>   				status = "disabled";
>   			};
>   		};
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tony Lindgren March 18, 2015, 4:57 p.m. UTC | #2
* Grygorii Strashko <grygorii.strashko@ti.com> [150318 09:37]:
> Hi Tony,
> 
> As I can see Patch 1 from this series was merged in 4.0-rc4,
> but this patch wasn't. As result, I can see below warning all the time during boot now:
> 
> [    0.594591] platform 4a094000.pciephy: Cannot lookup hwmod 'pcie1-phy'
 
OK. Is this needed as a fix for the v4.0-rc series, or can this wait
for v4.1?

Regards,

Tony
 
> On 02/20/2015 10:51 AM, Kishon Vijay Abraham I wrote:
> > Now that we don't have hwmod entry for pcie PHY remove the
> > ti,hwmod property from PCIE PHY's
> > 
> > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> > ---
> >   arch/arm/boot/dts/dra7.dtsi |    2 --
> >   1 file changed, 2 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> > index 5827fed..18a904d 100644
> > --- a/arch/arm/boot/dts/dra7.dtsi
> > +++ b/arch/arm/boot/dts/dra7.dtsi
> > @@ -1111,7 +1111,6 @@
> >   					      "wkupclk", "refclk",
> >   					      "div-clk", "phy-div";
> >   				#phy-cells = <0>;
> > -				ti,hwmods = "pcie1-phy";
> >   			};
> >   
> >   			pcie2_phy: pciephy@4a095000 {
> > @@ -1130,7 +1129,6 @@
> >   					      "wkupclk", "refclk",
> >   					      "div-clk", "phy-div";
> >   				#phy-cells = <0>;
> > -				ti,hwmods = "pcie2-phy";
> >   				status = "disabled";
> >   			};
> >   		};
> > 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Grygorii.Strashko@linaro.org March 18, 2015, 7:36 p.m. UTC | #3
On 03/18/2015 06:57 PM, Tony Lindgren wrote:
> * Grygorii Strashko <grygorii.strashko@ti.com> [150318 09:37]:
>> As I can see Patch 1 from this series was merged in 4.0-rc4,
>> but this patch wasn't. As result, I can see below warning all the time during boot now:
>>
>> [    0.594591] platform 4a094000.pciephy: Cannot lookup hwmod 'pcie1-phy'
>   
> OK. Is this needed as a fix for the v4.0-rc series, or can this wait
> for v4.1?

I think, Yes. These two patches should go all together, because they are
interrelated.

>> On 02/20/2015 10:51 AM, Kishon Vijay Abraham I wrote:
>>> Now that we don't have hwmod entry for pcie PHY remove the
>>> ti,hwmod property from PCIE PHY's
>>>
>>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
>>> ---
>>>    arch/arm/boot/dts/dra7.dtsi |    2 --
>>>    1 file changed, 2 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
>>> index 5827fed..18a904d 100644
>>> --- a/arch/arm/boot/dts/dra7.dtsi
>>> +++ b/arch/arm/boot/dts/dra7.dtsi
>>> @@ -1111,7 +1111,6 @@
>>>    					      "wkupclk", "refclk",
>>>    					      "div-clk", "phy-div";
>>>    				#phy-cells = <0>;
>>> -				ti,hwmods = "pcie1-phy";
>>>    			};
>>>    
>>>    			pcie2_phy: pciephy@4a095000 {
>>> @@ -1130,7 +1129,6 @@
>>>    					      "wkupclk", "refclk",
>>>    					      "div-clk", "phy-div";
>>>    				#phy-cells = <0>;
>>> -				ti,hwmods = "pcie2-phy";
>>>    				status = "disabled";
>>>    			};
>>>    		};
>>>
>>
Tony Lindgren March 18, 2015, 8:23 p.m. UTC | #4
* Grygorii.Strashko@linaro.org <grygorii.strashko@linaro.org> [150318 12:36]:
> On 03/18/2015 06:57 PM, Tony Lindgren wrote:
> > * Grygorii Strashko <grygorii.strashko@ti.com> [150318 09:37]:
> >> As I can see Patch 1 from this series was merged in 4.0-rc4,
> >> but this patch wasn't. As result, I can see below warning all the time during boot now:
> >>
> >> [    0.594591] platform 4a094000.pciephy: Cannot lookup hwmod 'pcie1-phy'
> >   
> > OK. Is this needed as a fix for the v4.0-rc series, or can this wait
> > for v4.1?
> 
> I think, Yes. These two patches should go all together, because they are
> interrelated.

OK applying into omap-for-v4.0/fixes thanks.

Tony
 
> >> On 02/20/2015 10:51 AM, Kishon Vijay Abraham I wrote:
> >>> Now that we don't have hwmod entry for pcie PHY remove the
> >>> ti,hwmod property from PCIE PHY's
> >>>
> >>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> >>> ---
> >>>    arch/arm/boot/dts/dra7.dtsi |    2 --
> >>>    1 file changed, 2 deletions(-)
> >>>
> >>> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> >>> index 5827fed..18a904d 100644
> >>> --- a/arch/arm/boot/dts/dra7.dtsi
> >>> +++ b/arch/arm/boot/dts/dra7.dtsi
> >>> @@ -1111,7 +1111,6 @@
> >>>    					      "wkupclk", "refclk",
> >>>    					      "div-clk", "phy-div";
> >>>    				#phy-cells = <0>;
> >>> -				ti,hwmods = "pcie1-phy";
> >>>    			};
> >>>    
> >>>    			pcie2_phy: pciephy@4a095000 {
> >>> @@ -1130,7 +1129,6 @@
> >>>    					      "wkupclk", "refclk",
> >>>    					      "div-clk", "phy-div";
> >>>    				#phy-cells = <0>;
> >>> -				ti,hwmods = "pcie2-phy";
> >>>    				status = "disabled";
> >>>    			};
> >>>    		};
> >>>
> >>
> 
> 
> -- 
> regards,
> -grygorii
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Paul Walmsley March 19, 2015, 2:55 p.m. UTC | #5
On Wed, 18 Mar 2015, Grygorii.Strashko@linaro.org wrote:

> On 03/18/2015 06:57 PM, Tony Lindgren wrote:
> > * Grygorii Strashko <grygorii.strashko@ti.com> [150318 09:37]:
> >> As I can see Patch 1 from this series was merged in 4.0-rc4,
> >> but this patch wasn't. As result, I can see below warning all the time during boot now:
> >>
> >> [    0.594591] platform 4a094000.pciephy: Cannot lookup hwmod 'pcie1-phy'
> >   
> > OK. Is this needed as a fix for the v4.0-rc series, or can this wait
> > for v4.1?
> 
> I think, Yes. These two patches should go all together, because they are
> interrelated.

Does the warning result in a functional problem, or is it just a warning?


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Grygorii.Strashko@linaro.org March 19, 2015, 3:39 p.m. UTC | #6
On 03/19/2015 04:55 PM, Paul Walmsley wrote:
> On Wed, 18 Mar 2015, Grygorii.Strashko@linaro.org wrote:
>
>> On 03/18/2015 06:57 PM, Tony Lindgren wrote:
>>> * Grygorii Strashko <grygorii.strashko@ti.com> [150318 09:37]:
>>>> As I can see Patch 1 from this series was merged in 4.0-rc4,
>>>> but this patch wasn't. As result, I can see below warning all the time during boot now:
>>>>
>>>> [    0.594591] platform 4a094000.pciephy: Cannot lookup hwmod 'pcie1-phy'
>>>
>>> OK. Is this needed as a fix for the v4.0-rc series, or can this wait
>>> for v4.1?
>>
>> I think, Yes. These two patches should go all together, because they are
>> interrelated.
>
> Does the warning result in a functional problem, or is it just a warning?
>

PCE1 PHY device is not registered any more.
Paul Walmsley March 19, 2015, 3:45 p.m. UTC | #7
On Thu, 19 Mar 2015, Grygorii.Strashko@linaro.org wrote:

> On 03/19/2015 04:55 PM, Paul Walmsley wrote:
> > On Wed, 18 Mar 2015, Grygorii.Strashko@linaro.org wrote:
> > 
> > > On 03/18/2015 06:57 PM, Tony Lindgren wrote:
> > > > * Grygorii Strashko <grygorii.strashko@ti.com> [150318 09:37]:
> > > > > As I can see Patch 1 from this series was merged in 4.0-rc4,
> > > > > but this patch wasn't. As result, I can see below warning all the time
> > > > > during boot now:
> > > > > 
> > > > > [    0.594591] platform 4a094000.pciephy: Cannot lookup hwmod
> > > > > 'pcie1-phy'
> > > > 
> > > > OK. Is this needed as a fix for the v4.0-rc series, or can this wait
> > > > for v4.1?
> > > 
> > > I think, Yes. These two patches should go all together, because they are
> > > interrelated.
> > 
> > Does the warning result in a functional problem, or is it just a warning?
> > 
> 
> PCE1 PHY device is not registered any more.

How does the second patch fix that?

- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tony Lindgren March 19, 2015, 4:03 p.m. UTC | #8
* Paul Walmsley <paul@pwsan.com> [150319 08:46]:
> On Thu, 19 Mar 2015, Grygorii.Strashko@linaro.org wrote:
> 
> > On 03/19/2015 04:55 PM, Paul Walmsley wrote:
> > > On Wed, 18 Mar 2015, Grygorii.Strashko@linaro.org wrote:
> > > 
> > > > On 03/18/2015 06:57 PM, Tony Lindgren wrote:
> > > > > * Grygorii Strashko <grygorii.strashko@ti.com> [150318 09:37]:
> > > > > > As I can see Patch 1 from this series was merged in 4.0-rc4,
> > > > > > but this patch wasn't. As result, I can see below warning all the time
> > > > > > during boot now:
> > > > > > 
> > > > > > [    0.594591] platform 4a094000.pciephy: Cannot lookup hwmod
> > > > > > 'pcie1-phy'
> > > > > 
> > > > > OK. Is this needed as a fix for the v4.0-rc series, or can this wait
> > > > > for v4.1?
> > > > 
> > > > I think, Yes. These two patches should go all together, because they are
> > > > interrelated.
> > > 
> > > Does the warning result in a functional problem, or is it just a warning?
> > > 
> > 
> > PCE1 PHY device is not registered any more.
> 
> How does the second patch fix that?

It seems it should be just a warning fix if the pciephy hwmod entries
are now gone?

Anyways, I'm planning to send a pull request for  omap-for-v4.0/fixes
today. Please let me know ASAP if the $subject patch should be dropped,
otherwise I'll send it as it fixes a boot time warning and is already
applied.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Grygorii.Strashko@linaro.org March 19, 2015, 4:21 p.m. UTC | #9
On 03/19/2015 05:45 PM, Paul Walmsley wrote:
> On Thu, 19 Mar 2015, Grygorii.Strashko@linaro.org wrote:
> 
>> On 03/19/2015 04:55 PM, Paul Walmsley wrote:
>>> On Wed, 18 Mar 2015, Grygorii.Strashko@linaro.org wrote:
>>>
>>>> On 03/18/2015 06:57 PM, Tony Lindgren wrote:
>>>>> * Grygorii Strashko <grygorii.strashko@ti.com> [150318 09:37]:
>>>>>> As I can see Patch 1 from this series was merged in 4.0-rc4,
>>>>>> but this patch wasn't. As result, I can see below warning all the time
>>>>>> during boot now:
>>>>>>
>>>>>> [    0.594591] platform 4a094000.pciephy: Cannot lookup hwmod
>>>>>> 'pcie1-phy'
>>>>>
>>>>> OK. Is this needed as a fix for the v4.0-rc series, or can this wait
>>>>> for v4.1?
>>>>
>>>> I think, Yes. These two patches should go all together, because they are
>>>> interrelated.
>>>
>>> Does the warning result in a functional problem, or is it just a warning?
>>>
>>
>> PCE1 PHY device is not registered any more.
> 
> How does the second patch fix that?

I've re-checked it - sorry for disinfo.

PHY devices are created, but omap_device_fail_pm_domain is assigned to them.
As result Runtime PM is not working any more.


[    0.592501] platform 4a094000.pciephy: Cannot lookup hwmod 'pcie1-phy'
[    0.597510] pinctrl-single 4a003400.pinmux: 281 pins at pa fc003400 size 1124
[    0.602794] ti-pipe3 4a094000.pciephy: _od_fail_runtime_resume: FIXME: missing hwmod/omap_dev info

When ti,hwmods is not present PCI PHY will be added as regular Platform device
and Runtime PM will work again.
Paul Walmsley March 19, 2015, 4:36 p.m. UTC | #10
On Thu, 19 Mar 2015, Tony Lindgren wrote:

> * Paul Walmsley <paul@pwsan.com> [150319 08:46]:
> > On Thu, 19 Mar 2015, Grygorii.Strashko@linaro.org wrote:
> > 
> > > On 03/19/2015 04:55 PM, Paul Walmsley wrote:
> > > > On Wed, 18 Mar 2015, Grygorii.Strashko@linaro.org wrote:
> > > > 
> > > > > On 03/18/2015 06:57 PM, Tony Lindgren wrote:
> > > > > > * Grygorii Strashko <grygorii.strashko@ti.com> [150318 09:37]:
> > > > > > > As I can see Patch 1 from this series was merged in 4.0-rc4,
> > > > > > > but this patch wasn't. As result, I can see below warning all the time
> > > > > > > during boot now:
> > > > > > > 
> > > > > > > [    0.594591] platform 4a094000.pciephy: Cannot lookup hwmod
> > > > > > > 'pcie1-phy'
> > > > > > 
> > > > > > OK. Is this needed as a fix for the v4.0-rc series, or can this wait
> > > > > > for v4.1?
> > > > > 
> > > > > I think, Yes. These two patches should go all together, because they are
> > > > > interrelated.
> > > > 
> > > > Does the warning result in a functional problem, or is it just a warning?
> > > > 
> > > 
> > > PCE1 PHY device is not registered any more.
> > 
> > How does the second patch fix that?
> 
> It seems it should be just a warning fix if the pciephy hwmod entries
> are now gone?
> 
> Anyways, I'm planning to send a pull request for  omap-for-v4.0/fixes
> today. Please let me know ASAP if the $subject patch should be dropped,
> otherwise I'll send it as it fixes a boot time warning and is already
> applied.

If you want to send it up as a fix, that's fine with me.  But I don't see 
how that second patch will cause any changes in device registration, as 
stated.


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Paul Walmsley March 19, 2015, 4:49 p.m. UTC | #11
On Thu, 19 Mar 2015, Grygorii.Strashko@linaro.org wrote:

> On 03/19/2015 05:45 PM, Paul Walmsley wrote:
> > On Thu, 19 Mar 2015, Grygorii.Strashko@linaro.org wrote:
> > 
> >> On 03/19/2015 04:55 PM, Paul Walmsley wrote:
> >>> On Wed, 18 Mar 2015, Grygorii.Strashko@linaro.org wrote:
> >>>
> >>>> On 03/18/2015 06:57 PM, Tony Lindgren wrote:
> >>>>> * Grygorii Strashko <grygorii.strashko@ti.com> [150318 09:37]:
> >>>>>> As I can see Patch 1 from this series was merged in 4.0-rc4,
> >>>>>> but this patch wasn't. As result, I can see below warning all the time
> >>>>>> during boot now:
> >>>>>>
> >>>>>> [    0.594591] platform 4a094000.pciephy: Cannot lookup hwmod
> >>>>>> 'pcie1-phy'
> >>>>>
> >>>>> OK. Is this needed as a fix for the v4.0-rc series, or can this wait
> >>>>> for v4.1?
> >>>>
> >>>> I think, Yes. These two patches should go all together, because they are
> >>>> interrelated.
> >>>
> >>> Does the warning result in a functional problem, or is it just a warning?
> >>>
> >>
> >> PCE1 PHY device is not registered any more.
> > 
> > How does the second patch fix that?
> 
> I've re-checked it - sorry for disinfo.
> 
> PHY devices are created, but omap_device_fail_pm_domain is assigned to them.
> As result Runtime PM is not working any more.
> 
> 
> [    0.592501] platform 4a094000.pciephy: Cannot lookup hwmod 'pcie1-phy'
> [    0.597510] pinctrl-single 4a003400.pinmux: 281 pins at pa fc003400 size 1124
> [    0.602794] ti-pipe3 4a094000.pciephy: _od_fail_runtime_resume: FIXME: missing hwmod/omap_dev info
> 
> When ti,hwmods is not present PCI PHY will be added as regular Platform device
> and Runtime PM will work again.

OK then it should definitely go up as a fix.  

Kishon, for future references, those two patches should have been combined 
into a single patch.  As it stands now, if someone bisects down to that 
first patch, it sounds like PM will be at least partially broken.  Too bad 
I don't have a DRA7xx board where things like this can be tested before 
being sent upstream.



- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kishon Vijay Abraham I March 25, 2015, 10:53 p.m. UTC | #12
Hi,

On Thursday 19 March 2015 10:19 PM, Paul Walmsley wrote:
> On Thu, 19 Mar 2015, Grygorii.Strashko@linaro.org wrote:
> 
>> On 03/19/2015 05:45 PM, Paul Walmsley wrote:
>>> On Thu, 19 Mar 2015, Grygorii.Strashko@linaro.org wrote:
>>>
>>>> On 03/19/2015 04:55 PM, Paul Walmsley wrote:
>>>>> On Wed, 18 Mar 2015, Grygorii.Strashko@linaro.org wrote:
>>>>>
>>>>>> On 03/18/2015 06:57 PM, Tony Lindgren wrote:
>>>>>>> * Grygorii Strashko <grygorii.strashko@ti.com> [150318 09:37]:
>>>>>>>> As I can see Patch 1 from this series was merged in 4.0-rc4,
>>>>>>>> but this patch wasn't. As result, I can see below warning all the time
>>>>>>>> during boot now:
>>>>>>>>
>>>>>>>> [    0.594591] platform 4a094000.pciephy: Cannot lookup hwmod
>>>>>>>> 'pcie1-phy'
>>>>>>>
>>>>>>> OK. Is this needed as a fix for the v4.0-rc series, or can this wait
>>>>>>> for v4.1?
>>>>>>
>>>>>> I think, Yes. These two patches should go all together, because they are
>>>>>> interrelated.
>>>>>
>>>>> Does the warning result in a functional problem, or is it just a warning?
>>>>>
>>>>
>>>> PCE1 PHY device is not registered any more.
>>>
>>> How does the second patch fix that?
>>
>> I've re-checked it - sorry for disinfo.
>>
>> PHY devices are created, but omap_device_fail_pm_domain is assigned to them.
>> As result Runtime PM is not working any more.
>>
>>
>> [    0.592501] platform 4a094000.pciephy: Cannot lookup hwmod 'pcie1-phy'
>> [    0.597510] pinctrl-single 4a003400.pinmux: 281 pins at pa fc003400 size 1124
>> [    0.602794] ti-pipe3 4a094000.pciephy: _od_fail_runtime_resume: FIXME: missing hwmod/omap_dev info
>>
>> When ti,hwmods is not present PCI PHY will be added as regular Platform device
>> and Runtime PM will work again.
> 
> OK then it should definitely go up as a fix.  
> 
> Kishon, for future references, those two patches should have been combined 
> into a single patch.  As it stands now, if someone bisects down to that 
> first patch, it sounds like PM will be at least partially broken.  Too bad 
> I don't have a DRA7xx board where things like this can be tested before 
> being sent upstream.

huh.. was under the assumption that patches for device tree and the kernel
patches should be separate. And PCIE for DRA7xx was broken in mainline for
quite sometime now because of reset framework support not added for DRA7xx.

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Paul Walmsley March 26, 2015, 7:29 a.m. UTC | #13
On Thu, 26 Mar 2015, Kishon Vijay Abraham I wrote:

> On Thursday 19 March 2015 10:19 PM, Paul Walmsley wrote:
> > On Thu, 19 Mar 2015, Grygorii.Strashko@linaro.org wrote:
> >> On 03/19/2015 05:45 PM, Paul Walmsley wrote:
> >>> On Thu, 19 Mar 2015, Grygorii.Strashko@linaro.org wrote:
> >>>> On 03/19/2015 04:55 PM, Paul Walmsley wrote:
> >>>>> On Wed, 18 Mar 2015, Grygorii.Strashko@linaro.org wrote:
> >>>>>> On 03/18/2015 06:57 PM, Tony Lindgren wrote:
> >>>>>>> * Grygorii Strashko <grygorii.strashko@ti.com> [150318 09:37]:
> >>>>>>>> As I can see Patch 1 from this series was merged in 4.0-rc4,
> >>>>>>>> but this patch wasn't. As result, I can see below warning all the time
> >>>>>>>> during boot now:
> >>>>>>>>
> >>>>>>>> [    0.594591] platform 4a094000.pciephy: Cannot lookup hwmod
> >>>>>>>> 'pcie1-phy'
> >>>>>>>
> >>>>>>> OK. Is this needed as a fix for the v4.0-rc series, or can this wait
> >>>>>>> for v4.1?
> >>>>>>
> >>>>>> I think, Yes. These two patches should go all together, because they are
> >>>>>> interrelated.
> >>>>>
> >>>>> Does the warning result in a functional problem, or is it just a warning?
> >>>>
> >>>> PCE1 PHY device is not registered any more.
> >>>
> >>> How does the second patch fix that?
> >>
> >> I've re-checked it - sorry for disinfo.
> >>
> >> PHY devices are created, but omap_device_fail_pm_domain is assigned to them.
> >> As result Runtime PM is not working any more.
> >>
> >>
> >> [    0.592501] platform 4a094000.pciephy: Cannot lookup hwmod 'pcie1-phy'
> >> [    0.597510] pinctrl-single 4a003400.pinmux: 281 pins at pa fc003400 size 1124
> >> [    0.602794] ti-pipe3 4a094000.pciephy: _od_fail_runtime_resume: FIXME: missing hwmod/omap_dev info
> >>
> >> When ti,hwmods is not present PCI PHY will be added as regular Platform device
> >> and Runtime PM will work again.
> > 
> > OK then it should definitely go up as a fix.  
> > 
> > Kishon, for future references, those two patches should have been combined 
> > into a single patch.  As it stands now, if someone bisects down to that 
> > first patch, it sounds like PM will be at least partially broken.  Too bad 
> > I don't have a DRA7xx board where things like this can be tested before 
> > being sent upstream.
> 
> huh.. was under the assumption that patches for device tree and the kernel
> patches should be separate.

Generally that's true, _unless_ separating them will break something 
between the two patches.  That appears to be the case here.  The important 
thing is to make sure every single commit builds and functions at least as 
well as the previous commit - i.e., there should be no regressions.


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index 5827fed..18a904d 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -1111,7 +1111,6 @@ 
 					      "wkupclk", "refclk",
 					      "div-clk", "phy-div";
 				#phy-cells = <0>;
-				ti,hwmods = "pcie1-phy";
 			};
 
 			pcie2_phy: pciephy@4a095000 {
@@ -1130,7 +1129,6 @@ 
 					      "wkupclk", "refclk",
 					      "div-clk", "phy-div";
 				#phy-cells = <0>;
-				ti,hwmods = "pcie2-phy";
 				status = "disabled";
 			};
 		};