| Message ID | 1426686963-11613-9-git-send-email-rogerq@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Mar 18, 2015 at 03:56:02PM +0200, Roger Quadros wrote: > These members are not used anywhere so remove them. > > Signed-off-by: Roger Quadros <rogerq@ti.com> > --- > include/linux/usb/otg-fsm.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/include/linux/usb/otg-fsm.h b/include/linux/usb/otg-fsm.h > index b6ba1bf..176c4fc 100644 > --- a/include/linux/usb/otg-fsm.h > +++ b/include/linux/usb/otg-fsm.h > @@ -95,11 +95,6 @@ struct otg_fsm { > int b_hnp_enable; > int a_clr_err; > > - /* Informative variables */ > - int a_bus_drop_inf; > - int a_bus_req_inf; > - int a_clr_err_inf; > - int b_bus_req_inf; > /* Auxilary informative variables */ > int a_suspend_req_inf; > But the above are defined at: ch 7.4.4, On-The-Go and Embedded Host Supplement to the USB Revision 2.0 Specification > -- > 2.1.0 >
On 19/03/15 05:46, Peter Chen wrote: > On Wed, Mar 18, 2015 at 03:56:02PM +0200, Roger Quadros wrote: >> These members are not used anywhere so remove them. >> >> Signed-off-by: Roger Quadros <rogerq@ti.com> >> --- >> include/linux/usb/otg-fsm.h | 5 ----- >> 1 file changed, 5 deletions(-) >> >> diff --git a/include/linux/usb/otg-fsm.h b/include/linux/usb/otg-fsm.h >> index b6ba1bf..176c4fc 100644 >> --- a/include/linux/usb/otg-fsm.h >> +++ b/include/linux/usb/otg-fsm.h >> @@ -95,11 +95,6 @@ struct otg_fsm { >> int b_hnp_enable; >> int a_clr_err; >> >> - /* Informative variables */ >> - int a_bus_drop_inf; >> - int a_bus_req_inf; >> - int a_clr_err_inf; >> - int b_bus_req_inf; >> /* Auxilary informative variables */ >> int a_suspend_req_inf; >> > > But the above are defined at: ch 7.4.4, On-The-Go and Embedded Host > Supplement to the USB Revision 2.0 Specification I can leave them there then but just add a note saying that they are not yet used by the OTG FSM. cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/usb/otg-fsm.h b/include/linux/usb/otg-fsm.h index b6ba1bf..176c4fc 100644 --- a/include/linux/usb/otg-fsm.h +++ b/include/linux/usb/otg-fsm.h @@ -95,11 +95,6 @@ struct otg_fsm { int b_hnp_enable; int a_clr_err; - /* Informative variables */ - int a_bus_drop_inf; - int a_bus_req_inf; - int a_clr_err_inf; - int b_bus_req_inf; /* Auxilary informative variables */ int a_suspend_req_inf;
These members are not used anywhere so remove them. Signed-off-by: Roger Quadros <rogerq@ti.com> --- include/linux/usb/otg-fsm.h | 5 ----- 1 file changed, 5 deletions(-)