From patchwork Thu Apr 30 15:28:53 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Semen Protsenko X-Patchwork-Id: 6305191 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 5E90F9F1C2 for ; Thu, 30 Apr 2015 15:30:06 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3F5B8201EC for ; Thu, 30 Apr 2015 15:30:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB4DC201DD for ; Thu, 30 Apr 2015 15:30:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751388AbbD3PaB (ORCPT ); Thu, 30 Apr 2015 11:30:01 -0400 Received: from exprod5og108.obsmtp.com ([64.18.0.186]:41872 "EHLO mail-lb0-f169.google.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750791AbbD3P37 (ORCPT ); Thu, 30 Apr 2015 11:29:59 -0400 Received: from mail-lb0-f169.google.com ([209.85.217.169]) (using TLSv1) by exprod5ob108.postini.com ([64.18.4.12]) with SMTP ID DSNKVUJKdhM4cHAwznsqu7M6YIv2Pn1EKAtS@postini.com; Thu, 30 Apr 2015 08:29:59 PDT Received: by lbbuc2 with SMTP id uc2so47421556lbb.2 for ; Thu, 30 Apr 2015 08:29:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=globallogic.com; s=google; h=from:to:cc:subject:date:message-id; bh=NRVbhIRI4P/9OR5pt8fA38u70F9tNVHo3EG1CMPc4Iw=; b=P6E7sFPN1oON2WvvzY4qwEOCLbh1ho9NMf/nJqh8ePxyonyZEG8jUtGE17T/kLsCqk wicS6Zky0USyDEfo69Zcd67IbiAjfuOoe36wI7K0pph21BNpA17ohVnfjr0fNgwB3xbs eON5aKCXsTMJEeHQCBuTt88xo0Agai6Z1HYFI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=NRVbhIRI4P/9OR5pt8fA38u70F9tNVHo3EG1CMPc4Iw=; b=lzJ5KWb3PuiipGQRVewAnsFUMIA2qfgTCWkZKJdhjq1/VyRjq6HH2DcP54gi2KFQcH esp+GyVfog9Dk2Q9jfXTJvkMcqumYKdmOpEnD+FHLVt1KdinPoQ/hs03Jj5szod2yZ65 peu33zGS6clHczMKce5yQgCFiElM4364SXG/JGyzCDsz25Hlez1aNRq6nQtKK+4U8v6X RSUU6H9wcbJKifqXScPgVTW++IfaqDMcuk45zqjjVG3g1N2dyB4JCR5c6v2nzdkbCw3X HZCLa5v8En2B0QRr5QUGfjWvoxfA3yLWimNQajL3oOb+YHPW1u0eCwHLVJhNVF+QPTZu ytxA== X-Gm-Message-State: ALoCoQmxzxlMtTt6ZyIw/I7A7IhS/ZBs9BoFn/vT9iarR6ZXpQ+Ke+4DYlSlGSHwh8Z2ujrChJ6CuCdB/AnDaB6E/3DcAIbmwubZ+OXDnuPz/eQ+Q509PaFYMEoCw+kScTT6OKJo+LHbBKjymPAAUi5wUuNRHuAUqA== X-Received: by 10.112.219.70 with SMTP id pm6mr4276037lbc.41.1430407797369; Thu, 30 Apr 2015 08:29:57 -0700 (PDT) X-Received: by 10.112.219.70 with SMTP id pm6mr4276018lbc.41.1430407797171; Thu, 30 Apr 2015 08:29:57 -0700 (PDT) Received: from localhost ([195.238.92.132]) by mx.google.com with ESMTPSA id h3sm670354laf.24.2015.04.30.08.29.56 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 30 Apr 2015 08:29:56 -0700 (PDT) From: Semen Protsenko To: Greg Kroah-Hartman Cc: Jiri Slaby , Grygorii Strashko , Nishanth Menon , "Govindraj.R" , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: [PATCH] serial: omap: Fix error handling in probe Date: Thu, 30 Apr 2015 18:28:53 +0300 Message-Id: <1430407733-4762-1-git-send-email-semen.protsenko@globallogic.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is pm_qos_add_request() being executed on serial_omap_probe(), which stores "&up->pm_qos_request" from omap-serial driver to "pm_qos_array[PM_QOS_CPU_DMA_LATENCY]->constraints". If serial_omap_probe() fails after pm_qos_add_request() (e.g. on uart_add_one_port() call), pm_qos_array still keeping pm_qos_request struct from omap-serial driver, which is not valid anymore (since driver failed). This leads further to kernel crash on pm_qos_update_target(), executing from some completely different driver. We were observing this while trying to run audio playback while having one of omap-serial driver instances failed on uart_add_one_port() call: Unable to handle kernel paging request at virtual address fffffffc Backtrace: (plist_add) from (pm_qos_update_target) (pm_qos_update_target) from (pm_qos_add_request) (pm_qos_add_request) from (snd_pcm_hw_params) (snd_pcm_hw_params) from (snd_pcm_common_ioctl1) (snd_pcm_common_ioctl1) from (snd_pcm_playback_ioctl1) (snd_pcm_playback_ioctl1) from (snd_pcm_playback_ioctl) (snd_pcm_playback_ioctl) from (do_vfs_ioctl) (do_vfs_ioctl) from (SyS_ioctl) (SyS_ioctl) from (ret_fast_syscall) This patch adds pm_qos_remove_request() on fail path in serial_omap_probe() in order to fix this issue. While at it, free the wakeup settings on fail path as well, just like it's done in serial_omap_remove(). Signed-off-by: Semen Protsenko --- drivers/tty/serial/omap-serial.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c index d55714d..8d03486 100644 --- a/drivers/tty/serial/omap-serial.c +++ b/drivers/tty/serial/omap-serial.c @@ -1761,6 +1761,8 @@ static int serial_omap_probe(struct platform_device *pdev) err_add_port: pm_runtime_put(&pdev->dev); pm_runtime_disable(&pdev->dev); + pm_qos_remove_request(&up->pm_qos_request); + device_init_wakeup(up->dev, false); err_rs485: err_port_line: dev_err(&pdev->dev, "[UART%d]: failure [%s]: %d\n",