diff mbox

ARM: dts: Fix WLAN interrupt line for AM335x EVM-SK

Message ID 1431502655-23255-1-git-send-email-romain.izard.pro@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Romain Izard May 13, 2015, 7:37 a.m. UTC
While Sitara AM335x SoCs are very close to OMAP SoCs, the 32-line GPIO
controllers are numbered from 0 on AM335x and from 1 on OMAP. But when
the configuration for the TI WLAN controllers was converted from
platform data to device tree, this detail was overlooked, as 10 boards
were using OMAP with the WL12xx and WL18xx controllers, and only one
was based on AM335x.

This invalid configuration prevents the WL1271 module on the AM335x
EVM-SK from notifying interrupts to the SoC, and breaks the wlan driver.

The DTS must be corrected to use the correct GPIO controller.

Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
---
 arch/arm/boot/dts/am335x-evmsk.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tony Lindgren May 20, 2015, 4:52 p.m. UTC | #1
* Romain Izard <romain.izard.pro@gmail.com> [150513 00:39]:
> While Sitara AM335x SoCs are very close to OMAP SoCs, the 32-line GPIO
> controllers are numbered from 0 on AM335x and from 1 on OMAP. But when
> the configuration for the TI WLAN controllers was converted from
> platform data to device tree, this detail was overlooked, as 10 boards
> were using OMAP with the WL12xx and WL18xx controllers, and only one
> was based on AM335x.
> 
> This invalid configuration prevents the WL1271 module on the AM335x
> EVM-SK from notifying interrupts to the SoC, and breaks the wlan driver.
> 
> The DTS must be corrected to use the correct GPIO controller.
> 
> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
> ---
>  arch/arm/boot/dts/am335x-evmsk.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/am335x-evmsk.dts b/arch/arm/boot/dts/am335x-evmsk.dts
> index 87fc7a35e802..156d05efcb70 100644
> --- a/arch/arm/boot/dts/am335x-evmsk.dts
> +++ b/arch/arm/boot/dts/am335x-evmsk.dts
> @@ -654,7 +654,7 @@
>  	wlcore: wlcore@2 {
>  		compatible = "ti,wl1271";
>  		reg = <2>;
> -		interrupt-parent = <&gpio1>;
> +		interrupt-parent = <&gpio0>;
>  		interrupts = <31 IRQ_TYPE_LEVEL_HIGH>; /* gpio 31 */
>  		ref-clock-frequency = <38400000>;
>  	};

Applying into omap-for-v4.1/fixes thanks.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/am335x-evmsk.dts b/arch/arm/boot/dts/am335x-evmsk.dts
index 87fc7a35e802..156d05efcb70 100644
--- a/arch/arm/boot/dts/am335x-evmsk.dts
+++ b/arch/arm/boot/dts/am335x-evmsk.dts
@@ -654,7 +654,7 @@ 
 	wlcore: wlcore@2 {
 		compatible = "ti,wl1271";
 		reg = <2>;
-		interrupt-parent = <&gpio1>;
+		interrupt-parent = <&gpio0>;
 		interrupts = <31 IRQ_TYPE_LEVEL_HIGH>; /* gpio 31 */
 		ref-clock-frequency = <38400000>;
 	};