| Message ID | 1442496171-28741-1-git-send-email-javier@osg.samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 17/09/15 16:22, Javier Martinez Canillas wrote: > Commit b483a4a5a711 ("ARM: OMAP4+: hwmod data: Don't prevent RESET of > USB Host module") added the SYSC_HAS_RESET_STATUS flag to both OMAP4 > and OMAP5 USB host module hwmon sysconfig but that flag was already > set for OMAP5. So now the flag appears twice in the expression. > > make coccicheck complains with the following message: > > omap_hwmod_54xx_data.c:1846:37-58: duplicated argument to & or | > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> Acked-by: Roger Quadros <rogerq@ti.com> > > --- > > arch/arm/mach-omap2/omap_hwmod_54xx_data.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm/mach-omap2/omap_hwmod_54xx_data.c b/arch/arm/mach-omap2/omap_hwmod_54xx_data.c > index 7c3fac035e93..8cdfd9b7ab4f 100644 > --- a/arch/arm/mach-omap2/omap_hwmod_54xx_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_54xx_data.c > @@ -1844,8 +1844,7 @@ static struct omap_hwmod_class_sysconfig omap54xx_usb_host_hs_sysc = { > .rev_offs = 0x0000, > .sysc_offs = 0x0010, > .sysc_flags = (SYSC_HAS_MIDLEMODE | SYSC_HAS_RESET_STATUS | > - SYSC_HAS_SIDLEMODE | SYSC_HAS_SOFTRESET | > - SYSC_HAS_RESET_STATUS), > + SYSC_HAS_SIDLEMODE | SYSC_HAS_SOFTRESET), > .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART | > SIDLE_SMART_WKUP | MSTANDBY_FORCE | MSTANDBY_NO | > MSTANDBY_SMART | MSTANDBY_SMART_WKUP), > -- cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 21 Sep 2015, Roger Quadros wrote: > On 17/09/15 16:22, Javier Martinez Canillas wrote: > > Commit b483a4a5a711 ("ARM: OMAP4+: hwmod data: Don't prevent RESET of > > USB Host module") added the SYSC_HAS_RESET_STATUS flag to both OMAP4 > > and OMAP5 USB host module hwmon sysconfig but that flag was already > > set for OMAP5. So now the flag appears twice in the expression. > > > > make coccicheck complains with the following message: > > > > omap_hwmod_54xx_data.c:1846:37-58: duplicated argument to & or | > > > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > > Acked-by: Roger Quadros <rogerq@ti.com> Thanks, queued for v4.4. - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-omap2/omap_hwmod_54xx_data.c b/arch/arm/mach-omap2/omap_hwmod_54xx_data.c index 7c3fac035e93..8cdfd9b7ab4f 100644 --- a/arch/arm/mach-omap2/omap_hwmod_54xx_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_54xx_data.c @@ -1844,8 +1844,7 @@ static struct omap_hwmod_class_sysconfig omap54xx_usb_host_hs_sysc = { .rev_offs = 0x0000, .sysc_offs = 0x0010, .sysc_flags = (SYSC_HAS_MIDLEMODE | SYSC_HAS_RESET_STATUS | - SYSC_HAS_SIDLEMODE | SYSC_HAS_SOFTRESET | - SYSC_HAS_RESET_STATUS), + SYSC_HAS_SIDLEMODE | SYSC_HAS_SOFTRESET), .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART | SIDLE_SMART_WKUP | MSTANDBY_FORCE | MSTANDBY_NO | MSTANDBY_SMART | MSTANDBY_SMART_WKUP),
Commit b483a4a5a711 ("ARM: OMAP4+: hwmod data: Don't prevent RESET of USB Host module") added the SYSC_HAS_RESET_STATUS flag to both OMAP4 and OMAP5 USB host module hwmon sysconfig but that flag was already set for OMAP5. So now the flag appears twice in the expression. make coccicheck complains with the following message: omap_hwmod_54xx_data.c:1846:37-58: duplicated argument to & or | Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- arch/arm/mach-omap2/omap_hwmod_54xx_data.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)