diff mbox

ARM: dts: omap3: Include missing bandgap data for ti-soc-thermal driver

Message ID 1451086345-3340-1-git-send-email-pali.rohar@gmail.com
State New, archived
Headers show

Commit Message

Pali Rohár Dec. 25, 2015, 11:32 p.m. UTC
Driver for omap3 with documentation is there since v4.4-rc1.

Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
---
 arch/arm/boot/dts/omap34xx.dtsi |    5 +++++
 arch/arm/boot/dts/omap36xx.dtsi |    5 +++++
 2 files changed, 10 insertions(+)

Comments

Pavel Machek Dec. 26, 2015, 6:50 p.m. UTC | #1
On Sat 2015-12-26 00:32:25, Pali Rohár wrote:
> Driver for omap3 with documentation is there since v4.4-rc1.
> 
> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>

Acked-by: Pavel Machek <pavel@ucw.cz>
Tested-by: Pavel Machek <pavel@ucw.cz>

Thanks!
									Pavel
Eduardo Valentin Dec. 31, 2015, 5:38 p.m. UTC | #2
Hello,

On Sat, Dec 26, 2015 at 12:32:25AM +0100, Pali Rohár wrote:
> Driver for omap3 with documentation is there since v4.4-rc1.
> 
> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>


> ---
>  arch/arm/boot/dts/omap34xx.dtsi |    5 +++++
>  arch/arm/boot/dts/omap36xx.dtsi |    5 +++++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/omap34xx.dtsi b/arch/arm/boot/dts/omap34xx.dtsi
> index 4f6b2d5..c3f488f 100644
> --- a/arch/arm/boot/dts/omap34xx.dtsi
> +++ b/arch/arm/boot/dts/omap34xx.dtsi
> @@ -54,6 +54,11 @@
>  				#size-cells = <0>;
>  			};
>  		};
> +
> +		bandgap {
> +			reg = <0x48002524 0x4>;
> +			compatible = "ti,omap34xx-bandgap";
> +		};
>  	};
>  };
>  
> diff --git a/arch/arm/boot/dts/omap36xx.dtsi b/arch/arm/boot/dts/omap36xx.dtsi
> index 86253de..00f98c1 100644
> --- a/arch/arm/boot/dts/omap36xx.dtsi
> +++ b/arch/arm/boot/dts/omap36xx.dtsi
> @@ -86,6 +86,11 @@
>  				#size-cells = <0>;
>  			};
>  		};
> +
> +		bandgap {
> +			reg = <0x48002524 0x4>;
> +			compatible = "ti,omap36xx-bandgap";

Can you please already add on both cases

#thermal-sensor-cells = <0>;
?

This way we can already use them to define thermal zones. Of course,
that alone won't add the thermal zones. A separated patch would be
needed to add the thermal zone for OMAP3.

> +		};
>  	};
>  };
>  
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Pali Rohár Jan. 5, 2016, 11:30 a.m. UTC | #3
On Thursday 31 December 2015 09:38:45 Eduardo Valentin wrote:
> > +
> > +		bandgap {
> > +			reg = <0x48002524 0x4>;
> > +			compatible = "ti,omap36xx-bandgap";
> 
> Can you please already add on both cases
> 
> #thermal-sensor-cells = <0>;
> ?
> 
> This way we can already use them to define thermal zones. Of course,
> that alone won't add the thermal zones. A separated patch would be
> needed to add the thermal zone for OMAP3.

Are you going to add thermal zone defines? If yes, then it would make
sense to add that #thermal line together with thermal zone defines...
Pali Rohár Jan. 21, 2016, 9:47 a.m. UTC | #4
On Saturday 26 December 2015 00:32:25 Pali Rohár wrote:
> Driver for omap3 with documentation is there since v4.4-rc1.
> 
> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> ---
>  arch/arm/boot/dts/omap34xx.dtsi |    5 +++++
>  arch/arm/boot/dts/omap36xx.dtsi |    5 +++++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/omap34xx.dtsi b/arch/arm/boot/dts/omap34xx.dtsi
> index 4f6b2d5..c3f488f 100644
> --- a/arch/arm/boot/dts/omap34xx.dtsi
> +++ b/arch/arm/boot/dts/omap34xx.dtsi
> @@ -54,6 +54,11 @@
>  				#size-cells = <0>;
>  			};
>  		};
> +
> +		bandgap {
> +			reg = <0x48002524 0x4>;
> +			compatible = "ti,omap34xx-bandgap";
> +		};
>  	};
>  };
>  
> diff --git a/arch/arm/boot/dts/omap36xx.dtsi b/arch/arm/boot/dts/omap36xx.dtsi
> index 86253de..00f98c1 100644
> --- a/arch/arm/boot/dts/omap36xx.dtsi
> +++ b/arch/arm/boot/dts/omap36xx.dtsi
> @@ -86,6 +86,11 @@
>  				#size-cells = <0>;
>  			};
>  		};
> +
> +		bandgap {
> +			reg = <0x48002524 0x4>;
> +			compatible = "ti,omap36xx-bandgap";
> +		};
>  	};
>  };
>  

PING! Who can take this patch?
Tony Lindgren Jan. 21, 2016, 5:15 p.m. UTC | #5
* Pali Rohár <pali.rohar@gmail.com> [160121 01:48]:
> On Saturday 26 December 2015 00:32:25 Pali Rohár wrote:
> > Driver for omap3 with documentation is there since v4.4-rc1.
...

> PING! Who can take this patch?

Sounds like /me, but after -rc1 when any possible regressions
are out of the way :)

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Pali Rohár Jan. 27, 2016, 10:04 a.m. UTC | #6
On Thursday 21 January 2016 09:15:01 Tony Lindgren wrote:
> * Pali Rohár <pali.rohar@gmail.com> [160121 01:48]:
> > On Saturday 26 December 2015 00:32:25 Pali Rohár wrote:
> > > Driver for omap3 with documentation is there since v4.4-rc1.
> ...
> 
> > PING! Who can take this patch?
> 
> Sounds like /me, but after -rc1 when any possible regressions
> are out of the way :)

Great! Just to note that 4.5-rc1 is out.

I just do not want to see this patch lost...
Tony Lindgren Jan. 27, 2016, 4:09 p.m. UTC | #7
* Pali Rohár <pali.rohar@gmail.com> [160127 02:05]:
> On Thursday 21 January 2016 09:15:01 Tony Lindgren wrote:
> > * Pali Rohár <pali.rohar@gmail.com> [160121 01:48]:
> > > On Saturday 26 December 2015 00:32:25 Pali Rohár wrote:
> > > > Driver for omap3 with documentation is there since v4.4-rc1.
> > ...
> > 
> > > PING! Who can take this patch?
> > 
> > Sounds like /me, but after -rc1 when any possible regressions
> > are out of the way :)
> 
> Great! Just to note that 4.5-rc1 is out.
> 
> I just do not want to see this patch lost...

So is this critical to have as a fix since it's thermal related?

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sebastian Reichel Jan. 27, 2016, 6:19 p.m. UTC | #8
Hi,

On Wed, Jan 27, 2016 at 08:09:46AM -0800, Tony Lindgren wrote:
> * Pali Rohár <pali.rohar@gmail.com> [160127 02:05]:
> > On Thursday 21 January 2016 09:15:01 Tony Lindgren wrote:
> > > * Pali Rohár <pali.rohar@gmail.com> [160121 01:48]:
> > > > On Saturday 26 December 2015 00:32:25 Pali Rohár wrote:
> > > > > Driver for omap3 with documentation is there since v4.4-rc1.
> > > ...
> > > 
> > > > PING! Who can take this patch?
> > > 
> > > Sounds like /me, but after -rc1 when any possible regressions
> > > are out of the way :)
> > 
> > Great! Just to note that 4.5-rc1 is out.
> > 
> > I just do not want to see this patch lost...
> 
> So is this critical to have as a fix since it's thermal related?

According to somebody from TI, who previously took part in the patch
discussion, the thermal sensors of omap3 are to imprecise to be used
for thermal decisions. The driver "just" informs userspace about the
temperatures.

-- Sebastian
Tony Lindgren Jan. 27, 2016, 6:24 p.m. UTC | #9
* Sebastian Reichel <sre@kernel.org> [160127 10:20]:
> Hi,
> 
> On Wed, Jan 27, 2016 at 08:09:46AM -0800, Tony Lindgren wrote:
> > * Pali Rohár <pali.rohar@gmail.com> [160127 02:05]:
> > > On Thursday 21 January 2016 09:15:01 Tony Lindgren wrote:
> > > > * Pali Rohár <pali.rohar@gmail.com> [160121 01:48]:
> > > > > On Saturday 26 December 2015 00:32:25 Pali Rohár wrote:
> > > > > > Driver for omap3 with documentation is there since v4.4-rc1.
> > > > ...
> > > > 
> > > > > PING! Who can take this patch?
> > > > 
> > > > Sounds like /me, but after -rc1 when any possible regressions
> > > > are out of the way :)
> > > 
> > > Great! Just to note that 4.5-rc1 is out.
> > > 
> > > I just do not want to see this patch lost...
> > 
> > So is this critical to have as a fix since it's thermal related?
> 
> According to somebody from TI, who previously took part in the patch
> discussion, the thermal sensors of omap3 are to imprecise to be used
> for thermal decisions. The driver "just" informs userspace about the
> temperatures.

OK applying into omap-for-v4.6/dt then thanks.

Tony


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/omap34xx.dtsi b/arch/arm/boot/dts/omap34xx.dtsi
index 4f6b2d5..c3f488f 100644
--- a/arch/arm/boot/dts/omap34xx.dtsi
+++ b/arch/arm/boot/dts/omap34xx.dtsi
@@ -54,6 +54,11 @@ 
 				#size-cells = <0>;
 			};
 		};
+
+		bandgap {
+			reg = <0x48002524 0x4>;
+			compatible = "ti,omap34xx-bandgap";
+		};
 	};
 };
 
diff --git a/arch/arm/boot/dts/omap36xx.dtsi b/arch/arm/boot/dts/omap36xx.dtsi
index 86253de..00f98c1 100644
--- a/arch/arm/boot/dts/omap36xx.dtsi
+++ b/arch/arm/boot/dts/omap36xx.dtsi
@@ -86,6 +86,11 @@ 
 				#size-cells = <0>;
 			};
 		};
+
+		bandgap {
+			reg = <0x48002524 0x4>;
+			compatible = "ti,omap36xx-bandgap";
+		};
 	};
 };