diff mbox

ARM: dts: omap3-n900: Allow gpio keys to be disabled

Message ID 1452447990-22775-1-git-send-email-ivo.g.dimitrov.75@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ivaylo Dimitrov Jan. 10, 2016, 5:46 p.m. UTC
Add linux,can-disable; to all gpios exported from gpio-keys driver, so
userspace can disable them

Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
---
 arch/arm/boot/dts/omap3-n900.dts | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Ivaylo Dimitrov Jan. 21, 2016, 7:58 a.m. UTC | #1
Ping

On 10.01.2016 19:46, Ivaylo Dimitrov wrote:
> Add linux,can-disable; to all gpios exported from gpio-keys driver, so
> userspace can disable them
>
> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> ---
>   arch/arm/boot/dts/omap3-n900.dts | 6 ++++++
>   1 file changed, 6 insertions(+)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sebastian Reichel Jan. 27, 2016, 11:47 p.m. UTC | #2
Hi,

On Sun, Jan 10, 2016 at 07:46:30PM +0200, Ivaylo Dimitrov wrote:
> Add linux,can-disable; to all gpios exported from gpio-keys driver, so
> userspace can disable them
> 
> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>

Acked-By: Sebastian Reichel <sre@kernel.org>

-- Sebastian
Tony Lindgren Feb. 12, 2016, 9:53 p.m. UTC | #3
* Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> [160110 09:47]:
> Add linux,can-disable; to all gpios exported from gpio-keys driver, so
> userspace can disable them
...
> --- a/arch/arm/boot/dts/omap3-n900.dts
> +++ b/arch/arm/boot/dts/omap3-n900.dts
> @@ -68,6 +68,7 @@
>  			linux,input-type = <EV_SW>;
>  			linux,code = <SW_CAMERA_LENS_COVER>;
>  			gpio-key,wakeup;
> +			linux,can-disable;
>  		};
>  
>  		camera_focus {

Looks like this no longer applies because of linux,can-disable
to wakeup-source changes. Can you please update against v4.5-rc
series and repost?

Thanks,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ivaylo Dimitrov Feb. 21, 2016, 5:49 p.m. UTC | #4
On 12.02.2016 23:53, Tony Lindgren wrote:
>
> Looks like this no longer applies because of linux,can-disable
> to wakeup-source changes. Can you please update against v4.5-rc
> series and repost?

Could you elaborate on that? As I don't really understand what needs to 
be updated and what are "wakeup-source changes".

Thanks,
Ivo
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sebastian Reichel Feb. 21, 2016, 7:18 p.m. UTC | #5
Hi Ivo,

On Sun, Feb 21, 2016 at 07:49:30PM +0200, Ivaylo Dimitrov wrote:
> On 12.02.2016 23:53, Tony Lindgren wrote:
> >Looks like this no longer applies because of linux,can-disable
> >to wakeup-source changes. Can you please update against v4.5-rc
> >series and repost?
> 
> Could you elaborate on that? As I don't really understand what needs to be
> updated and what are "wakeup-source changes".

Due to changes in the kernel source  (each gpio key in omap3-n900.dts
gained a "wakeup-source" property) the patch can no longer be applied
using "git am". Just rebase your patch to current 4.5-rc and resend it.

-- Sebastian
diff mbox

Patch

diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
index 8ea924c..b58e8a0 100644
--- a/arch/arm/boot/dts/omap3-n900.dts
+++ b/arch/arm/boot/dts/omap3-n900.dts
@@ -68,6 +68,7 @@ 
 			linux,input-type = <EV_SW>;
 			linux,code = <SW_CAMERA_LENS_COVER>;
 			gpio-key,wakeup;
+			linux,can-disable;
 		};
 
 		camera_focus {
@@ -75,6 +76,7 @@ 
 			gpios = <&gpio3 4 GPIO_ACTIVE_LOW>; /* 68 */
 			linux,code = <KEY_CAMERA_FOCUS>;
 			gpio-key,wakeup;
+			linux,can-disable;
 		};
 
 		camera_capture {
@@ -82,6 +84,7 @@ 
 			gpios = <&gpio3 5 GPIO_ACTIVE_LOW>; /* 69 */
 			linux,code = <KEY_CAMERA>;
 			gpio-key,wakeup;
+			linux,can-disable;
 		};
 
 		lock_button {
@@ -89,6 +92,7 @@ 
 			gpios = <&gpio4 17 GPIO_ACTIVE_LOW>; /* 113 */
 			linux,code = <KEY_SCREENLOCK>;
 			gpio-key,wakeup;
+			linux,can-disable;
 		};
 
 		keypad_slide {
@@ -97,6 +101,7 @@ 
 			linux,input-type = <EV_SW>;
 			linux,code = <SW_KEYPAD_SLIDE>;
 			gpio-key,wakeup;
+			linux,can-disable;
 		};
 
 		proximity_sensor {
@@ -104,6 +109,7 @@ 
 			gpios = <&gpio3 25 GPIO_ACTIVE_HIGH>; /* 89 */
 			linux,input-type = <EV_SW>;
 			linux,code = <SW_FRONT_PROXIMITY>;
+			linux,can-disable;
 		};
 	};