diff mbox

ARM: DRA722: Add ID detect for Silicon Rev 2.0

Message ID 1457556991-10729-1-git-send-email-vishalm@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Vishal Mahaveer March 9, 2016, 8:56 p.m. UTC
From: Vishal Mahaveer <vishalm@ti.com>

Silicon Rev 2.0 is a minor variant of Rev 1.0. Rev 2.0 is an incremental revision
with various fixes including the following:
    - Reset logic fixes
    - Few asymetric aging logic fixes
    - Ethernet speed fixes
    - EDMA fixes for McASP

Signed-off-by: Vishal Mahaveer <vishalm@ti.com>
---
 arch/arm/mach-omap2/id.c  |    4 ++--
 arch/arm/mach-omap2/soc.h |    1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

Comments

Nishanth Menon March 10, 2016, 10:44 p.m. UTC | #1
On 03/09/2016 02:56 PM, Vishal Mahaveer wrote:
> From: Vishal Mahaveer <vishalm@ti.com>
> 
> Silicon Rev 2.0 is a minor variant of Rev 1.0. Rev 2.0 is an incremental revision
> with various fixes including the following:
>     - Reset logic fixes
>     - Few asymetric aging logic fixes
minor:
s/asymetric/asymmetric/

>     - Ethernet speed fixes
>     - EDMA fixes for McASP
> 
> Signed-off-by: Vishal Mahaveer <vishalm@ti.com>
> ---
>  arch/arm/mach-omap2/id.c  |    4 ++--
>  arch/arm/mach-omap2/soc.h |    1 +
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
> index 8a2ae82..84ee602 100644
> --- a/arch/arm/mach-omap2/id.c
> +++ b/arch/arm/mach-omap2/id.c
> @@ -667,9 +667,9 @@ void __init dra7xxx_check_revision(void)
>  		case 0:
>  			omap_revision = DRA722_REV_ES1_0;
>  			break;
> +		case 1:
>  		default:
> -			/* If we have no new revisions */
> -			omap_revision = DRA722_REV_ES1_0;
> +			omap_revision = DRA722_REV_ES2_0;
>  			break;
>  		}
>  		break;
> diff --git a/arch/arm/mach-omap2/soc.h b/arch/arm/mach-omap2/soc.h
> index 83d3547..464e73f 100644
> --- a/arch/arm/mach-omap2/soc.h
> +++ b/arch/arm/mach-omap2/soc.h
> @@ -471,6 +471,7 @@ IS_OMAP_TYPE(3430, 0x3430)
>  #define DRA752_REV_ES1_1	(DRA7XX_CLASS | (0x52 << 16) | (0x11 << 8))
>  #define DRA752_REV_ES2_0	(DRA7XX_CLASS | (0x52 << 16) | (0x20 << 8))
>  #define DRA722_REV_ES1_0	(DRA7XX_CLASS | (0x22 << 16) | (0x10 << 8))
> +#define DRA722_REV_ES2_0	(DRA7XX_CLASS | (0x22 << 16) | (0x20 << 8))
>  
>  void omap2xxx_check_revision(void);
>  void omap3xxx_check_revision(void);
> 
otherwise,
for me:
Acked-by: Nishanth Menon <nm@ti.com>
Tony Lindgren March 30, 2016, 8:56 p.m. UTC | #2
* Nishanth Menon <nm@ti.com> [160310 14:44]:
> On 03/09/2016 02:56 PM, Vishal Mahaveer wrote:
> > From: Vishal Mahaveer <vishalm@ti.com>
> > 
> > Silicon Rev 2.0 is a minor variant of Rev 1.0. Rev 2.0 is an incremental revision
> > with various fixes including the following:
> >     - Reset logic fixes
> >     - Few asymetric aging logic fixes
> minor:
> s/asymetric/asymmetric/

I'll update that while applying.

> >     - Ethernet speed fixes
> >     - EDMA fixes for McASP
> > 
> > Signed-off-by: Vishal Mahaveer <vishalm@ti.com>
> > ---
> >  arch/arm/mach-omap2/id.c  |    4 ++--
> >  arch/arm/mach-omap2/soc.h |    1 +
> >  2 files changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
> > index 8a2ae82..84ee602 100644
> > --- a/arch/arm/mach-omap2/id.c
> > +++ b/arch/arm/mach-omap2/id.c
> > @@ -667,9 +667,9 @@ void __init dra7xxx_check_revision(void)
> >  		case 0:
> >  			omap_revision = DRA722_REV_ES1_0;
> >  			break;
> > +		case 1:
> >  		default:
> > -			/* If we have no new revisions */
> > -			omap_revision = DRA722_REV_ES1_0;
> > +			omap_revision = DRA722_REV_ES2_0;
> >  			break;
> >  		}
> >  		break;
> > diff --git a/arch/arm/mach-omap2/soc.h b/arch/arm/mach-omap2/soc.h
> > index 83d3547..464e73f 100644
> > --- a/arch/arm/mach-omap2/soc.h
> > +++ b/arch/arm/mach-omap2/soc.h
> > @@ -471,6 +471,7 @@ IS_OMAP_TYPE(3430, 0x3430)
> >  #define DRA752_REV_ES1_1	(DRA7XX_CLASS | (0x52 << 16) | (0x11 << 8))
> >  #define DRA752_REV_ES2_0	(DRA7XX_CLASS | (0x52 << 16) | (0x20 << 8))
> >  #define DRA722_REV_ES1_0	(DRA7XX_CLASS | (0x22 << 16) | (0x10 << 8))
> > +#define DRA722_REV_ES2_0	(DRA7XX_CLASS | (0x22 << 16) | (0x20 << 8))
> >  
> >  void omap2xxx_check_revision(void);
> >  void omap3xxx_check_revision(void);
> > 
> otherwise,
> for me:
> Acked-by: Nishanth Menon <nm@ti.com>

Applying into omap-for-v4.6/fixes thanks.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
index 8a2ae82..84ee602 100644
--- a/arch/arm/mach-omap2/id.c
+++ b/arch/arm/mach-omap2/id.c
@@ -667,9 +667,9 @@  void __init dra7xxx_check_revision(void)
 		case 0:
 			omap_revision = DRA722_REV_ES1_0;
 			break;
+		case 1:
 		default:
-			/* If we have no new revisions */
-			omap_revision = DRA722_REV_ES1_0;
+			omap_revision = DRA722_REV_ES2_0;
 			break;
 		}
 		break;
diff --git a/arch/arm/mach-omap2/soc.h b/arch/arm/mach-omap2/soc.h
index 83d3547..464e73f 100644
--- a/arch/arm/mach-omap2/soc.h
+++ b/arch/arm/mach-omap2/soc.h
@@ -471,6 +471,7 @@  IS_OMAP_TYPE(3430, 0x3430)
 #define DRA752_REV_ES1_1	(DRA7XX_CLASS | (0x52 << 16) | (0x11 << 8))
 #define DRA752_REV_ES2_0	(DRA7XX_CLASS | (0x52 << 16) | (0x20 << 8))
 #define DRA722_REV_ES1_0	(DRA7XX_CLASS | (0x22 << 16) | (0x10 << 8))
+#define DRA722_REV_ES2_0	(DRA7XX_CLASS | (0x22 << 16) | (0x20 << 8))
 
 void omap2xxx_check_revision(void);
 void omap3xxx_check_revision(void);