From patchwork Tue May 3 15:16:21 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9004751 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 2B4E0BF29F for ; Tue, 3 May 2016 15:18:21 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 415BF202B8 for ; Tue, 3 May 2016 15:18:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 561D3200DE for ; Tue, 3 May 2016 15:18:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933539AbcECPSH (ORCPT ); Tue, 3 May 2016 11:18:07 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:62987 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755845AbcECPSF (ORCPT ); Tue, 3 May 2016 11:18:05 -0400 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue004) with ESMTPA (Nemesis) id 0Lsuti-1bdnfv0IqA-012cU5; Tue, 03 May 2016 17:17:29 +0200 From: Arnd Bergmann To: Sebastian Reichel Cc: Pavel Machek , Arnd Bergmann , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Andrzej Hajda , Sanjeev Sharma , Roger Quadros Subject: [PATCH 2/3] HSI: omap-ssi: include pinctrl header files Date: Tue, 3 May 2016 17:16:21 +0200 Message-Id: <1462288586-584690-3-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1462288586-584690-1-git-send-email-arnd@arndb.de> References: <1462288586-584690-1-git-send-email-arnd@arndb.de> X-Provags-ID: V03:K0:telurkJA5izk0uSFce8fNKA7o+wXxX6ahjOVpQSHs/jCROow+7Z ZtD7zK6iz7KIQ28OJFmC14UWW8MM1mh0PmEMFqzaiQAqTejmQNlr/xDS8I2t090dkyKJaOD jBdTUiM3XWrpRnqeD1kSsglLMcXiy+NYS8UkJM/attraEKTlV/bnKiWjCZQscIYdZjp5kuK yr2tojQbFeCtMNL7ptjlA== X-UI-Out-Filterresults: notjunk:1; V01:K0:KOtlp27Smtw=:x0oBVbhq7y38j8pt4LlHvs lkhjqJwq7uWA5IDviQCF7dnsQ5h79SDqo3fUbWGrZaqZGTmTpm5OJCCrzoNnpPJwlqejyXw7S Ha6gyWHvr3dydCBBUyp7AP3t5ZHsUNqaqSHhPjhCbiAhdK3lgYJGJmvWJ4o/C3DafcYF7lHsM iavIEspiPuExHI+zwlxqPmDxaVLBlhxEW4O7l4QchhgdebvjK0iVacIDbLa8m3LEer8f+nhDh 7Ce4N78k4MpnvoluA93hNrlVT7uK3CRCid8zQiNu5Txq9I+v7uO/vlLgtJXQY0nlPOEbNVe3C tCFGr1eIvIgmrjT9MnZWvUVVqzd1ZtdJJs0jx6s2U2rIXSdYbfUIwS4j6vvnDZjm6BsWofieT DjgIEHTv3w5WTU/ZvgJvAcL0WCcrl0OKYiyVeRi41lFO+lc1MkN0ixtpxEG0/EsNEIyyh1Csu P+xUATrEPsEaSbM0fJ3s2jM4KKdDu629n7nnhlbacCJihF7fnrAmPAqAy6T7FpOcsIlKUnRMd Ke9yVYZqeYjzbBPXUaRpiEulPkaA5AN/eNvGmbk8bdh2KpzXdDEPw5uL/FEAv9ijlhguikyNX IODKAXqa1d/VWp5NNAw0Jx263w6qydhGDs5d3i48sCDgb4Ace/78CPYDsr7NfAXVlCY03tpgq 0KwVA7lAn5rY01vPa9jx0+hC/VsRef4CiMBV7Uxa+48vnH7waGVLgXuVYdHz9nHhMX5M= Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver now uses some pinctrl functions, but fails to build if PINCTRL is disabled because the respective header files are only included indirectly: drivers/hsi/controllers/omap_ssi_core.c: In function 'ssi_clk_event': drivers/hsi/controllers/omap_ssi_core.c:317:4: error: implicit declaration of function 'pinctrl_pm_select_idle_state' [-Werror=implicit-function-declaration] drivers/hsi/controllers/omap_ssi_core.c:339:4: error: implicit declaration of function 'pinctrl_pm_select_default_state' [-Werror=implicit-function-declaration] drivers/hsi/controllers/omap_ssi_port.c: In function 'ssi_flush': drivers/hsi/controllers/omap_ssi_port.c:520:2: error: implicit declaration of function 'pinctrl_pm_select_idle_state' [-Werror=implicit-function-declaration] This includes the headers from the files that call the functions, which works even if pinctrl is turned off. Signed-off-by: Arnd Bergmann Fixes: 4bcf7414528a ("HSI: omap-ssi: add clk change support") --- drivers/hsi/controllers/omap_ssi_core.c | 1 + drivers/hsi/controllers/omap_ssi_port.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/hsi/controllers/omap_ssi_core.c b/drivers/hsi/controllers/omap_ssi_core.c index 15b2a600d77b..a3e0febfb64a 100644 --- a/drivers/hsi/controllers/omap_ssi_core.c +++ b/drivers/hsi/controllers/omap_ssi_core.c @@ -35,6 +35,7 @@ #include #include #include +#include #include #include #include diff --git a/drivers/hsi/controllers/omap_ssi_port.c b/drivers/hsi/controllers/omap_ssi_port.c index 98b22e88085c..ca7139eaaa1d 100644 --- a/drivers/hsi/controllers/omap_ssi_port.c +++ b/drivers/hsi/controllers/omap_ssi_port.c @@ -26,6 +26,7 @@ #include #include +#include #include #include "omap_ssi_regs.h"