| Message ID | 1482158681-4530-3-git-send-email-javier@osg.samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Monday 19 December 2016 15:44:34 Javier Martinez Canillas wrote: > Commit 008a2ebcd677 ("ARM: dts: omap3: Remove skeleton.dtsi usage") > removed the skeleton.dtsi usage since we want to get rid of it. > > But this can cause issues when booting a kernel with a boot-loader > that doesn't create a chosen node if this isn't present in the DTB > since the decompressor relies on a pre-existing chosen node to be > available to insert the command line and merge other ATAGS info. > > Fixes: 008a2ebcd677 ("ARM: dts: omap3: Remove skeleton.dtsi usage") > Reported-by: Pali Rohar <pali.rohar@gmail.com> > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> Including empty chosen node fixes (or rather workaround) this problem. You can add my Tested-By.
diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi index ecf5eb584c75..a3ff4933dbc1 100644 --- a/arch/arm/boot/dts/omap3.dtsi +++ b/arch/arm/boot/dts/omap3.dtsi @@ -17,6 +17,7 @@ interrupt-parent = <&intc>; #address-cells = <1>; #size-cells = <1>; + chosen { }; aliases { i2c0 = &i2c1;
Commit 008a2ebcd677 ("ARM: dts: omap3: Remove skeleton.dtsi usage") removed the skeleton.dtsi usage since we want to get rid of it. But this can cause issues when booting a kernel with a boot-loader that doesn't create a chosen node if this isn't present in the DTB since the decompressor relies on a pre-existing chosen node to be available to insert the command line and merge other ATAGS info. Fixes: 008a2ebcd677 ("ARM: dts: omap3: Remove skeleton.dtsi usage") Reported-by: Pali Rohar <pali.rohar@gmail.com> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- arch/arm/boot/dts/omap3.dtsi | 1 + 1 file changed, 1 insertion(+)