| Message ID | 1487103222-27182-1-git-send-email-aford173@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* aford173@gmail.com <aford173@gmail.com> [170214 12:18]: > From: Adam Ford <aford173@gmail.com> > > By default, the TWL4030 charger, TWL4030-Keypad and SSI are enabled. > Logic PD recomends not using this charger for thermal reasons, and > the devkit does not suppor either the keypad or SSI. Because these > are enabled by default, but incomplete in the device tree, this > throws a few warnings/errors. This patch will eliminate those > messages by disabling the unused features. > > Signed-off-by: Adam Ford <aford173@gmail.com> > > diff --git a/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit.dts b/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit.dts > index 08cce17..ee5f07f 100644 > --- a/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit.dts > +++ b/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit.dts > @@ -402,3 +402,11 @@ > mode = <3>; > power = <50>; > }; > + > +&ssi { > + status = "disabled"; > +}; You may want to measure the power consumption with this change as now ssi driver is never probed or idled so it's up to the bootloader to idle it properly. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* Adam Ford <aford173@gmail.com> [170216 14:00]: > On Feb 16, 2017 3:46 PM, "Tony Lindgren" <tony@atomide.com> wrote: > > * aford173@gmail.com <aford173@gmail.com> [170214 12:18]: > > From: Adam Ford <aford173@gmail.com> > > > > By default, the TWL4030 charger, TWL4030-Keypad and SSI are enabled. > > Logic PD recomends not using this charger for thermal reasons, and > > the devkit does not suppor either the keypad or SSI. Because these > > are enabled by default, but incomplete in the device tree, this > > throws a few warnings/errors. This patch will eliminate those > > messages by disabling the unused features. > > > > Signed-off-by: Adam Ford <aford173@gmail.com> > > > > diff --git a/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit.dts > b/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit.dts > > index 08cce17..ee5f07f 100644 > > --- a/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit.dts > > +++ b/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit.dts > > @@ -402,3 +402,11 @@ > > mode = <3>; > > power = <50>; > > }; > > + > > +&ssi { > > + status = "disabled"; > > +}; > > You may want to measure the power consumption with this change > as now ssi driver is never probed or idled so it's up to the > bootloader to idle it properly. > > > I didn't know that. I will run some tests. Can we hold off on applying this > until I can check it? Sure yeah I'll wait. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit.dts b/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit.dts index 08cce17..ee5f07f 100644 --- a/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit.dts +++ b/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit.dts @@ -402,3 +402,11 @@ mode = <3>; power = <50>; }; + +&ssi { + status = "disabled"; +}; + +&twl_keypad { + status = "disabled"; +}; diff --git a/arch/arm/boot/dts/logicpd-torpedo-som.dtsi b/arch/arm/boot/dts/logicpd-torpedo-som.dtsi index 8f9a69c..ea319b8 100644 --- a/arch/arm/boot/dts/logicpd-torpedo-som.dtsi +++ b/arch/arm/boot/dts/logicpd-torpedo-som.dtsi @@ -242,3 +242,7 @@ &twl_gpio { ti,use-leds; }; + +&charger { + status = "disabled"; +};