From patchwork Wed Sep 20 10:06:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 9961249 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4461E6056A for ; Wed, 20 Sep 2017 10:07:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 341BC2884F for ; Wed, 20 Sep 2017 10:07:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 22F97288BD; Wed, 20 Sep 2017 10:07:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F351728864 for ; Wed, 20 Sep 2017 10:07:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751775AbdITKHQ (ORCPT ); Wed, 20 Sep 2017 06:07:16 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:36871 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751722AbdITKHO (ORCPT ); Wed, 20 Sep 2017 06:07:14 -0400 Received: by mail-pg0-f65.google.com with SMTP id v5so1382207pgn.4; Wed, 20 Sep 2017 03:07:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=MQ6i9uXC1pI6R8MCIzH2cRRwlYy18zYzU8hhVbWzst4=; b=WZRK6xu5Bg0BimUGshCH/HMrSiS3wIHshrTr4I8PEbwk07Hz4uurbhKmP7LjG9wLIj R6ZZ+OJPjJJgLchEceO0+KVsYpmB+KmuCceluxSESp1VxaPhLduj5sOmMOoj9whaguku 5/sNvykmmazXePQIFIqf9zwleTDuQnq277sj4KOfi9jf9sAvHSQSANlkwsQkhIu4Jmsw gVa617CrJZuRckdCTViF5abgAttl21wpouMiDSWkD/gAAaa58mW/hAUS0plzBWgz3Pz6 vPgXtnsiWRBPEM5hE8TUcEdB6Im36U/D4xKgOZBQLcdUG9gFtZHN5QvkT3mNPgmCEWpS W43Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=MQ6i9uXC1pI6R8MCIzH2cRRwlYy18zYzU8hhVbWzst4=; b=nVgJl4V0A+GakW3Dd1mzhwEnMmAg4WzW6CDgVu/vUCwrPUkOMGKJ+Y3G9Uz5Zs3Tuq caibsmO/RxLwg2zKI4hOka2ZpzF2UnLXgn4vZbB7pK5bwkojD2U4x1l0hx9esKXGWEfE 6E158iF0JrgFZAu7Z+FUwibtNwRedf5Dpi8MavBjNrF3BHCF5MNQC+0RiskMtQIY7MlC 66UKou0HCQrLu5hp5uGoQoJyhyE3hNcaqNVv+z7lKnz8IaHbCr+9/u1+HMn6wkEEqBN0 da+7JOUdQKM9ivNReflC7kD36EP9GUMCbG/9by7lTe+namCEy1t1NzwTkibDGd1Ls1Js 5Gkw== X-Gm-Message-State: AHPjjUiJa3QcF6ECHVT6wuW4sk88r7HWj7Sq2gZLK9n65UHuQvJsPOXR 7aRFteG3t6Jm84sRkVtp9xY= X-Google-Smtp-Source: AOwi7QAKhDB7ZuK5g7oUHWK0sfUgdMOjQd+5j/E3mTFrFy7OELPncVOL5O1QdfYPHdqDdYaPAFfbhQ== X-Received: by 10.101.82.9 with SMTP id o9mr1685584pgp.42.1505902033633; Wed, 20 Sep 2017 03:07:13 -0700 (PDT) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id u12sm10492250pfg.146.2017.09.20.03.07.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 20 Sep 2017 03:07:13 -0700 (PDT) From: Arvind Yadav To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, timur@tabi.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com, fabio.estevam@nxp.com, peter.ujfalusi@ti.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org, linux-omap@vger.kernel.org Subject: [PATCH 1/3] ASoC: davinci-mcasp: Handle return value of devm_kasprintf Date: Wed, 20 Sep 2017 15:36:09 +0530 Message-Id: <1505901971-12004-2-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1505901971-12004-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1505901971-12004-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP devm_kasprintf() can fail here and we must check its return value. Signed-off-by: Arvind Yadav Acked-by: Peter Ujfalusi --- sound/soc/davinci/davinci-mcasp.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c index f395bbc..d1a4aa2 100644 --- a/sound/soc/davinci/davinci-mcasp.c +++ b/sound/soc/davinci/davinci-mcasp.c @@ -1867,6 +1867,10 @@ static int davinci_mcasp_probe(struct platform_device *pdev) if (irq >= 0) { irq_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s_common", dev_name(&pdev->dev)); + if (!irq_name) { + ret = -ENOMEM; + goto err; + } ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, davinci_mcasp_common_irq_handler, IRQF_ONESHOT | IRQF_SHARED, @@ -1884,6 +1888,10 @@ static int davinci_mcasp_probe(struct platform_device *pdev) if (irq >= 0) { irq_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s_rx", dev_name(&pdev->dev)); + if (!irq_name) { + ret = -ENOMEM; + goto err; + } ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, davinci_mcasp_rx_irq_handler, IRQF_ONESHOT, irq_name, mcasp); @@ -1899,6 +1907,10 @@ static int davinci_mcasp_probe(struct platform_device *pdev) if (irq >= 0) { irq_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s_tx", dev_name(&pdev->dev)); + if (!irq_name) { + ret = -ENOMEM; + goto err; + } ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, davinci_mcasp_tx_irq_handler, IRQF_ONESHOT, irq_name, mcasp);