diff mbox series

[2/3] dt-bindings: usb: keystone-usb: Add ti,am654-dwc3 support

Message ID 1544023171-5796-3-git-send-email-rogerq@ti.com (mailing list archive)
State New, archived
Headers show
Series usb: dwc3: Add support for AM654 USB | expand

Commit Message

Roger Quadros Dec. 5, 2018, 3:19 p.m. UTC
The AM654 SoC from TI contains a DWC3 controller. Add
support for it.

Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 Documentation/devicetree/bindings/usb/keystone-usb.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Vignesh Raghavendra Dec. 6, 2018, 10:32 a.m. UTC | #1
Hi Roger,

On 05/12/18 8:49 PM, Roger Quadros wrote:
> The AM654 SoC from TI contains a DWC3 controller. Add
> support for it.
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
>  Documentation/devicetree/bindings/usb/keystone-usb.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/keystone-usb.txt b/Documentation/devicetree/bindings/usb/keystone-usb.txt
> index f96e09f..fa29ff8 100644
> --- a/Documentation/devicetree/bindings/usb/keystone-usb.txt
> +++ b/Documentation/devicetree/bindings/usb/keystone-usb.txt
> @@ -3,7 +3,7 @@ TI Keystone Soc USB Controller
>  DWC3 GLUE
>  
>  Required properties:
> - - compatible: should be "ti,keystone-dwc3".
> + - compatible: should be "ti,keystone-dwc3" or "ti,am654-dwc3".

Convention is to have one compatible per line:
 compatible: Should be
	"ti,am654-dwc3" for AM654 SoCs
	"ti,keystone-dwc3" for K2 SoCs



>   - #address-cells, #size-cells : should be '1' if the device has sub-nodes
>     with 'reg' property.
>   - reg : Address and length of the register set for the USB subsystem on
> @@ -21,7 +21,7 @@ SoCs only:
>  - clock-names:		Must be "usb".
>  
>  
> -The following are mandatory properties for Keystone 2 66AK2G SoCs only:
> +The following are mandatory properties for 66AK2G and AM654:
>  
>  - power-domains:	Should contain a phandle to a PM domain provider node
>  			and an args specifier containing the USB device id
>
Roger Quadros Dec. 10, 2018, 9:05 a.m. UTC | #2
Hi Vignesh,

On 06/12/18 12:32, Vignesh R wrote:
> Hi Roger,
> 
> On 05/12/18 8:49 PM, Roger Quadros wrote:
>> The AM654 SoC from TI contains a DWC3 controller. Add
>> support for it.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> ---
>>  Documentation/devicetree/bindings/usb/keystone-usb.txt | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/keystone-usb.txt b/Documentation/devicetree/bindings/usb/keystone-usb.txt
>> index f96e09f..fa29ff8 100644
>> --- a/Documentation/devicetree/bindings/usb/keystone-usb.txt
>> +++ b/Documentation/devicetree/bindings/usb/keystone-usb.txt
>> @@ -3,7 +3,7 @@ TI Keystone Soc USB Controller
>>  DWC3 GLUE
>>  
>>  Required properties:
>> - - compatible: should be "ti,keystone-dwc3".
>> + - compatible: should be "ti,keystone-dwc3" or "ti,am654-dwc3".
> 
> Convention is to have one compatible per line:
>  compatible: Should be
> 	"ti,am654-dwc3" for AM654 SoCs
> 	"ti,keystone-dwc3" for K2 SoCs
> 

OK. Will fix it up. Thanks.

cheers,
-roger

> 
> 
>>   - #address-cells, #size-cells : should be '1' if the device has sub-nodes
>>     with 'reg' property.
>>   - reg : Address and length of the register set for the USB subsystem on
>> @@ -21,7 +21,7 @@ SoCs only:
>>  - clock-names:		Must be "usb".
>>  
>>  
>> -The following are mandatory properties for Keystone 2 66AK2G SoCs only:
>> +The following are mandatory properties for 66AK2G and AM654:
>>  
>>  - power-domains:	Should contain a phandle to a PM domain provider node
>>  			and an args specifier containing the USB device id
>>
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/usb/keystone-usb.txt b/Documentation/devicetree/bindings/usb/keystone-usb.txt
index f96e09f..fa29ff8 100644
--- a/Documentation/devicetree/bindings/usb/keystone-usb.txt
+++ b/Documentation/devicetree/bindings/usb/keystone-usb.txt
@@ -3,7 +3,7 @@  TI Keystone Soc USB Controller
 DWC3 GLUE
 
 Required properties:
- - compatible: should be "ti,keystone-dwc3".
+ - compatible: should be "ti,keystone-dwc3" or "ti,am654-dwc3".
  - #address-cells, #size-cells : should be '1' if the device has sub-nodes
    with 'reg' property.
  - reg : Address and length of the register set for the USB subsystem on
@@ -21,7 +21,7 @@  SoCs only:
 - clock-names:		Must be "usb".
 
 
-The following are mandatory properties for Keystone 2 66AK2G SoCs only:
+The following are mandatory properties for 66AK2G and AM654:
 
 - power-domains:	Should contain a phandle to a PM domain provider node
 			and an args specifier containing the USB device id