From patchwork Sat Mar 14 10:57:00 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 12098 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n2EAvGt5003150 for ; Sat, 14 Mar 2009 10:57:16 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751867AbZCNK5O (ORCPT ); Sat, 14 Mar 2009 06:57:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752313AbZCNK5O (ORCPT ); Sat, 14 Mar 2009 06:57:14 -0400 Received: from ns1.siteground211.com ([209.62.36.12]:42520 "EHLO serv01.siteground211.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751867AbZCNK5N (ORCPT ); Sat, 14 Mar 2009 06:57:13 -0400 Received: from [91.154.126.168] (port=13793 helo=gandalf) by serv01.siteground211.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from ) id 1LiRYE-0008RD-QN; Sat, 14 Mar 2009 05:57:11 -0500 Date: Sat, 14 Mar 2009 12:57:00 +0200 From: Felipe Balbi To: David Brownell Cc: OMAP Subject: Re: [patch 2.6.29-rc8-omap] twl4030 power scripts, initsection fixups Message-ID: <20090314105659.GA8832@gandalf> Reply-To: me@felipebalbi.com References: <200903131825.52114.david-b@pacbell.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <200903131825.52114.david-b@pacbell.net> User-Agent: Mutt/1.5.19 (2009-01-05) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - serv01.siteground211.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - felipebalbi.com Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Fri, Mar 13, 2009 at 06:25:52PM -0700, David Brownell wrote: > From: David Brownell > > Remove section mismatch warnings from twl4030 power script > declaration ... unfortunately, this use-once data can't live > in initdata sections (or initconst) until some driver stacks > (starting with I2C) have better support for non-hotpluggable > componentry. should you update this with the following ? diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c index d9d1655..1f246e8 100644 --- a/drivers/mfd/twl4030-power.c +++ b/drivers/mfd/twl4030-power.c @@ -66,7 +66,7 @@ static u8 triton_next_free_address = 0x2b; #define KEY_1 0xC0 #define KEY_2 0x0C -static int __init twl4030_write_script_byte(u8 address, u8 byte) +static int twl4030_write_script_byte(u8 address, u8 byte) { int err; @@ -78,7 +78,7 @@ static int __init twl4030_write_script_byte(u8 address, u8 byte) return err; } -static int __init twl4030_write_script_ins(u8 address, u16 pmb_message, +static int twl4030_write_script_ins(u8 address, u16 pmb_message, u8 delay, u8 next) { int err = 0; @@ -92,7 +92,7 @@ static int __init twl4030_write_script_ins(u8 address, u16 pmb_message, return err; } -static int __init twl4030_write_script(u8 address, struct twl4030_ins *script, +static int twl4030_write_script(u8 address, struct twl4030_ins *script, int len) { int err = 0; @@ -113,7 +113,7 @@ static int __init twl4030_write_script(u8 address, struct twl4030_ins *script, return err; } -static int __init config_wakeup3_sequence(u8 address) +static int config_wakeup3_sequence(u8 address) { int err = 0; @@ -131,7 +131,7 @@ static int __init config_wakeup3_sequence(u8 address) return err; } -static int __init config_wakeup12_sequence(u8 address) +static int config_wakeup12_sequence(u8 address) { int err = 0; @@ -162,7 +162,7 @@ static int __init config_wakeup12_sequence(u8 address) return err; } -static int __init config_sleep_sequence(u8 address) +static int config_sleep_sequence(u8 address) { int err = 0; @@ -184,7 +184,7 @@ static int __init config_sleep_sequence(u8 address) return err; } -static int __init config_warmreset_sequence(u8 address) +static int config_warmreset_sequence(u8 address) { int err = 0; @@ -219,7 +219,7 @@ static int __init config_warmreset_sequence(u8 address) return err; } -static int __init load_triton_script(struct twl4030_script *tscript) +static int load_triton_script(struct twl4030_script *tscript) { u8 address = triton_next_free_address; int err; @@ -245,7 +245,7 @@ static int __init load_triton_script(struct twl4030_script *tscript) return err; } -void __init twl4030_power_init(struct twl4030_power_data *triton2_scripts) +void twl4030_power_init(struct twl4030_power_data *triton2_scripts) { int err = 0; int i;