From patchwork Wed Jul 1 11:38:53 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 33456 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n61BcTDu025671 for ; Wed, 1 Jul 2009 11:39:02 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751583AbZGALi5 (ORCPT ); Wed, 1 Jul 2009 07:38:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752450AbZGALi5 (ORCPT ); Wed, 1 Jul 2009 07:38:57 -0400 Received: from mail-fx0-f218.google.com ([209.85.220.218]:39034 "EHLO mail-fx0-f218.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751583AbZGALi4 (ORCPT ); Wed, 1 Jul 2009 07:38:56 -0400 Received: by fxm18 with SMTP id 18so732681fxm.37 for ; Wed, 01 Jul 2009 04:38:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:date:from:to:cc :subject:message-id:mail-followup-to:references:mime-version :content-type:content-disposition:in-reply-to:x-url:user-agent; bh=p59yDGUuaqp37hOY6b3S+p1RgYXZ4AtHgQG4oeFjcLU=; b=PNuYKxiIBssYupmjmlK3TxRS4wuEEBhYCBlUmVRIXhloRiCalUerTEKWtJ21XWOa/n CCojDXOv/a6JyqVM6+gLgqcydTQRS989SS5v8elqLcEowuLi1VxNtqqWmjEesg//c6/Q AufkGP1ECydJcWnOh5Is+7P8cDMo32cuCUoBY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-type:content-disposition :in-reply-to:x-url:user-agent; b=jARWb3l/DTpXZJlBGIiC34ljsiDoHkd/7xdt3QvfKkr/W5QqU05J5H+6qlR3MujJxB KupBzvuQ/8DHs0JiVCGCVHYuh/mlPfWkoDm44lUTyBH0BrKsoeBCNS3rgu4xVLC6HRBj FDEsVAnUoBH/kaA08FdyLnugEqq6pIZSXY1O8= Received: by 10.204.76.199 with SMTP id d7mr6048034bkk.84.1246448338997; Wed, 01 Jul 2009 04:38:58 -0700 (PDT) Received: from localhost (a91-154-121-48.elisa-laajakaista.fi [91.154.121.48]) by mx.google.com with ESMTPS id 22sm1781535fkr.30.2009.07.01.04.38.57 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 01 Jul 2009 04:38:57 -0700 (PDT) Date: Wed, 1 Jul 2009 14:38:53 +0300 From: Kucheria Amit To: Roger Quadros Cc: "linux-omap@vger.kernel.org" Subject: Re: OMAP3: RX51: build warning at rx51_t2scripts Message-ID: <20090701113853.GJ9645@everest> Mail-Followup-To: Roger Quadros , "linux-omap@vger.kernel.org" References: <4A4B1821.20604@nokia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4A4B1821.20604@nokia.com> X-URL: http://www.verdurent.com/ User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On 09 Jul 01, Roger Quadros wrote: > Hi Amit, > > I get the following warning while building Kevin's PM branch for RX-51. > The kernel boots to shell though. > I'm not sure whether it's harmless or not. > > > MODPOST vmlinux.o > WARNING: vmlinux.o(.data+0xb328): Section mismatch in reference from > the variable rx51_t2scripts_data to the (unknown reference) > .init.data:(unknown) > The variable rx51_t2scripts_data references > the (unknown reference) __initdata (unknown) > If the reference is valid then annotate the > variable with __init* (see linux/init.h) or name the variable: > *driver, *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console, Attached patch should fix this problem. Compile-tested only. I've already applied this to the code that I am pushing upstream. So this should be dropped eventually. From 49c93de6ccfd48eed0064cdec17ad77d9842d624 Mon Sep 17 00:00:00 2001 From: Amit Kucheria Date: Wed, 1 Jul 2009 14:32:28 +0300 Subject: [PATCH 195/195] TWL4030: RX51: Mark board data as __initdata Mark rx51 board data as __initdata so that compiling with CONFIG_DEBUG_SECTION_MISMATCH=y will not throw warnings. Signed-off-by: Amit Kucheria --- arch/arm/mach-omap2/board-rx51-peripherals.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c index 43d081b..f7ebec8 100644 --- a/arch/arm/mach-omap2/board-rx51-peripherals.c +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c @@ -367,7 +367,7 @@ static struct twl4030_script *twl4030_scripts[] __initdata = { &wrst_script, }; -static struct twl4030_resconfig twl4030_rconfig[] = { +static struct twl4030_resconfig twl4030_rconfig[] __initdata = { { .resource = RES_VINTANA1, .devgroup = -1, .type = -1, .type2 = 1 }, { .resource = RES_VINTANA2, .devgroup = -1, .type = -1, .type2 = 1 }, { .resource = RES_VINTDIG, .devgroup = -1, .type = -1, .type2 = 1 }, @@ -387,7 +387,7 @@ static struct twl4030_resconfig twl4030_rconfig[] = { { 0, 0}, }; -static struct twl4030_power_data rx51_t2scripts_data = { +static struct twl4030_power_data rx51_t2scripts_data __initdata = { .scripts = twl4030_scripts, .size = ARRAY_SIZE(twl4030_scripts), .resource_config = twl4030_rconfig, @@ -395,7 +395,7 @@ static struct twl4030_power_data rx51_t2scripts_data = { -static struct twl4030_platform_data rx51_twldata = { +static struct twl4030_platform_data rx51_twldata __initdata = { .irq_base = TWL4030_IRQ_BASE, .irq_end = TWL4030_IRQ_END, -- 1.6.3.3