From patchwork Thu Dec 2 18:46:17 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tony Lindgren X-Patchwork-Id: 375531 X-Patchwork-Delegate: tony@atomide.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id oB2IkZFd027583 for ; Thu, 2 Dec 2010 18:46:36 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757889Ab0LBSq0 (ORCPT ); Thu, 2 Dec 2010 13:46:26 -0500 Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:48181 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757751Ab0LBSq0 (ORCPT ); Thu, 2 Dec 2010 13:46:26 -0500 Received: from c-24-130-172-179.hsd1.ca.comcast.net ([24.130.172.179] helo=localhost.localdomain) by mho-02-ewr.mailhop.org with esmtpa (Exim 4.68) (envelope-from ) id 1POEAj-000BXG-I7; Thu, 02 Dec 2010 18:46:25 +0000 Received: from Mutt by mutt-smtp-wrapper.pl 1.2 (www.zdo.com/articles/mutt-smtp-wrapper.shtml) X-Mail-Handler: MailHop Outbound by DynDNS X-Originating-IP: 24.130.172.179 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/mailhop/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX19YkzPvOtA9iJNADE0pnvQr Date: Thu, 2 Dec 2010 10:46:17 -0800 From: Tony Lindgren To: "G, Manjunath Kondaiah" Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Kevin Hilman , Santosh Shilimkar , Benoit Cousson Subject: Re: [PATCH v5 09/14] OMAP: DMA: Convert DMA library into platform driver Message-ID: <20101202184617.GS17222@atomide.com> References: <1290603110-14119-1-git-send-email-manjugk@ti.com> <1290603110-14119-10-git-send-email-manjugk@ti.com> <20101202184419.GR17222@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20101202184419.GR17222@atomide.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Thu, 02 Dec 2010 18:46:36 +0000 (UTC) --- a/arch/arm/mach-omap1/dma.c +++ b/arch/arm/mach-omap1/dma.c @@ -280,6 +280,12 @@ static int __init omap1_system_dma_init(void) return -ENOMEM; } + dma_base = ioremap(res[0].start, resource_size(&res[0])); + if (!dma_base) { + pr_err("%s: Unable to ioremap\n", __func__); + return -ENODEV; + } + ret = platform_device_add_resources(pdev, res, ARRAY_SIZE(res)); if (ret) { dev_err(&pdev->dev, "%s: Unable to add resources for %s%d\n", @@ -337,8 +343,6 @@ static int __init omap1_system_dma_init(void) p->dma_attr = d; - dma_base = (void __iomem *)res[0].start; - p->show_dma_caps = omap1_show_dma_caps; p->clear_lch_regs = omap1_clear_lch_regs; p->clear_dma = omap1_clear_dma;