From patchwork Tue Sep 11 00:17:10 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tony Lindgren X-Patchwork-Id: 1434071 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 36BB8DF28C for ; Tue, 11 Sep 2012 00:17:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751981Ab2IKARR (ORCPT ); Mon, 10 Sep 2012 20:17:17 -0400 Received: from mho-04-ewr.mailhop.org ([204.13.248.74]:49766 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750886Ab2IKARQ (ORCPT ); Mon, 10 Sep 2012 20:17:16 -0400 Received: from c-98-234-237-12.hsd1.ca.comcast.net ([98.234.237.12] helo=localhost.localdomain) by mho-02-ewr.mailhop.org with esmtpa (Exim 4.72) (envelope-from ) id 1TBEAD-00012w-5l; Tue, 11 Sep 2012 00:17:13 +0000 Received: from Mutt by mutt-smtp-wrapper.pl 1.2 (www.zdo.com/articles/mutt-smtp-wrapper.shtml) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 98.234.237.12 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX19h2ip+pv7bgpCoDwru3e0N Date: Mon, 10 Sep 2012 17:17:10 -0700 From: Tony Lindgren To: Artem Bityutskiy Cc: Afzal Mohammed , artem.bityutskiy@linux.intel.com, linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org, ivan.djelic@parrot.com Subject: Re: [PATCH v3 10/10] mtd: nand: omap2: use gpmc provided irqs Message-ID: <20120911001710.GD1303@atomide.com> References: <1345895326.1815.4.camel@kyv> <20120830195349.GW1303@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120830195349.GW1303@atomide.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Tony Lindgren [120830 12:54]: > * Artem Bityutskiy [120825 04:49]: > > On Tue, 2012-08-21 at 15:14 +0530, Afzal Mohammed wrote: > > > GPMC platform initialization provides it's clients > > > with interrupts that can be used through struct > > > resource. Make use of it for irq mode functionality. > > > > > > Also now write protect disable is done by GPMC, > > > hence remove it. > > > > > > Signed-off-by: Afzal Mohammed > > > > Acked-by: Artem Bityutskiy > > Thanks I'll apply these into omap devel-gpmc branch. FYI, looks like a new warning got introduced, so I've committed the following trivial patch on top of this series. Regards, Tony From: Tony Lindgren Date: Mon, 10 Sep 2012 17:14:13 -0700 Subject: [PATCH] mtd: nand omap2: Fix uninitialized err warning Commit bd4156fd (mtd: nand: omap2: use gpmc provided irqs) introduced a new warning: drivers/mtd/nand/omap2.c: In function ‘omap_nand_probe’: drivers/mtd/nand/omap2.c:1267: warning: ‘err’ may be used uninitialized in this function Signed-off-by: Tony Lindgren --- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/mtd/nand/omap2.c +++ b/drivers/mtd/nand/omap2.c @@ -1389,6 +1389,7 @@ static int __devinit omap_nand_probe(struct platform_device *pdev) info->gpmc_irq_fifo = platform_get_irq(pdev, 0); if (info->gpmc_irq_fifo <= 0) { dev_err(&pdev->dev, "error getting fifo irq\n"); + err = -ENODEV; goto out_release_mem_region; } err = request_irq(info->gpmc_irq_fifo, omap_nand_irq,