From patchwork Thu Oct 25 17:56:07 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nishanth Menon X-Patchwork-Id: 1646231 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id DE9433FE1C for ; Thu, 25 Oct 2012 17:56:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2992496Ab2JYR4S (ORCPT ); Thu, 25 Oct 2012 13:56:18 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:36619 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2992485Ab2JYR4R (ORCPT ); Thu, 25 Oct 2012 13:56:17 -0400 Received: from dlelxv30.itg.ti.com ([172.17.2.17]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id q9PHu7Ti030807; Thu, 25 Oct 2012 12:56:07 -0500 Received: from DLEE74.ent.ti.com (dlee74.ent.ti.com [157.170.170.8]) by dlelxv30.itg.ti.com (8.13.8/8.13.8) with ESMTP id q9PHu7HP023990; Thu, 25 Oct 2012 12:56:07 -0500 Received: from dlelxv22.itg.ti.com (172.17.1.197) by DLEE74.ent.ti.com (157.170.170.8) with Microsoft SMTP Server id 14.1.323.3; Thu, 25 Oct 2012 12:56:07 -0500 Received: from localhost (kahuna.am.dhcp.ti.com [128.247.75.12]) by dlelxv22.itg.ti.com (8.13.8/8.13.8) with ESMTP id q9PHu7Ta010221; Thu, 25 Oct 2012 12:56:07 -0500 Date: Thu, 25 Oct 2012 12:56:07 -0500 From: Nishanth Menon To: Kevin Hilman CC: Tony Lindgren , Russell King , , Subject: Re: [PATCH] ARM: OMAP2+: PM: add missing newline to VC warning message Message-ID: <20121025175607.GA21937@kahuna> References: <1351186501-32223-1-git-send-email-khilman@deeprootsystems.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1351186501-32223-1-git-send-email-khilman@deeprootsystems.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On 10:35-20121025, Kevin Hilman wrote: > From: Kevin Hilman > > Add missing newline to warning message to avoid annoying > wrapping problems during kernel boot like this one: > > omap_vc_i2c_init: I2C config for vdd_iva does not match other channels (0). > omap_vc_i2c_init: I2C config for vdd_mpu does not match other channels (0).Power Management for TI OMAP4. > > Reported-by: Russell King > Signed-off-by: Kevin Hilman > --- > arch/arm/mach-omap2/vc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/vc.c b/arch/arm/mach-omap2/vc.c > index 880249b..75878c3 100644 > --- a/arch/arm/mach-omap2/vc.c > +++ b/arch/arm/mach-omap2/vc.c > @@ -264,7 +264,7 @@ static void __init omap_vc_i2c_init(struct voltagedomain *voltdm) > > if (initialized) { > if (voltdm->pmic->i2c_high_speed != i2c_high_speed) > - pr_warn("%s: I2C config for vdd_%s does not match other channels (%u).", > + pr_warn("%s: I2C config for vdd_%s does not match other channels (%u).\n", > __func__, voltdm->name, i2c_high_speed); > return; > } Acked-by: Nishanth Menon while we are at it, could we clean up the pr_warning usage back to pr_warn as well? diff --git a/arch/arm/mach-omap2/vc.c b/arch/arm/mach-omap2/vc.c index 880249b..2d66f8c 100644 --- a/arch/arm/mach-omap2/vc.c +++ b/arch/arm/mach-omap2/vc.c @@ -186,7 +186,7 @@ int omap_vc_bypass_scale(struct voltagedomain *voltdm, loop_cnt++; if (retries_cnt > 10) { - pr_warning("%s: Retry count exceeded\n", __func__); + pr_warn("%s: Retry count exceeded\n", __func__); return -ETIMEDOUT; }