diff mbox

[1/2] omap2430: fix wrong devm_kzalloc() result check

Message ID 201301082211.14413.sshtylyov@ru.mvista.com (mailing list archive)
State New, archived
Headers show

Commit Message

Sergei Shtylyov Jan. 8, 2013, 7:11 p.m. UTC
Commit 00a0b1d58af873d842580dcac55f3b156c3a4077 (usb: musb: omap: Add device
tree support for omap musb glue) assigns result of devm_kzalloc() call to
the 'config' variable but then checks for NULL the 'data' variable (already
checked after previous call). Thus we risk a kernel oops further when data
pointed by 'config' is written to by subsequent of_property_read_u32() calls
iff the allocation happens to fail...

Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

This patch is atop of 'musb' branch of Felipe's tree but can also be applied to
the 'fixes' branch.

 drivers/usb/musb/omap2430.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox


Index: usb/drivers/usb/musb/omap2430.c
--- usb.orig/drivers/usb/musb/omap2430.c
+++ usb/drivers/usb/musb/omap2430.c
@@ -545,7 +545,7 @@  static int __devinit omap2430_probe(stru
 		config = devm_kzalloc(&pdev->dev, sizeof(*config), GFP_KERNEL);
-		if (!data) {
+		if (!config) {
 				"failed to allocate musb hdrc config\n");
 			goto err2;