From patchwork Tue Feb 5 17:51:26 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tony Lindgren X-Patchwork-Id: 2098521 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 08E5B3FDF1 for ; Tue, 5 Feb 2013 17:51:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755023Ab3BERvd (ORCPT ); Tue, 5 Feb 2013 12:51:33 -0500 Received: from mho-04-ewr.mailhop.org ([204.13.248.74]:34473 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754018Ab3BERvd (ORCPT ); Tue, 5 Feb 2013 12:51:33 -0500 Received: from c-50-131-214-131.hsd1.ca.comcast.net ([50.131.214.131] helo=localhost.localdomain) by mho-02-ewr.mailhop.org with esmtpa (Exim 4.72) (envelope-from ) id 1U2mg5-000Bvx-Gy; Tue, 05 Feb 2013 17:51:29 +0000 Received: from Mutt by mutt-smtp-wrapper.pl 1.2 (www.zdo.com/articles/mutt-smtp-wrapper.shtml) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 50.131.214.131 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1+xQI3UyqowFLAJ0ETrEMA9 Date: Tue, 5 Feb 2013 09:51:26 -0800 From: Tony Lindgren To: Arnd Bergmann , Olof Johansson Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, arm@kernel.org, Russell King - ARM Linux Subject: Re: Latest additional build warnings Message-ID: <20130205175126.GH25185@atomide.com> References: <20130205142218.GB17833@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130205142218.GB17833@n2100.arm.linux.org.uk> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Russell King - ARM Linux [130205 06:25]: > arch/arm/mach-omap2/hwspinlock.c:60:1: warning: data definition has no type or storage class > arch/arm/mach-omap2/hwspinlock.c:60:1: warning: type defaults to 'int' in declaration of 'omap_postcore_initcall' > arch/arm/mach-omap2/hwspinlock.c:60:1: warning: parameter names (without types) in function declaration > arch/arm/mach-omap2/hwspinlock.c:31:122: warning: 'hwspinlocks_init' defined but not used Thanks looks like I missed that one somehow. Here's a fix for it. Arnd & Olof, care to apply this directly into the arm-soc multiplatform branch? Regards, Tony From: Tony Lindgren Date: Tue, 5 Feb 2013 09:48:08 -0800 Subject: [PATCH] ARM: OMAP2+: Fix warning for hwspinlock omap_postcore_initcall Commit 816a65ef4 (ARM: OMAP2+: Limit omap initcalls to omap only on multiplatform kernels) fixed up things for multiplatform booting but failed to include soc.h causing a new warning: arch/arm/mach-omap2/hwspinlock.c:60:1: warning: data definition has no type or storage class arch/arm/mach-omap2/hwspinlock.c:60:1: warning: type defaults to 'int' in declaration of 'omap_postcore_initcall' arch/arm/mach-omap2/hwspinlock.c:60:1: warning: parameter names (without types) in function declaration arch/arm/mach-omap2/hwspinlock.c:31:122: warning: 'hwspinlocks_init' defined but not used Reported-by: Signed-off-by: Russell King Signed-off-by: Tony Lindgren --- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/mach-omap2/hwspinlock.c b/arch/arm/mach-omap2/hwspinlock.c index ce1b5b6..bcb357e 100644 --- a/arch/arm/mach-omap2/hwspinlock.c +++ b/arch/arm/mach-omap2/hwspinlock.c @@ -21,6 +21,7 @@ #include #include +#include "soc.h" #include "omap_hwmod.h" #include "omap_device.h"