From patchwork Wed Mar 6 09:19:43 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 2224091 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 16889DF23A for ; Wed, 6 Mar 2013 09:20:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752444Ab3CFJUU (ORCPT ); Wed, 6 Mar 2013 04:20:20 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:43885 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750812Ab3CFJUR (ORCPT ); Wed, 6 Mar 2013 04:20:17 -0500 Received: from dlelxv30.itg.ti.com ([172.17.2.17]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id r269K0u7002360; Wed, 6 Mar 2013 03:20:00 -0600 Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dlelxv30.itg.ti.com (8.13.8/8.13.8) with ESMTP id r269JxpO011683; Wed, 6 Mar 2013 03:19:59 -0600 Received: from dlelxv22.itg.ti.com (172.17.1.197) by dfle72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.1.323.3; Wed, 6 Mar 2013 03:19:59 -0600 Received: from localhost (h78-4.vpn.ti.com [172.24.78.4]) by dlelxv22.itg.ti.com (8.13.8/8.13.8) with ESMTP id r269Jw9c015348; Wed, 6 Mar 2013 03:19:59 -0600 Date: Wed, 6 Mar 2013 11:19:43 +0200 From: Felipe Balbi To: kishon CC: , , , , , , , , , , , , Subject: Re: [PATCH v2 8/8] ARM: dts: omap5: add dwc3 core dt data Message-ID: <20130306091942.GJ28587@arwen.pp.htv.fi> Reply-To: References: <1362494223-14151-1-git-send-email-kishon@ti.com> <1362494223-14151-9-git-send-email-kishon@ti.com> <20130305143934.GB12123@arwen.pp.htv.fi> <51370494.7090902@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <51370494.7090902@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi, On Wed, Mar 06, 2013 at 02:25:48PM +0530, kishon wrote: > Hi, > > On Tuesday 05 March 2013 08:09 PM, Felipe Balbi wrote: > >Hi, > > > >On Tue, Mar 05, 2013 at 08:07:03PM +0530, Kishon Vijay Abraham I wrote: > >>Add dwc3 core dt data as a subnode to dwc3 omap glue data in omap5 dt > >>data file. The information for the entered data node is available @ > >>Documentation/devicetree/bindings/usb/dwc3.txt > >> > >>Signed-off-by: Kishon Vijay Abraham I > >>--- > >> arch/arm/boot/dts/omap5.dtsi | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >>diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi > >>index c4eb2ec..24dd69f 100644 > >>--- a/arch/arm/boot/dts/omap5.dtsi > >>+++ b/arch/arm/boot/dts/omap5.dtsi > >>@@ -514,6 +514,13 @@ > >> #size-cells = <1>; > >> utmi-mode = <2>; > >> ranges; > >>+ dwc3@4a030000 { > >>+ compatible = "synopsys,dwc3"; > >>+ reg = <0x4a030000 0x1000>; > >>+ interrupts = <0 92 4>; > >>+ usb-phy = <&usb2_phy>, <&usb3_phy>; > >>+ tx-fifo-resize; > > > >I think this should be merged with previous patch. Also, we need to > >check whether tx-fifo-resize is needed with ES2 or not ;-) > > yeah. ES2 works without tx-fifo-resize. Great, I guess we can deprecate that attribute. Can you check if ES2 still works with: starting on 1.94a (IIRC) core was supposed to control PHYs directly and since there's nobody in linux mainline using any version prior to 1.94a, we could drop that too. diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 82e160e..cad0131 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -2029,6 +2029,8 @@ static void dwc3_gadget_usb3_phy_suspend(struct dwc3 *dwc, int suspend) { u32 reg; + return; + reg = dwc3_readl(dwc->regs, DWC3_GUSB3PIPECTL(0)); if (suspend) @@ -2043,6 +2045,8 @@ static void dwc3_gadget_usb2_phy_suspend(struct dwc3 *dwc, int suspend) { u32 reg; + return; + reg = dwc3_readl(dwc->regs, DWC3_GUSB2PHYCFG(0)); if (suspend)