From patchwork Sun Jul 7 20:13:10 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ezequiel Garcia X-Patchwork-Id: 2824632 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D56F8C0AB2 for ; Sun, 7 Jul 2013 20:13:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0630A20121 for ; Sun, 7 Jul 2013 20:13:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A4FF20122 for ; Sun, 7 Jul 2013 20:13:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753141Ab3GGUNI (ORCPT ); Sun, 7 Jul 2013 16:13:08 -0400 Received: from mail.free-electrons.com ([94.23.35.102]:56534 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753096Ab3GGUNH (ORCPT ); Sun, 7 Jul 2013 16:13:07 -0400 Received: by mail.free-electrons.com (Postfix, from userid 106) id 39D667AF; Sun, 7 Jul 2013 22:13:04 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from localhost (unknown [190.2.109.25]) by mail.free-electrons.com (Postfix) with ESMTPSA id BADE95C9; Sun, 7 Jul 2013 22:13:01 +0200 (CEST) Date: Sun, 7 Jul 2013 17:13:10 -0300 From: Ezequiel Garcia To: Balaji T K Cc: a-bindra@ti.com, linux-mmc@vger.kernel.org, cjb@laptop.org, linux-omap@vger.kernel.org, balbi@ti.com, nm@ti.com Subject: Re: [PATCH] mmc: omap_hsmmc: use for OMAP5 as well Message-ID: <20130707201309.GA5429@localhost> References: <1372422894-23729-1-git-send-email-a-bindra@ti.com> <51CDB260.8080108@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <51CDB260.8080108@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi guys, On Fri, Jun 28, 2013 at 09:27:20PM +0530, Balaji T K wrote: > On Friday 28 June 2013 06:04 PM, a-bindra@ti.com wrote: > > From: Amarinder Bindra > > > > OMAP's hs_mmc driver is also used for OMAP5 MMC controller operation. > > Considering that the device tree entries are already there for this, > > allow the driver to be built when only OMAP5 is enabled. > > This allows MMC root filesystems to be available in "OMAP5 only" > > configurations. > > > > Signed-off-by: Amarinder Bindra > > Acked-by: Felipe Balbi > > Acked-by: Nishanth Menon > > Looks good to me, > Acked-by: Balaji T K > I came across this same issue while trying MMC patches on AM3xx, which is nor OMAP3 neither OMAP4. Now, looking at the driver I don't see any OMAP-specific bits (welcome to the multiplatform world ;-) so I think we can just remove the 'depends' line. Something like this: diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig index 9ab8f8d..bade7f2 100644 --- a/drivers/mmc/host/Kconfig +++ b/drivers/mmc/host/Kconfig @@ -273,10 +273,9 @@ config MMC_OMAP config MMC_OMAP_HS tristate "TI OMAP High Speed Multimedia Card Interface support" - depends on SOC_OMAP2430 || ARCH_OMAP3 || ARCH_OMAP4 help This selects the TI OMAP High Speed Multimedia card Interface. - If you have an OMAP2430 or OMAP3 board or OMAP4 board with a + If you have an OMAP2430, OMAP3, OMAP4 or AM3xx board with a Multimedia Card slot, say Y or M here. If unsure, say N.