From patchwork Mon Sep 16 21:38:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tony Lindgren X-Patchwork-Id: 2899591 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D84A8BFF05 for ; Mon, 16 Sep 2013 21:38:32 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 07E00201DA for ; Mon, 16 Sep 2013 21:38:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A226201D6 for ; Mon, 16 Sep 2013 21:38:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751436Ab3IPViZ (ORCPT ); Mon, 16 Sep 2013 17:38:25 -0400 Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:64033 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750968Ab3IPViX (ORCPT ); Mon, 16 Sep 2013 17:38:23 -0400 Received: from c-50-131-214-131.hsd1.ca.comcast.net ([50.131.214.131] helo=localhost.localdomain) by mho-02-ewr.mailhop.org with esmtpa (Exim 4.72) (envelope-from ) id 1VLgUv-000P9H-O4; Mon, 16 Sep 2013 21:38:22 +0000 Received: from Mutt by mutt-smtp-wrapper.pl 1.2 (www.zdo.com/articles/mutt-smtp-wrapper.shtml) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 50.131.214.131 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX18evJ3hMnD4ynsLFuk1r30v Date: Mon, 16 Sep 2013 14:38:18 -0700 From: Tony Lindgren To: Olof Johansson Cc: "linux-arm-kernel@lists.infradead.org" , linux-omap Subject: Re: [PATCH 0/2] WLAN regression fixes for omap4 after moving to DT based booting Message-ID: <20130916213817.GA5388@atomide.com> References: <20130913190811.24617.97699.stgit@localhost> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP * Olof Johansson [130913 22:17]: > Hi, > > Not related to wlan but with DT conversion; I noticed the following in > dmesg on Panda ES with omap2plus_defconfig on current mainline: > > [ 0.000000] smp_twd: clock not found -2 That should get fixed for v3.13 when we get the proper DT clocks for omap. Currently twd_get_clock() currently does: if (np) twd_clk = of_clk_get(np, 0); else twd_clk = clk_get_sys("smp_twd", NULL); So if fails in the np case right now. I'd probably wait for v3.13 on this one to avoid adding temporary timer workarounds to twd_get_clock() or stuffing the clock for the timer by using of_clk_add_provider(). If people feel strongly that we should fix it for v3.12, then let me know. Things do work without it, of course the local timer is not being used though. > and: > > [ 0.440399] omap-gpmc 50000000.gpmc: error: clk_get Thanks that's an easy one. I'll queue the following fix. Regards, Tony From: Tony Lindgren Date: Mon, 16 Sep 2013 14:22:31 -0700 Subject: [PATCH] ARM: OMAP4: Fix clock_get error for GPMC during boot Looks like we still have the legacy clock alias name for omap4 GPMC (General Purpose Memory Controller), so let's fix it for the device tree naming. There's no need to keep the legacy naming as omap4 is DT only nowadays. Without this fix we get the following error while booting: [ 0.440399] omap-gpmc 50000000.gpmc: error: clk_get Reported-by: Olof Johansson Signed-off-by: Tony Lindgren --- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/arch/arm/mach-omap2/cclock44xx_data.c +++ b/arch/arm/mach-omap2/cclock44xx_data.c @@ -1632,7 +1632,7 @@ static struct omap_clk omap44xx_clks[] = { CLK(NULL, "auxclk5_src_ck", &auxclk5_src_ck), CLK(NULL, "auxclk5_ck", &auxclk5_ck), CLK(NULL, "auxclkreq5_ck", &auxclkreq5_ck), - CLK("omap-gpmc", "fck", &dummy_ck), + CLK("50000000.gpmc", "fck", &dummy_ck), CLK("omap_i2c.1", "ick", &dummy_ck), CLK("omap_i2c.2", "ick", &dummy_ck), CLK("omap_i2c.3", "ick", &dummy_ck),