From patchwork Mon Sep 22 18:49:09 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 4949841 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 71AE89F2BB for ; Mon, 22 Sep 2014 18:49:16 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8DDF320253 for ; Mon, 22 Sep 2014 18:49:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 872B720221 for ; Mon, 22 Sep 2014 18:49:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752520AbaIVStN (ORCPT ); Mon, 22 Sep 2014 14:49:13 -0400 Received: from mail-pd0-f169.google.com ([209.85.192.169]:63969 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753524AbaIVStN (ORCPT ); Mon, 22 Sep 2014 14:49:13 -0400 Received: by mail-pd0-f169.google.com with SMTP id fp1so871461pdb.0 for ; Mon, 22 Sep 2014 11:49:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=vMGVXekqUuWMJml13d+xSKk1Tw018JhXHOCtQ4BmW7Q=; b=eaOjTQYdHAXUtEknZuQCc1pAEjpA2W1TCUdOuMcIZCa/VgAygPS6fHjGIyf6XhDX9f lUhwwwby3Cm13prYrftKJISR2KPq5Jx7TT9Y+T643AWmL4G11SWXj59Tf0NR/KMN3Jk7 VmBcFaUv+r/2K41JLN2onZqjbR3v/+vP4EgzNPWVBgxmzEiygSJGaEK8K81Cg7B/ZW+B DCw1MzAfgRNsJYbuLzlyug2/lLgz6VRuO423jozHf8zSn3V7zVReq0EkneAGG52APGB9 NKZ4WNFoor46U+RkDwyHaDHaPtmN1M6UpneDwt8oVpzM0f7w+fYv81pVkdGOsWwCNzNS LFkw== X-Received: by 10.68.162.3 with SMTP id xw3mr6825442pbb.142.1411411752418; Mon, 22 Sep 2014 11:49:12 -0700 (PDT) Received: from ld-irv-0074 (5520-maca-inet1-outside.broadcom.com. [216.31.211.11]) by mx.google.com with ESMTPSA id sb2sm4594638pbc.24.2014.09.22.11.49.11 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 22 Sep 2014 11:49:11 -0700 (PDT) Date: Mon, 22 Sep 2014 11:49:09 -0700 From: Brian Norris To: Ezequiel Garcia Cc: Roger Quadros , linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org, Tony Lindgren Subject: Re: [PATCH v4 4/5] mtd: nand: Rename OMAP NAND driver Message-ID: <20140922184909.GS1193@ld-irv-0074> References: <1411231996-6387-1-git-send-email-ezequiel@vanguardiasur.com.ar> <1411231996-6387-5-git-send-email-ezequiel@vanguardiasur.com.ar> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1411231996-6387-5-git-send-email-ezequiel@vanguardiasur.com.ar> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Sat, Sep 20, 2014 at 05:53:15PM +0100, Ezequiel Garcia wrote: > Rename it to a less generic name, so the module is built with a meaningful > name instead of the previous 'omap2.ko'. You mention renaming only so that you can change the module name, but you also (partly at my prompting) argued for future merging of omap_nand and omap_elm into a single module. So it seems like you might have to do several renamings, in that case, right? omap2.c => omap_nand.c (this patch) omap_nand.c => .c (later) ...so you can link somethingelse.o and omap_elm.o into omap_nand.{o,ko} If I'm right here, then maybe (rather than multiple renames), you just want this patch for now? (untested) > Acked-by: Roger Quadros > Signed-off-by: Ezequiel Garcia > --- > drivers/mtd/nand/Makefile | 2 +- > drivers/mtd/nand/{omap2.c => omap2_nand.c} | 0 > 2 files changed, 1 insertion(+), 1 deletion(-) > rename drivers/mtd/nand/{omap2.c => omap2_nand.c} (100%) [snip] Brian --- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile index b3237b742eb5..1a4d5e9db75b 100644 --- a/drivers/mtd/nand/Makefile +++ b/drivers/mtd/nand/Makefile @@ -26,7 +26,7 @@ obj-$(CONFIG_MTD_NAND_CS553X) += cs553x_nand.o obj-$(CONFIG_MTD_NAND_NDFC) += ndfc.o obj-$(CONFIG_MTD_NAND_ATMEL) += atmel_nand.o obj-$(CONFIG_MTD_NAND_GPIO) += gpio.o -obj-$(CONFIG_MTD_NAND_OMAP2) += omap2.o +obj-$(CONFIG_MTD_NAND_OMAP2) += omap_nand.o obj-$(CONFIG_MTD_NAND_OMAP_BCH) += omap_elm.o obj-$(CONFIG_MTD_NAND_CM_X270) += cmx270_nand.o obj-$(CONFIG_MTD_NAND_PXA3xx) += pxa3xx_nand.o @@ -52,3 +52,4 @@ obj-$(CONFIG_MTD_NAND_XWAY) += xway_nand.o obj-$(CONFIG_MTD_NAND_BCM47XXNFLASH) += bcm47xxnflash/ nand-objs := nand_base.o nand_bbt.o nand_timings.o +omap_nand-objs := omap2.o