| Message ID | 20141014192518.GH4972@atomide.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Oct 14, 2014 at 12:25:19PM -0700, Tony Lindgren wrote: > This allows testing the watchdog easily with distros just by > doing pkill -9 watchdog. > > Reported-by: Thomas Dziedzic <gostrc@gmail.com> > Signed-off-by: Tony Lindgren <tony@atomide.com> > Good catch. Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- a/drivers/watchdog/omap_wdt.c > +++ b/drivers/watchdog/omap_wdt.c > @@ -189,7 +189,7 @@ static int omap_wdt_set_timeout(struct watchdog_device *wdog, > } > > static const struct watchdog_info omap_wdt_info = { > - .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING, > + .options = WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE | WDIOF_KEEPALIVEPING, > .identity = "OMAP Watchdog", > }; > > --- a/drivers/watchdog/retu_wdt.c > +++ b/drivers/watchdog/retu_wdt.c > @@ -94,7 +94,7 @@ static int retu_wdt_set_timeout(struct watchdog_device *wdog, > } > > static const struct watchdog_info retu_wdt_info = { > - .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING, > + .options = WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE | WDIOF_KEEPALIVEPING, > .identity = "Retu watchdog", > }; > > --- a/drivers/watchdog/twl4030_wdt.c > +++ b/drivers/watchdog/twl4030_wdt.c > @@ -57,7 +57,7 @@ static int twl4030_wdt_set_timeout(struct watchdog_device *wdt, > } > > static const struct watchdog_info twl4030_wdt_info = { > - .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING, > + .options = WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE | WDIOF_KEEPALIVEPING, > .identity = "TWL4030 Watchdog", > }; > > -- > To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Tue, Oct 14, 2014 at 12:25:19PM -0700, Tony Lindgren wrote: > This allows testing the watchdog easily with distros just by > doing pkill -9 watchdog. > > Reported-by: Thomas Dziedzic <gostrc@gmail.com> > Signed-off-by: Tony Lindgren <tony@atomide.com> Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi> A. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Oct 14, 2014 at 12:25:19PM -0700, Tony Lindgren wrote: > This allows testing the watchdog easily with distros just by > doing pkill -9 watchdog. > > Reported-by: Thomas Dziedzic <gostrc@gmail.com> > Signed-off-by: Tony Lindgren <tony@atomide.com> Reviewed-by: Felipe Balbi <balbi@ti.com> > > --- a/drivers/watchdog/omap_wdt.c > +++ b/drivers/watchdog/omap_wdt.c > @@ -189,7 +189,7 @@ static int omap_wdt_set_timeout(struct watchdog_device *wdog, > } > > static const struct watchdog_info omap_wdt_info = { > - .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING, > + .options = WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE | WDIOF_KEEPALIVEPING, > .identity = "OMAP Watchdog", > }; > > --- a/drivers/watchdog/retu_wdt.c > +++ b/drivers/watchdog/retu_wdt.c > @@ -94,7 +94,7 @@ static int retu_wdt_set_timeout(struct watchdog_device *wdog, > } > > static const struct watchdog_info retu_wdt_info = { > - .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING, > + .options = WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE | WDIOF_KEEPALIVEPING, > .identity = "Retu watchdog", > }; > > --- a/drivers/watchdog/twl4030_wdt.c > +++ b/drivers/watchdog/twl4030_wdt.c > @@ -57,7 +57,7 @@ static int twl4030_wdt_set_timeout(struct watchdog_device *wdt, > } > > static const struct watchdog_info twl4030_wdt_info = { > - .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING, > + .options = WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE | WDIOF_KEEPALIVEPING, > .identity = "TWL4030 Watchdog", > }; > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
* Tony Lindgren <tony@atomide.com> [141014 12:27]: > This allows testing the watchdog easily with distros just by > doing pkill -9 watchdog. > > Reported-by: Thomas Dziedzic <gostrc@gmail.com> > Signed-off-by: Tony Lindgren <tony@atomide.com> Wim, still not seeing this applied, did you forget about this one? Regards, Tony > --- a/drivers/watchdog/omap_wdt.c > +++ b/drivers/watchdog/omap_wdt.c > @@ -189,7 +189,7 @@ static int omap_wdt_set_timeout(struct watchdog_device *wdog, > } > > static const struct watchdog_info omap_wdt_info = { > - .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING, > + .options = WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE | WDIOF_KEEPALIVEPING, > .identity = "OMAP Watchdog", > }; > > --- a/drivers/watchdog/retu_wdt.c > +++ b/drivers/watchdog/retu_wdt.c > @@ -94,7 +94,7 @@ static int retu_wdt_set_timeout(struct watchdog_device *wdog, > } > > static const struct watchdog_info retu_wdt_info = { > - .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING, > + .options = WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE | WDIOF_KEEPALIVEPING, > .identity = "Retu watchdog", > }; > > --- a/drivers/watchdog/twl4030_wdt.c > +++ b/drivers/watchdog/twl4030_wdt.c > @@ -57,7 +57,7 @@ static int twl4030_wdt_set_timeout(struct watchdog_device *wdt, > } > > static const struct watchdog_info twl4030_wdt_info = { > - .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING, > + .options = WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE | WDIOF_KEEPALIVEPING, > .identity = "TWL4030 Watchdog", > }; > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* Wim Van Sebroeck <wim@iguana.be> [150202 15:44]: > Hi Tony, > > > * Tony Lindgren <tony@atomide.com> [141014 12:27]: > > > This allows testing the watchdog easily with distros just by > > > doing pkill -9 watchdog. > > > > > > Reported-by: Thomas Dziedzic <gostrc@gmail.com> > > > Signed-off-by: Tony Lindgren <tony@atomide.com> > > > > Wim, still not seeing this applied, did you forget about this one? > > I just applied it to linux-watchdog-next. > Didn't forgot about it, just didn't had the time yet. OK thanks! Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Tony, > * Tony Lindgren <tony@atomide.com> [141014 12:27]: > > This allows testing the watchdog easily with distros just by > > doing pkill -9 watchdog. > > > > Reported-by: Thomas Dziedzic <gostrc@gmail.com> > > Signed-off-by: Tony Lindgren <tony@atomide.com> > > Wim, still not seeing this applied, did you forget about this one? I just applied it to linux-watchdog-next. Didn't forgot about it, just didn't had the time yet. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- a/drivers/watchdog/omap_wdt.c +++ b/drivers/watchdog/omap_wdt.c @@ -189,7 +189,7 @@ static int omap_wdt_set_timeout(struct watchdog_device *wdog, } static const struct watchdog_info omap_wdt_info = { - .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING, + .options = WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE | WDIOF_KEEPALIVEPING, .identity = "OMAP Watchdog", }; --- a/drivers/watchdog/retu_wdt.c +++ b/drivers/watchdog/retu_wdt.c @@ -94,7 +94,7 @@ static int retu_wdt_set_timeout(struct watchdog_device *wdog, } static const struct watchdog_info retu_wdt_info = { - .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING, + .options = WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE | WDIOF_KEEPALIVEPING, .identity = "Retu watchdog", }; --- a/drivers/watchdog/twl4030_wdt.c +++ b/drivers/watchdog/twl4030_wdt.c @@ -57,7 +57,7 @@ static int twl4030_wdt_set_timeout(struct watchdog_device *wdt, } static const struct watchdog_info twl4030_wdt_info = { - .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING, + .options = WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE | WDIOF_KEEPALIVEPING, .identity = "TWL4030 Watchdog", };
This allows testing the watchdog easily with distros just by doing pkill -9 watchdog. Reported-by: Thomas Dziedzic <gostrc@gmail.com> Signed-off-by: Tony Lindgren <tony@atomide.com> -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html