From patchwork Fri Oct 24 19:02:51 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 5149231 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A81B09F349 for ; Fri, 24 Oct 2014 19:06:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B896F2025B for ; Fri, 24 Oct 2014 19:06:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AEF5C2015E for ; Fri, 24 Oct 2014 19:06:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751825AbaJXTFz (ORCPT ); Fri, 24 Oct 2014 15:05:55 -0400 Received: from mail-lb0-f170.google.com ([209.85.217.170]:40011 "EHLO mail-lb0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751344AbaJXTFy (ORCPT ); Fri, 24 Oct 2014 15:05:54 -0400 Received: by mail-lb0-f170.google.com with SMTP id u10so3102140lbd.15 for ; Fri, 24 Oct 2014 12:05:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=pZLebZnpF9ZWqjR0cbR8mim5LSsHe+6QyMparpKwBek=; b=stiqvU6vHE0V+bS5S8HNn8QJnJHwUZkHfGNxG1qz742wlplNk0ZtZwwpyoHFyf095m 6H91VopWaIr4PKF6n+YlquVWNIzY1xjajF3VCN1gE52kzYgUfu8UKwWT0BgL2/S6qTCc uRtD98kO90+uKB6ssayeNx7RLYHDnEk2nBh4BC1skOtSYIvW9CMg+WkB/8nP4uYNhOfk v9ENB/2RjqA3TlnWsJh5mAHBXJpqomDKYegZ3iP16Hq/+Dh9B3VrWaNKzM9VEoylxdal 6N4YP7iEQLg0EPTGqYsVBO3JPf4Mbcl2lLa5bfeW9JhhHhkia45+kMElYcD8Q8x+UpCY 5p6Q== X-Received: by 10.112.172.231 with SMTP id bf7mr4671746lbc.100.1414177552035; Fri, 24 Oct 2014 12:05:52 -0700 (PDT) Received: from xi.terra (s83-177-171-8.cust.tele2.se. [83.177.171.8]) by mx.google.com with ESMTPSA id e3sm2131801lam.26.2014.10.24.12.05.50 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Oct 2014 12:05:51 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.84) (envelope-from ) id 1Xhk8R-0001Ne-Bu; Fri, 24 Oct 2014 21:02:51 +0200 Date: Fri, 24 Oct 2014 21:02:51 +0200 From: Johan Hovold To: Felipe Balbi , Andrew Morton Cc: Johan Hovold , Alessandro Zummo , Tony Lindgren , =?iso-8859-1?Q?Beno=EEt?= Cousson , Lokesh Vutla , Guenter Roeck , nsekhar@ti.com, t-kristo@ti.com, j-keerthy@ti.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Russell King Subject: Re: [PATCH v2 00/20] rtc: omap: fixes and power-off feature Message-ID: <20141024190251.GB19377@localhost> References: <1412881594-25678-1-git-send-email-johan@kernel.org> <1413913086-12730-1-git-send-email-johan@kernel.org> <20141024160845.GM26941@saruman> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20141024160845.GM26941@saruman> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP [ +CC: Russell ] On Fri, Oct 24, 2014 at 11:08:45AM -0500, Felipe Balbi wrote: > I tested this entire series with my BBB and it still works fine. However > I still get below panic. This time without any DRM errors: > > [ 63.087832] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000000 > [ 63.087832] > [ 63.097399] CPU: 0 PID: 1 Comm: systemd-shutdow Not tainted 3.18.0-rc1-00095-g8524e69 #556 > [ 63.106060] [] (unwind_backtrace) from [] (show_stack+0x20/0x24) > [ 63.114160] [] (show_stack) from [] (dump_stack+0x8c/0xa4) > [ 63.121706] [] (dump_stack) from [] (panic+0xa0/0x220) > [ 63.128895] [] (panic) from [] (do_exit+0x974/0x9d0) > [ 63.135900] [] (do_exit) from [] (SyS_reboot+0x14c/0x1e8) > [ 63.143361] [] (SyS_reboot) from [] (ret_fast_syscall+0x0/0x48) > [ 63.151596] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000000 > > Then again, this also happens by simply calling poweroff without > enabling wakealarm. Bah, I forgot to look into that. I haven't seen this myself as I don't use systemd (which does the syscall from process 0). Some driver power-off implementations and some arch machine_power_off spin indefinitely (or use an mdelay and WARN) after trying to power off. I think this is really a bug in arch/arm that should be fixed analogously to how failed reboot is handled in machine_restart(). Care to try the patch below? I should still add a two-second delay to rtc-omap to avoid the arch error message. Andrew, can you update one patch in the series or should I just resend them all (with proper Tested-by tags)? > In any case, for the whole series: > > Tested-by: Felipe Balbi Thanks for testing! Johan >From aaa1d1d6171c895b6966ba5b738ac7946ada97c7 Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Fri, 24 Oct 2014 18:53:09 +0200 Subject: [PATCH] ARM: fix failed power-off handling Make sure to handle failed power off by printing an error message and halting (analogously to how failed reboot is handled). Power off can fail for example if the hardware has not been wired up correctly. This avoids a kernel panic when called from process 0: [ 63.087832] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000000 [ 63.087832] [ 63.097399] CPU: 0 PID: 1 Comm: systemd-shutdow Not tainted 3.18.0-rc1-00095-g8524e69 #556 [ 63.106060] [] (unwind_backtrace) from [] (show_stack+0x20/0x24) [ 63.114160] [] (show_stack) from [] (dump_stack+0x8c/0xa4) [ 63.121706] [] (dump_stack) from [] (panic+0xa0/0x220) [ 63.128895] [] (panic) from [] (do_exit+0x974/0x9d0) [ 63.135900] [] (do_exit) from [] (SyS_reboot+0x14c/0x1e8) [ 63.143361] [] (SyS_reboot) from [] (ret_fast_syscall+0x0/0x48) [ 63.151596] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000000 Signed-off-by: Johan Hovold --- arch/arm/kernel/process.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c index a35f6ebbd2c2..68c38af5687c 100644 --- a/arch/arm/kernel/process.c +++ b/arch/arm/kernel/process.c @@ -212,6 +212,12 @@ void machine_power_off(void) if (pm_power_off) pm_power_off(); + + /* Give a grace period for failure to power off */ + mdelay(1000); + + pr_err("Power off failed -- system halted\n"); + while (1); } /*