| Message ID | 20141029193915.GB2542@atomide.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 12:39-20141029, Tony Lindgren wrote: > * Sebastian Reichel <sre@ring0.de> [141029 12:01]: > > Hi, > > > > On Wed, Oct 29, 2014 at 08:43:03AM -0500, Nishanth Menon wrote: > > > On 10/28/2014 05:12 PM, Tony Lindgren wrote: > > > > * Aaro Koskinen <aaro.koskinen@iki.fi> [141027 16:03]: > > > >> Hi, > > > >> > > > >> On Mon, Oct 27, 2014 at 01:00:09PM -0700, Tony Lindgren wrote: > > > >>> + > > > >>> + if (!of_have_populated_dt()) > > > >>> + pr_warn("WARNING: legacy booting deprecated, please update to boot with .dts\n"); > > > >>> + > > > >> > > > >> Maybe use WARN so that the warning is more verbose and kernel gets tainted? > > > > > > > > Well I was hoping to avoid annoying people with the trace. > > > > But can do that if people prefer that, what do others think? > > > > > > > > > > WARN is better and eye catchy. Also, could we add information on when > > > the support will be removed since we call it deprecated? > > Well quoting the hostage situation from a Mr. Show episode > "Now Who Wants Ice Cream?" the answer to that would be: > > OK, you want me to guess? A hundred million days, or maybe ten more > minutes, somewhere in there, I just can't say, don't know. How about ~1 year? We have been talking about dt only boot for over an year already... Can we say 3.22 kernel, platforms that are not converted to device tree only loose legacy boot support.
* Nishanth Menon <nm@ti.com> [141029 14:47]: > On 12:39-20141029, Tony Lindgren wrote: > > * Sebastian Reichel <sre@ring0.de> [141029 12:01]: > > > Hi, > > > > > > On Wed, Oct 29, 2014 at 08:43:03AM -0500, Nishanth Menon wrote: > > > > On 10/28/2014 05:12 PM, Tony Lindgren wrote: > > > > > * Aaro Koskinen <aaro.koskinen@iki.fi> [141027 16:03]: > > > > >> Hi, > > > > >> > > > > >> On Mon, Oct 27, 2014 at 01:00:09PM -0700, Tony Lindgren wrote: > > > > >>> + > > > > >>> + if (!of_have_populated_dt()) > > > > >>> + pr_warn("WARNING: legacy booting deprecated, please update to boot with .dts\n"); > > > > >>> + > > > > >> > > > > >> Maybe use WARN so that the warning is more verbose and kernel gets tainted? > > > > > > > > > > Well I was hoping to avoid annoying people with the trace. > > > > > But can do that if people prefer that, what do others think? > > > > > > > > > > > > > WARN is better and eye catchy. Also, could we add information on when > > > > the support will be removed since we call it deprecated? > > > > Well quoting the hostage situation from a Mr. Show episode > > "Now Who Wants Ice Cream?" the answer to that would be: > > > > OK, you want me to guess? A hundred million days, or maybe ten more > > minutes, somewhere in there, I just can't say, don't know. > > How about ~1 year? We have been talking about dt only boot for over an > year already... Can we say 3.22 kernel, platforms that are not converted > to device tree only loose legacy boot support. I'm hoping we can make it faster let's say over next two merge windows. Pretty much everything already works with device tree booting so now it's just a question of getting people to start using it and fix whatever issues we may encounter. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Oct 29, 2014 at 04:45:41PM -0500, Nishanth Menon wrote: > On 12:39-20141029, Tony Lindgren wrote: > > OK, you want me to guess? A hundred million days, or maybe ten more > > minutes, somewhere in there, I just can't say, don't know. > > How about ~1 year? We have been talking about dt only boot for over an > year already... Can we say 3.22 kernel, platforms that are not converted > to device tree only loose legacy boot support. If you want to define some date, it should be a calendar date instead of some kernel version based on guesswork (you cannot really predict the kernel versions for future, just remember the 2.6.39 -> 3.0 change). Also, you cannot expect all kernel users to know what you have been talking about. E.g. OMAP DMA API deprecation may have been discussed before, but I only learned it after the WARN appeared in the kernel tree. So you should start counting from that. Personally I don't mind if you delete OMAP3 legacy boot support already tomorrow morning, but if you want to give ~1 year transition period it should end somewhere in the end of 2015. Of course if there are no legacy boot users you can do it faster. A. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Wed, Oct 29, 2014 at 12:39:16PM -0700, Tony Lindgren wrote: > 8< ----------------------- > From: Tony Lindgren <tony@atomide.com> > Date: Mon, 27 Oct 2014 13:05:54 -0700 > Subject: [PATCH] ARM: OMAP2+: Warn about deprecated legacy booting mode > > We're moving omaps to use device tree based booting and already have > omap2, omap4, omap5, am335x and am437x booting in device tree only > mode. > > Only omap3 still has legacy booting still around and we really want > to make that device tree only. So let's add a warning about deprecated > legacy booting so we get people to upgrade their boards to use device > tree based booting and find out about any remaining issues. > > Note that for most boards we already have the .dts file and those can > be booted with without changing the bootloader using the appended > DTB mode. > > Signed-off-by: Tony Lindgren <tony@atomide.com> > > --- a/arch/arm/mach-omap2/omap_device.c > +++ b/arch/arm/mach-omap2/omap_device.c > @@ -917,6 +917,10 @@ static int __init omap_device_late_idle(struct device *dev, void *data) > static int __init omap_device_late_init(void) > { > bus_for_each_dev(&platform_bus_type, NULL, NULL, omap_device_late_idle); > + > + WARN(!of_have_populated_dt(), > + "legacy booting deprecated, please update to boot with .dts\n"); > + > return 0; > } > omap_late_initcall_sync(omap_device_late_init); Acked-By: Sebastian Reichel <sre@kernel.org> -- Sebastian
On Wed, Oct 29, 2014 at 12:39:16PM -0700, Tony Lindgren wrote: > From: Tony Lindgren <tony@atomide.com> > Date: Mon, 27 Oct 2014 13:05:54 -0700 > Subject: [PATCH] ARM: OMAP2+: Warn about deprecated legacy booting mode > > We're moving omaps to use device tree based booting and already have > omap2, omap4, omap5, am335x and am437x booting in device tree only > mode. > > Only omap3 still has legacy booting still around and we really want > to make that device tree only. So let's add a warning about deprecated > legacy booting so we get people to upgrade their boards to use device > tree based booting and find out about any remaining issues. > > Note that for most boards we already have the .dts file and those can > be booted with without changing the bootloader using the appended > DTB mode. > > Signed-off-by: Tony Lindgren <tony@atomide.com> Reviewed-by: Aaro Koskinen <aaro.koskinen@iki.fi> > --- a/arch/arm/mach-omap2/omap_device.c > +++ b/arch/arm/mach-omap2/omap_device.c > @@ -917,6 +917,10 @@ static int __init omap_device_late_idle(struct device *dev, void *data) > static int __init omap_device_late_init(void) > { > bus_for_each_dev(&platform_bus_type, NULL, NULL, omap_device_late_idle); > + > + WARN(!of_have_populated_dt(), > + "legacy booting deprecated, please update to boot with .dts\n"); > + > return 0; > } > omap_late_initcall_sync(omap_device_late_init); -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Tony, On Thu, Oct 30, 2014 at 12:11 AM, Aaro Koskinen <aaro.koskinen@iki.fi> wrote: > On Wed, Oct 29, 2014 at 12:39:16PM -0700, Tony Lindgren wrote: >> From: Tony Lindgren <tony@atomide.com> >> Date: Mon, 27 Oct 2014 13:05:54 -0700 >> Subject: [PATCH] ARM: OMAP2+: Warn about deprecated legacy booting mode >> >> We're moving omaps to use device tree based booting and already have >> omap2, omap4, omap5, am335x and am437x booting in device tree only >> mode. >> >> Only omap3 still has legacy booting still around and we really want >> to make that device tree only. So let's add a warning about deprecated >> legacy booting so we get people to upgrade their boards to use device >> tree based booting and find out about any remaining issues. >> >> Note that for most boards we already have the .dts file and those can >> be booted with without changing the bootloader using the appended >> DTB mode. >> >> Signed-off-by: Tony Lindgren <tony@atomide.com> > > Reviewed-by: Aaro Koskinen <aaro.koskinen@iki.fi> > Reviewed-by: Javier Martinez Canillas <javier@dowhile0.org> Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/29/2014 05:31 PM, Aaro Koskinen wrote: > Also, you cannot expect all kernel users to know what you have been > talking about. E.g. OMAP DMA API deprecation may have been discussed > before, but I only learned it after the WARN appeared in the kernel tree. > So you should start counting from that. > > Personally I don't mind if you delete OMAP3 legacy boot support already > tomorrow morning, but if you want to give ~1 year transition period it > should end somewhere in the end of 2015. Of course if there are no legacy > boot users you can do it faster. How about the following? > > + WARN(!of_have_populated_dt(), > + "legacy booting deprecated(proposed removal in December 2015), please update to boot with .dts\n"); > + Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- a/arch/arm/mach-omap2/omap_device.c +++ b/arch/arm/mach-omap2/omap_device.c @@ -917,6 +917,10 @@ static int __init omap_device_late_idle(struct device *dev, void *data) static int __init omap_device_late_init(void) { bus_for_each_dev(&platform_bus_type, NULL, NULL, omap_device_late_idle); + + WARN(!of_have_populated_dt(), + "legacy booting deprecated, please update to boot with .dts\n"); + return 0; } omap_late_initcall_sync(omap_device_late_init);