From patchwork Mon Nov 10 12:31:18 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Machek X-Patchwork-Id: 5265791 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 642269F387 for ; Mon, 10 Nov 2014 12:31:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A15EC201B4 for ; Mon, 10 Nov 2014 12:31:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C22C920179 for ; Mon, 10 Nov 2014 12:31:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752723AbaKJMbW (ORCPT ); Mon, 10 Nov 2014 07:31:22 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:51828 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752553AbaKJMbU (ORCPT ); Mon, 10 Nov 2014 07:31:20 -0500 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 73CE981DD3; Mon, 10 Nov 2014 13:31:18 +0100 (CET) Date: Mon, 10 Nov 2014 13:31:18 +0100 From: Pavel Machek To: pali.rohar@gmail.com, sre@debian.org, sre@ring0.de, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, freemangordon@abv.bg Subject: Tiny dts change breaks boot on n900 Message-ID: <20141110123118.GA31134@amd> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi! I'm confused: This fixes boot on n900. Strange thing is ... adp1653 driver is not even compiled in -- it is module. It looks like tiny change in dts noone should care about breaks boot... I don't even have adp1653 device parsing code written. Something similar happened before -- change in device tree order broke boot. Any ideas? What is going on? Pavel diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts index f3118bf..557a19e 100644 --- a/arch/arm/boot/dts/omap3-n900.dts +++ b/arch/arm/boot/dts/omap3-n900.dts @@ -565,11 +565,6 @@ adp1653: adp1653@30 { compatible = "ad,adp1653"; reg = <0x30>; - - max-flash-timeout-usec = <500000>; - max-flash-intensity-mA = <0>; - max-torch-intensity-mA = <0>; - max-indicator-intensity-uA = <0>; }; };