From patchwork Wed Jan 28 22:41:44 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Machek X-Patchwork-Id: 5732761 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 73D889F1AF for ; Thu, 29 Jan 2015 01:10:48 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A41D82025A for ; Thu, 29 Jan 2015 01:10:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4513F2011D for ; Thu, 29 Jan 2015 01:10:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752710AbbA2BKZ (ORCPT ); Wed, 28 Jan 2015 20:10:25 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:33456 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752552AbbA2BJI (ORCPT ); Wed, 28 Jan 2015 20:09:08 -0500 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id C5E5581CE5; Wed, 28 Jan 2015 23:41:45 +0100 (CET) Date: Wed, 28 Jan 2015 23:41:44 +0100 From: Pavel Machek To: Jarkko Nikula Cc: Peter Ujfalusi , pali.rohar@gmail.com, sre@debian.org, sre@ring0.de, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com Subject: Re: 3.19 on Nokia n900: audio quality awful Message-ID: <20150128224144.GA28956@amd> References: <20150106170433.GA5408@amd> <20150118120139.GA1509@amd> <54C63F1C.6010703@ti.com> <54C92752.9000004@bitmer.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <54C92752.9000004@bitmer.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed 2015-01-28 20:15:46, Jarkko Nikula wrote: > On 01/26/2015 03:20 PM, Peter Ujfalusi wrote: > > On 01/18/2015 02:01 PM, Pavel Machek wrote: > >> In 2.6.28-nokia, it is neccessary to set "Input select" na "digital > >> mic", then it works. Input select being in "playback" option makes it > >> easy to miss. > >> > >> In 3.18 and 3.19-rc3, all I can record are zeros. > >> > >> Does playback/recording work for you on OMAP 3430-based machines? > > > > Same codec (tlv320aic3106) works fine on my am335x and omap-l138 boards. > > BeagleBoard-xM also fine with twl4030 codec. > > > > I don't have my n900 in hacking mode (it is still in use time-to-time) but > > looking at the dts file: you might want to add ai3x-micbias-vg property to the > > aic3x nodes to select the correct mic bias voltage. I can't recall what is > > appropriate for n900, but 2.6.28-nokia sources might give you the answer. > > > No need to go that far. N900 has been supported in mainline since 2.6.39 > or so. Part A of AIC34 (which is basically dual AIC33 in a same package) > drives 2 V for the digital microphone bias and part B 2.5 V for the headset. Let me try... Umm, no change here :-( root@n900:/tmp# arecord delme Recording WAVE 'delme' : Unsigned 8 bit, Rate 8000 Hz, Mono ^CAborted by signal Interrupt... root@n900:/tmp# hexdump delme 0000000 4952 4646 987c 0000 4157 4556 6d66 2074 0000010 0010 0000 0001 0001 1f40 0000 1f40 0000 0000020 0001 0008 6164 6174 9858 0000 8080 8080 0000030 8080 8080 8080 8080 8080 8080 8080 8080 * 0009880 root@n900:/tmp# aplay delme Playing WAVE 'delme' : Unsigned 8 bit, Rate 8000 Hz, Mono root@n900:/tmp# I did this: I'm not sure which one is "main" microphone and which is headset, but I guess 2V should be "close enough" to 2.5V to produce something different from zeros..? > Unfortunately I haven't had time recently to try what might have caused > that regression after 3.18. Thanks, Pavel diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts index 48b0987..f18a5b0 100644 --- a/arch/arm/boot/dts/omap3-n900.dts +++ b/arch/arm/boot/dts/omap3-n900.dts @@ -491,6 +491,8 @@ DRVDD-supply = <&vmmc2>; IOVDD-supply = <&vio>; DVDD-supply = <&vio>; + + ai3x-micbias-vg = <1>; }; tlv320aic3x_aux: tlv320aic3x@19 { @@ -502,6 +504,8 @@ DRVDD-supply = <&vmmc2>; IOVDD-supply = <&vio>; DVDD-supply = <&vio>; + + ai3x-micbias-vg = <1>; }; tsl2563: tsl2563@29 {