From patchwork Mon Mar 9 17:49:36 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 5970431 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id CA49E9F318 for ; Mon, 9 Mar 2015 17:50:11 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EBCA720263 for ; Mon, 9 Mar 2015 17:50:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 292F020145 for ; Mon, 9 Mar 2015 17:50:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932122AbbCIRuI (ORCPT ); Mon, 9 Mar 2015 13:50:08 -0400 Received: from mail-ie0-f171.google.com ([209.85.223.171]:46587 "EHLO mail-ie0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753931AbbCIRtl (ORCPT ); Mon, 9 Mar 2015 13:49:41 -0400 Received: by iecrd18 with SMTP id rd18so14649375iec.13; Mon, 09 Mar 2015 10:49:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=t/RSYwUgLXxAaXmOq9n/+T2wpdZXcox85mR0LNomio8=; b=u0YJFphEd+Bb2O14GhKnQ8MLqpPXYGc9udBri92Zn8OJpiLnpBw927EMx35D5uQ6xR zpi8mrqDLIfvpLAh9550RmjOUQR5nIqclnwbNL+/7twQ3hZgVrAT5dvwxbBBvuWtpRN6 X1v8V59vZ/+BvcI2DS/KNJ+gDJDOZhSUS7j7DmV3OgUYniqgsmxvaCTnMkRhSHCxz+40 TwkIdYHNif2SJkwP8qBzVOMSOgPJKWFbnNx1INcJDqtRIJyD/m+2fm8K/IdUrTIBgAld TkBQtPWN4Yhci+H8eoPHbzTu6rENtjakNFNA0M/LwCPd2RDHNVHyqlfy/U2CNkmuSnVz rquQ== X-Received: by 10.50.79.230 with SMTP id m6mr49198328igx.33.1425923380978; Mon, 09 Mar 2015 10:49:40 -0700 (PDT) Received: from dtor-ws ([2620:0:1000:1301:e89d:fc51:1f84:5b7a]) by mx.google.com with ESMTPSA id a71sm2465749ioe.41.2015.03.09.10.49.39 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 09 Mar 2015 10:49:39 -0700 (PDT) Date: Mon, 9 Mar 2015 10:49:36 -0700 From: Dmitry Torokhov To: Tony Lindgren Cc: Samuel Ortiz , Lee Jones , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] mfd: menelaus: rmove incorrect __exit markups Message-ID: <20150309174936.GA22662@dtor-ws> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Even if bus is not hot-pluggable, the devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes. Signed-off-by: Dmitry Torokhov Acked-by: Tony Lindgren --- drivers/mfd/menelaus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c index 9f01aef..5269ff2 100644 --- a/drivers/mfd/menelaus.c +++ b/drivers/mfd/menelaus.c @@ -1259,7 +1259,7 @@ fail: return err; } -static int __exit menelaus_remove(struct i2c_client *client) +static int menelaus_remove(struct i2c_client *client) { struct menelaus_chip *menelaus = i2c_get_clientdata(client); @@ -1280,7 +1280,7 @@ static struct i2c_driver menelaus_i2c_driver = { .name = DRIVER_NAME, }, .probe = menelaus_probe, - .remove = __exit_p(menelaus_remove), + .remove = menelaus_remove, .id_table = menelaus_id, };