| Message ID | 20150403202624.GA4308@amd (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Pavel, On Fri, Apr 03, 2015 at 10:26:24PM +0200, Pavel Machek wrote: > > Documentation for adp1653 binding. > > --- > > > Please split this as Javier suggested. I'd think both could go through > > the media-tree unless someone objects. > > Please apply. > > > > + - power-gpios: Reference to the GPIO that controls the power for the chip. > > > > You're using power-gpios in documentation only. > > Which is ok, because generic code adds "-gpios" itself. > > > The spec refers to this by "EN". How about "en-gpios" instead? This > > definitely isn't about power, but about resetting the chip. It gets the > > power through another pin. > > It controls power of the chip. Noone gets _power_ through gpios, > hopefully. Yes, I can rename it. "en-gpios" is too ugly to > live. Sebastian suggested "enable". Hope that's okay with you. "enable-gpios" sounds fine for me. > > Pavel > > new file mode 100644 > index 0000000..da9934a > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/adp1653.txt > @@ -0,0 +1,37 @@ > +* Analog Devices ADP1653 flash LED driver > + > +Required Properties: > + > + - compatible: Must contain be "adi,adp1653" > + > + - reg: I2C slave address > + > + - power-gpios: Reference to the GPIO that controls the power for the chip. > + > +There are two LED outputs available - flash and indicator. One LED is > +represented by one child node, nodes need to be named "flash" and "indicator". > + > +Required properties of the LED child node: > +- max-microamp : see Documentation/devicetree/bindings/leds/common.txt > + > +Required properties of the flash LED child node: > + > +- flash-max-microamp : see Documentation/devicetree/bindings/leds/common.txt > +- flash-timeout-us : see Documentation/devicetree/bindings/leds/common.txt > + > +Example: > + > + adp1653: led-controller@30 { > + compatible = "adi,adp1653"; > + reg = <0x30>; > + power-gpios = <&gpio3 24 GPIO_ACTIVE_HIGH>; /* 88 */ > + > + flash { > + flash-timeout-us = <500000>; > + flash-max-microamp = <320000>; > + max-microamp = <50000>; > + }; > + indicator { > + max-microamp = <17500>; > + }; > + }; >
On Fri, Apr 03, 2015 at 10:26:24PM +0200, Pavel Machek wrote: > > > + - power-gpios: Reference to the GPIO that controls the power for the chip. > > > > You're using power-gpios in documentation only. > > Which is ok, because generic code adds "-gpios" itself. Do you think you need this part: + if (!of_find_property(node, "gpios", NULL)) { + dev_err(&client->dev, "No gpio node\n"); + return -EINVAL; + }
--- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/adp1653.txt @@ -0,0 +1,37 @@ +* Analog Devices ADP1653 flash LED driver + +Required Properties: + + - compatible: Must contain be "adi,adp1653" + + - reg: I2C slave address + + - power-gpios: Reference to the GPIO that controls the power for the chip. + +There are two LED outputs available - flash and indicator. One LED is +represented by one child node, nodes need to be named "flash" and "indicator". + +Required properties of the LED child node: +- max-microamp : see Documentation/devicetree/bindings/leds/common.txt + +Required properties of the flash LED child node: + +- flash-max-microamp : see Documentation/devicetree/bindings/leds/common.txt +- flash-timeout-us : see Documentation/devicetree/bindings/leds/common.txt + +Example: + + adp1653: led-controller@30 { + compatible = "adi,adp1653"; + reg = <0x30>; + power-gpios = <&gpio3 24 GPIO_ACTIVE_HIGH>; /* 88 */ + + flash { + flash-timeout-us = <500000>; + flash-max-microamp = <320000>; + max-microamp = <50000>; + }; + indicator { + max-microamp = <17500>; + }; + };