From patchwork Wed Jul 22 00:17:41 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Welling X-Patchwork-Id: 6838811 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 05830C05AC for ; Wed, 22 Jul 2015 00:18:08 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 34A3B20706 for ; Wed, 22 Jul 2015 00:18:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6432B206FE for ; Wed, 22 Jul 2015 00:18:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933999AbbGVARu (ORCPT ); Tue, 21 Jul 2015 20:17:50 -0400 Received: from mail-ie0-f177.google.com ([209.85.223.177]:36055 "EHLO mail-ie0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751690AbbGVARt (ORCPT ); Tue, 21 Jul 2015 20:17:49 -0400 Received: by iehx8 with SMTP id x8so75355683ieh.3; Tue, 21 Jul 2015 17:17:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=92zuPSCmv9tnjO7AHCDEzx9qZeWAIy2oEWH5KmzrxR8=; b=WDHZ4cOAbh+/fAXNgDCZD5Lv12qu8QuMXa+VSIZMvfFHcseTKxpLu0s1k+wCJxqDtQ xmgIpSUk3h7xSwpaTBWJmFIr6RhQUpXvCmLHkhgxv87VAllVDHdUdcOmDAMoisirf+6y MY2ZVJ/+2TdbWdV3VtAB7ND35TrUUNTt7sIitpJTzh/c0gv2IDNmmtSmYshCuU5ICsXE KFgHqigdL1CNjUV7V4RakOcuZtc4OdJeECDeBOKkqF1Nlj9wliikiFatsBAPA1NBxoUp kV/m4a3QdlTSf3Ac0w42kBFyZhhauwTrxhLMammM35nzFlF6u1lVxpoV5t4CGTdNIAiK 4mbA== X-Received: by 10.107.135.148 with SMTP id r20mr46666717ioi.153.1437524268748; Tue, 21 Jul 2015 17:17:48 -0700 (PDT) Received: from deathstar (173-22-240-187.client.mchsi.com. [173.22.240.187]) by smtp.gmail.com with ESMTPSA id t7sm8370428ign.8.2015.07.21.17.17.47 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Jul 2015 17:17:48 -0700 (PDT) Date: Tue, 21 Jul 2015 19:17:41 -0500 From: Michael Welling To: Pavel Machek Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , Sebastian Reichel , Tony Lindgren , Ivaylo Dimitrov , Aaro Koskinen , Nishanth Menon , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: linux 4.2-rc1 broken Nokia N900 Message-ID: <20150722001741.GA7950@deathstar> References: <201507111405.06048@pali> <201507132234.22082@pali> <20150713215232.GA22584@deathray> <201507140002.44119@pali> <20150713223607.GA23001@deathray> <20150714071412.GA12844@pali> <20150720204647.GA11931@deathstar> <20150721093441.GA23241@amd> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150721093441.GA23241@amd> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Jul 21, 2015 at 11:34:41AM +0200, Pavel Machek wrote: This code has my head spinning. I found that the errors do not occur when the driver is built into the kernel. I also found that with the patch below the errors go away. Not sure if it is acceptible but see if it fixes things on your side. --- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index cf8b91b..3164d13 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -1801,11 +1801,11 @@ int spi_setup(struct spi_device *spi) if (!spi->max_speed_hz) spi->max_speed_hz = spi->master->max_speed_hz; - spi_set_cs(spi, false); - if (spi->master->setup) status = spi->master->setup(spi); + spi_set_cs(spi, false); + dev_dbg(&spi->dev, "setup mode %d, %s%s%s%s%u bits/w, %u Hz max --> %d\n", (int) (spi->mode & (SPI_CPOL | SPI_CPHA)), (spi->mode & SPI_CS_HIGH) ? "cs_high, " : "",