From patchwork Wed Dec 2 16:09:56 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tony Lindgren X-Patchwork-Id: 7748151 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D9933BEEE1 for ; Wed, 2 Dec 2015 16:10:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 057802056E for ; Wed, 2 Dec 2015 16:10:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1E73320524 for ; Wed, 2 Dec 2015 16:10:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758810AbbLBQKF (ORCPT ); Wed, 2 Dec 2015 11:10:05 -0500 Received: from muru.com ([72.249.23.125]:50209 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757514AbbLBQKD (ORCPT ); Wed, 2 Dec 2015 11:10:03 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 0762A8392; Wed, 2 Dec 2015 16:10:48 +0000 (UTC) Date: Wed, 2 Dec 2015 08:09:56 -0800 From: Tony Lindgren To: Matthijs van Duin Cc: lkml , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Brian Hutchinson , Delio Brignoli , Neil Armstrong , Philipp Rosenberger Subject: Re: [PATCH 10/10] ARM: dts: Fix dm814x pinctrl address and mask Message-ID: <20151202160955.GD23396@atomide.com> References: <1449013103-23238-1-git-send-email-tony@atomide.com> <1449013103-23238-11-git-send-email-tony@atomide.com> <20151202004623.GX23396@atomide.com> <20151202012200.GZ23396@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20151202012200.GZ23396@atomide.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP * Tony Lindgren [151201 17:23]: > * Matthijs van Duin [151201 17:15]: > > On 2 December 2015 at 01:46, Tony Lindgren wrote: > > > Ouch. We should probably have separate PIN_INPUT_3V3 and PIN_OUTPUT_3V3 > > > dts macros that ensure that? > > > > Can't we just keep bit 18 out of the function mask? The bootloader > > should already have made sure all pins have bit 18 set (and bit 19 set > > to correct values after ROM mucked them up, see advisory 2.1.88), so > > all that needs to be done is avoid touching them. > > Sounds good to me. And people who really want to override the mask can > do it in the board specifc dts file. > > > Are the power savings from disabling unnecessary inputs significant > > enough to spend any headache on it? > > Only for some battery powered devices, not in this case for sure. And here's an updated version of this patch. Regards, Tony 8< ---------------------------- From: Tony Lindgren Date: Tue, 1 Dec 2015 15:04:38 -0800 Subject: [PATCH] ARM: dts: Fix dm814x pinctrl address and mask Otherwise pinctrl won't work. Because of silicon errata for some dm814x versions, let's also keep bit 18 out of the function-mask and rely on the bootloader configuration for bit 18 as suggested by Matthijs van Duin . Devices with that need to use bit 18 can override the function-mask in the board specific dts file if really needed. Signed-off-by: Tony Lindgren --- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/arch/arm/boot/dts/dm814x.dtsi +++ b/arch/arm/boot/dts/dm814x.dtsi @@ -205,13 +205,21 @@ }; }; + /* + * Note that silicon revision 2.1 and older + * require input enabled (bit 18 set) for all + * 3.3V I/Os to avoid cumulative hardware damage. + * For more info, see errata advisory 2.1.87. + * We leave bit 18 out of function-mask and rely + * on the bootloader for it. + */ pincntl: pinmux@800 { compatible = "pinctrl-single"; - reg = <0x800 0xc38>; + reg = <0x800 0x438>; #address-cells = <1>; #size-cells = <0>; pinctrl-single,register-width = <32>; - pinctrl-single,function-mask = <0x300ff>; + pinctrl-single,function-mask = <0x307ff>; }; };