From patchwork Sun Feb 7 22:05:39 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emil Goode X-Patchwork-Id: 8245731 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id F241E9F38B for ; Sun, 7 Feb 2016 22:14:41 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1B715201C0 for ; Sun, 7 Feb 2016 22:14:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2843B201BB for ; Sun, 7 Feb 2016 22:14:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754715AbcBGWNs (ORCPT ); Sun, 7 Feb 2016 17:13:48 -0500 Received: from mailout.easymail.ca ([64.68.201.169]:46412 "EHLO mailout.easymail.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754395AbcBGWNr (ORCPT ); Sun, 7 Feb 2016 17:13:47 -0500 X-Greylist: delayed 404 seconds by postgrey-1.27 at vger.kernel.org; Sun, 07 Feb 2016 17:13:46 EST Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id AEAA6EDD9; Sun, 7 Feb 2016 17:07:01 -0500 (EST) X-Virus-Scanned: Debian amavisd-new at mailout.easymail.ca X-Spam-Score: -1.943 X-Spam-Level: X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (easymail-mailout.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id msxOk8vqH+Hc; Sun, 7 Feb 2016 17:07:01 -0500 (EST) Received: from lianli (31-211-236-16.customers.ownit.se [31.211.236.16]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 409EDE9B3; Sun, 7 Feb 2016 17:07:00 -0500 (EST) Date: Sun, 7 Feb 2016 23:05:39 +0100 From: Emil Goode To: Sebastian Reichel Cc: Ross Green , Shahar Patury , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-wireless@vger.kernel.org, Guy Mishol , Kalle Valo Subject: Re: wl12xx regression on 4.5 (was: Re: linux-4.5-rc1 TI pandboard-es wifi wlcore locks and reset) Message-ID: <20160207220538.GA4464@lianli> References: <20160202043448.GA9514@earth> <20160202160538.GA19990@earth> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160202160538.GA19990@earth> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hello, On Tue, Feb 02, 2016 at 05:05:38PM +0100, Sebastian Reichel wrote: > On Tue, Feb 02, 2016 at 04:41:13PM +1100, Ross Green wrote: > > On Tue, Feb 2, 2016 at 3:34 PM, Sebastian Reichel wrote: > > > On Mon, Feb 01, 2016 at 11:38:38PM +1100, Ross Green wrote: > > >> On Mon, Jan 25, 2016 at 11:47 PM, Ross Green wrote: > > >> > Just tried the new kernel release on faithful pandaboard es with the > > >> > new 4.5-rc1 release. > > >> > > > >> > There is a problem with the wifi modules once the modules are loaded. > > >> > Looks like the wifi firmware gets loaded put no response after that > > >> > causing recovery action. > > >> > > > >> > the kernel 4.4 works quite happily with this board. > > >> > > > >> > Here is a dmesg dump in the attachment. > > >> > > > >> > Anyone have any ideas here? > > > > [...] > > > > If I get time, this evening, I'll see if I can give a bisect a try. > > On N950 [wl1271 via SPI, using extra patches to init from DT] I get wifi > working again on 4.5-rc1 with 3719c17e1816 ("wlcore/wl18xx: fw logger > over sdio") reverted. Reverting the changes in wlcore_set_partition() as below seem to help. Best regards, Emil Goode 8<-------- --- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/net/wireless/ti/wlcore/io.c +++ b/drivers/net/wireless/ti/wlcore/io.c @@ -175,14 +175,15 @@ int wlcore_set_partition(struct wl1271 *wl, if (ret < 0) goto out; + /* + * We don't need the size of the last partition, as it is + * automatically calculated based on the total memory size and + * the sizes of the previous partitions. + */ ret = wlcore_raw_write32(wl, HW_PART3_START_ADDR, p->mem3.start); if (ret < 0) goto out; - ret = wlcore_raw_write32(wl, HW_PART3_SIZE_ADDR, p->mem3.size); - if (ret < 0) - goto out; - out: return ret; } diff --git a/drivers/net/wireless/ti/wlcore/io.h b/drivers/net/wireless/ti/wlcore/io.h index 6c257b5..10cf374 100644 --- a/drivers/net/wireless/ti/wlcore/io.h +++ b/drivers/net/wireless/ti/wlcore/io.h @@ -36,8 +36,8 @@ #define HW_PART1_START_ADDR (HW_PARTITION_REGISTERS_ADDR + 12) #define HW_PART2_SIZE_ADDR (HW_PARTITION_REGISTERS_ADDR + 16) #define HW_PART2_START_ADDR (HW_PARTITION_REGISTERS_ADDR + 20) -#define HW_PART3_SIZE_ADDR (HW_PARTITION_REGISTERS_ADDR + 24) -#define HW_PART3_START_ADDR (HW_PARTITION_REGISTERS_ADDR + 28) +#define HW_PART3_START_ADDR (HW_PARTITION_REGISTERS_ADDR + 24) + #define HW_ACCESS_REGISTER_SIZE 4 #define HW_ACCESS_PRAM_MAX_RANGE 0x3c000