diff mbox

[arm,1/1] arm: Use _rcuidle tracepoint to allow use from idle

Message ID 20160426154414.7bb33de4@gandalf.local.home (mailing list archive)
State New, archived
Headers show

Commit Message

Steven Rostedt April 26, 2016, 7:44 p.m. UTC 
On Tue, 26 Apr 2016 12:39:50 -0700
Tony Lindgren <tony@atomide.com> wrote:


> With these omap4 is now OK. But omap3 produces yet another warning,
> See below :)
> 
> Regards,
> 
> Tony
> 
> 8< ------------------
> ===============================
> [ INFO: suspicious RCU usage. ]
> 4.6.0-rc5-next-20160426+ #1114 Not tainted
> -------------------------------
> include/trace/events/clk.h:59 suspicious rcu_dereference_check() usage!
> 
> other info that might help us debug this:
> 
> 
> RCU used illegally from idle CPU!
> rcu_scheduler_active = 1, debug_locks = 0
> RCU used illegally from extended quiescent state!
> 2 locks held by swapper/0/0:
>  #0:  (&oh->hwmod_key#30){......}, at: [<c0121b40>] omap_hwmod_idle+0x18/0x44
>  #1:  (enable_lock){......}, at: [<c0630998>] clk_enable_lock+0x18/0x124
> 
> stack backtrace:
> CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.6.0-rc5-next-20160426+ #1114
> Hardware name: Generic OMAP36xx (Flattened Device Tree)
> [<c0110290>] (unwind_backtrace) from [<c010c3a8>] (show_stack+0x10/0x14)
> [<c010c3a8>] (show_stack) from [<c047fd68>] (dump_stack+0xb0/0xe4)
> [<c047fd68>] (dump_stack) from [<c0631618>] (clk_core_disable+0x17c/0x348)
> [<c0631618>] (clk_core_disable) from [<c0632774>] (clk_disable+0x24/0x30)
> [<c0632774>] (clk_disable) from [<c0120590>] (_disable_clocks+0x18/0x7c)
> [<c0120590>] (_disable_clocks) from [<c0121680>] (_idle+0x12c/0x230)
> [<c0121680>] (_idle) from [<c0121b4c>] (omap_hwmod_idle+0x24/0x44)
> [<c0121b4c>] (omap_hwmod_idle) from [<c0122c24>] (omap_device_idle+0x3c/0x90)
> [<c0122c24>] (omap_device_idle) from [<c052cc00>] (__rpm_callback+0x2c/0x60)
> [<c052cc00>] (__rpm_callback) from [<c052cc54>] (rpm_callback+0x20/0x80)
> [<c052cc54>] (rpm_callback) from [<c052d150>] (rpm_suspend+0x100/0x768)
> [<c052d150>] (rpm_suspend) from [<c052ec58>] (__pm_runtime_suspend+0x64/0x84)
> [<c052ec58>] (__pm_runtime_suspend) from [<c04bf25c>] (omap2_gpio_prepare_for_idle+0x5
> c/0x70)
> [<c04bf25c>] (omap2_gpio_prepare_for_idle) from [<c0125568>] (omap_sram_idle+0x140/0x2
> 44)
> [<c0125568>] (omap_sram_idle) from [<c01269dc>] (omap3_enter_idle_bm+0xfc/0x1ec)
> [<c01269dc>] (omap3_enter_idle_bm) from [<c0601bdc>] (cpuidle_enter_state+0x80/0x3d4)
> [<c0601bdc>] (cpuidle_enter_state) from [<c0183b08>] (cpu_startup_entry+0x198/0x3a0)
> [<c0183b08>] (cpu_startup_entry) from [<c0b00c0c>] (start_kernel+0x354/0x3c8)
> [<c0b00c0c>] (start_kernel) from [<8000807c>] (0x8000807c)

*Whack* *Whack* *Whack*!!!

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Paul E. McKenney April 26, 2016, 7:51 p.m. UTC | #1 
On Tue, Apr 26, 2016 at 03:44:14PM -0400, Steven Rostedt wrote:
> On Tue, 26 Apr 2016 12:39:50 -0700
> Tony Lindgren <tony@atomide.com> wrote:
> 
> 
> > With these omap4 is now OK. But omap3 produces yet another warning,
> > See below :)
> > 
> > Regards,
> > 
> > Tony
> > 
> > 8< ------------------
> > ===============================
> > [ INFO: suspicious RCU usage. ]
> > 4.6.0-rc5-next-20160426+ #1114 Not tainted
> > -------------------------------
> > include/trace/events/clk.h:59 suspicious rcu_dereference_check() usage!
> > 
> > other info that might help us debug this:
> > 
> > 
> > RCU used illegally from idle CPU!
> > rcu_scheduler_active = 1, debug_locks = 0
> > RCU used illegally from extended quiescent state!
> > 2 locks held by swapper/0/0:
> >  #0:  (&oh->hwmod_key#30){......}, at: [<c0121b40>] omap_hwmod_idle+0x18/0x44
> >  #1:  (enable_lock){......}, at: [<c0630998>] clk_enable_lock+0x18/0x124
> > 
> > stack backtrace:
> > CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.6.0-rc5-next-20160426+ #1114
> > Hardware name: Generic OMAP36xx (Flattened Device Tree)
> > [<c0110290>] (unwind_backtrace) from [<c010c3a8>] (show_stack+0x10/0x14)
> > [<c010c3a8>] (show_stack) from [<c047fd68>] (dump_stack+0xb0/0xe4)
> > [<c047fd68>] (dump_stack) from [<c0631618>] (clk_core_disable+0x17c/0x348)
> > [<c0631618>] (clk_core_disable) from [<c0632774>] (clk_disable+0x24/0x30)
> > [<c0632774>] (clk_disable) from [<c0120590>] (_disable_clocks+0x18/0x7c)
> > [<c0120590>] (_disable_clocks) from [<c0121680>] (_idle+0x12c/0x230)
> > [<c0121680>] (_idle) from [<c0121b4c>] (omap_hwmod_idle+0x24/0x44)
> > [<c0121b4c>] (omap_hwmod_idle) from [<c0122c24>] (omap_device_idle+0x3c/0x90)
> > [<c0122c24>] (omap_device_idle) from [<c052cc00>] (__rpm_callback+0x2c/0x60)
> > [<c052cc00>] (__rpm_callback) from [<c052cc54>] (rpm_callback+0x20/0x80)
> > [<c052cc54>] (rpm_callback) from [<c052d150>] (rpm_suspend+0x100/0x768)
> > [<c052d150>] (rpm_suspend) from [<c052ec58>] (__pm_runtime_suspend+0x64/0x84)
> > [<c052ec58>] (__pm_runtime_suspend) from [<c04bf25c>] (omap2_gpio_prepare_for_idle+0x5
> > c/0x70)
> > [<c04bf25c>] (omap2_gpio_prepare_for_idle) from [<c0125568>] (omap_sram_idle+0x140/0x2
> > 44)
> > [<c0125568>] (omap_sram_idle) from [<c01269dc>] (omap3_enter_idle_bm+0xfc/0x1ec)
> > [<c01269dc>] (omap3_enter_idle_bm) from [<c0601bdc>] (cpuidle_enter_state+0x80/0x3d4)
> > [<c0601bdc>] (cpuidle_enter_state) from [<c0183b08>] (cpu_startup_entry+0x198/0x3a0)
> > [<c0183b08>] (cpu_startup_entry) from [<c0b00c0c>] (start_kernel+0x354/0x3c8)
> > [<c0b00c0c>] (start_kernel) from [<8000807c>] (0x8000807c)
> 
> *Whack* *Whack* *Whack*!!!
> 
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

Or use Steven's identical patch, your choice.  ;-)

							Thanx, Paul

> ---
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index fb74dc1f7520..4fa43c02d682 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -682,12 +682,12 @@ static void clk_core_disable(struct clk_core *core)
>  	if (--core->enable_count > 0)
>  		return;
> 
> -	trace_clk_disable(core);
> +	trace_clk_disable_rcuidle(core);
> 
>  	if (core->ops->disable)
>  		core->ops->disable(core->hw);
> 
> -	trace_clk_disable_complete(core);
> +	trace_clk_disable_complete_rcuidle(core);
> 
>  	clk_core_disable(core->parent);
>  }
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tony Lindgren April 26, 2016, 7:51 p.m. UTC | #2 
* Steven Rostedt <rostedt@goodmis.org> [160426 12:45]:
> *Whack* *Whack* *Whack*!!!
> 
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> ---
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index fb74dc1f7520..4fa43c02d682 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -682,12 +682,12 @@ static void clk_core_disable(struct clk_core *core)
>  	if (--core->enable_count > 0)
>  		return;
>  
> -	trace_clk_disable(core);
> +	trace_clk_disable_rcuidle(core);
>  
>  	if (core->ops->disable)
>  		core->ops->disable(core->hw);
>  
> -	trace_clk_disable_complete(core);
> +	trace_clk_disable_complete_rcuidle(core);
>  
>  	clk_core_disable(core->parent);
>  }

Now the mole shows up here!

===============================
[ INFO: suspicious RCU usage. ]
4.6.0-rc5-next-20160426+ #1116 Not tainted
-------------------------------
include/trace/events/rpm.h:95 suspicious rcu_dereference_check() usage!

other info that might help us debug this:


RCU used illegally from idle CPU!
rcu_scheduler_active = 1, debug_locks = 0
RCU used illegally from extended quiescent state!
1 lock held by swapper/0/0:
 #0:  (&(&dev->power.lock)->rlock){-.-...}, at: [<c052cc2c>] __rpm_callback+0x58/0x60

stack backtrace:
CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.6.0-rc5-next-20160426+ #1116
Hardware name: Generic OMAP36xx (Flattened Device Tree)
[<c0110290>] (unwind_backtrace) from [<c010c3a8>] (show_stack+0x10/0x14)
[<c010c3a8>] (show_stack) from [<c047fd68>] (dump_stack+0xb0/0xe4)
[<c047fd68>] (dump_stack) from [<c052d5d0>] (rpm_suspend+0x580/0x768)
[<c052d5d0>] (rpm_suspend) from [<c052ec58>] (__pm_runtime_suspend+0x64/0x84)
[<c052ec58>] (__pm_runtime_suspend) from [<c04bf25c>] (omap2_gpio_prepare_for_idle+0x5c/0x70)
[<c04bf25c>] (omap2_gpio_prepare_for_idle) from [<c0125568>] (omap_sram_idle+0x140/0x244)
[<c0125568>] (omap_sram_idle) from [<c01269dc>] (omap3_enter_idle_bm+0xfc/0x1ec)
[<c01269dc>] (omap3_enter_idle_bm) from [<c0601bdc>] (cpuidle_enter_state+0x80/0x3d4)
[<c0601bdc>] (cpuidle_enter_state) from [<c0183b08>] (cpu_startup_entry+0x198/0x3a0)
[<c0183b08>] (cpu_startup_entry) from [<c0b00c0c>] (start_kernel+0x354/0x3c8)
[<c0b00c0c>] (start_kernel) from [<8000807c>] (0x8000807c)

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Steven Rostedt April 26, 2016, 7:52 p.m. UTC | #3 
On Tue, 26 Apr 2016 12:51:21 -0700
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:

> On Tue, Apr 26, 2016 at 03:44:14PM -0400, Steven Rostedt wrote:
> > On Tue, 26 Apr 2016 12:39:50 -0700
> > Tony Lindgren <tony@atomide.com> wrote:
> > 
> >   
> > > With these omap4 is now OK. But omap3 produces yet another warning,
> > > See below :)
> > > 
> > > Regards,
> > > 
> > > Tony
> > > 
> > > 8< ------------------
> > > ===============================
> > > [ INFO: suspicious RCU usage. ]
> > > 4.6.0-rc5-next-20160426+ #1114 Not tainted
> > > -------------------------------
> > > include/trace/events/clk.h:59 suspicious rcu_dereference_check() usage!
> > > 
> > > other info that might help us debug this:
> > > 
> > > 
> > > RCU used illegally from idle CPU!
> > > rcu_scheduler_active = 1, debug_locks = 0
> > > RCU used illegally from extended quiescent state!
> > > 2 locks held by swapper/0/0:
> > >  #0:  (&oh->hwmod_key#30){......}, at: [<c0121b40>] omap_hwmod_idle+0x18/0x44
> > >  #1:  (enable_lock){......}, at: [<c0630998>] clk_enable_lock+0x18/0x124
> > > 
> > > stack backtrace:
> > > CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.6.0-rc5-next-20160426+ #1114
> > > Hardware name: Generic OMAP36xx (Flattened Device Tree)
> > > [<c0110290>] (unwind_backtrace) from [<c010c3a8>] (show_stack+0x10/0x14)
> > > [<c010c3a8>] (show_stack) from [<c047fd68>] (dump_stack+0xb0/0xe4)
> > > [<c047fd68>] (dump_stack) from [<c0631618>] (clk_core_disable+0x17c/0x348)
> > > [<c0631618>] (clk_core_disable) from [<c0632774>] (clk_disable+0x24/0x30)
> > > [<c0632774>] (clk_disable) from [<c0120590>] (_disable_clocks+0x18/0x7c)
> > > [<c0120590>] (_disable_clocks) from [<c0121680>] (_idle+0x12c/0x230)
> > > [<c0121680>] (_idle) from [<c0121b4c>] (omap_hwmod_idle+0x24/0x44)
> > > [<c0121b4c>] (omap_hwmod_idle) from [<c0122c24>] (omap_device_idle+0x3c/0x90)
> > > [<c0122c24>] (omap_device_idle) from [<c052cc00>] (__rpm_callback+0x2c/0x60)
> > > [<c052cc00>] (__rpm_callback) from [<c052cc54>] (rpm_callback+0x20/0x80)
> > > [<c052cc54>] (rpm_callback) from [<c052d150>] (rpm_suspend+0x100/0x768)
> > > [<c052d150>] (rpm_suspend) from [<c052ec58>] (__pm_runtime_suspend+0x64/0x84)
> > > [<c052ec58>] (__pm_runtime_suspend) from [<c04bf25c>] (omap2_gpio_prepare_for_idle+0x5
> > > c/0x70)
> > > [<c04bf25c>] (omap2_gpio_prepare_for_idle) from [<c0125568>] (omap_sram_idle+0x140/0x2
> > > 44)
> > > [<c0125568>] (omap_sram_idle) from [<c01269dc>] (omap3_enter_idle_bm+0xfc/0x1ec)
> > > [<c01269dc>] (omap3_enter_idle_bm) from [<c0601bdc>] (cpuidle_enter_state+0x80/0x3d4)
> > > [<c0601bdc>] (cpuidle_enter_state) from [<c0183b08>] (cpu_startup_entry+0x198/0x3a0)
> > > [<c0183b08>] (cpu_startup_entry) from [<c0b00c0c>] (start_kernel+0x354/0x3c8)
> > > [<c0b00c0c>] (start_kernel) from [<8000807c>] (0x8000807c)  
> > 
> > *Whack* *Whack* *Whack*!!!
> > 
> > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>  
> 
> Or use Steven's identical patch, your choice.  ;-)

I don't care which you use. But if you use mine, you must keep the
*Whack* *Whack* *Whack*!!! in the change log.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Paul E. McKenney April 26, 2016, 8:06 p.m. UTC | #4 
On Tue, Apr 26, 2016 at 03:52:29PM -0400, Steven Rostedt wrote:
> On Tue, 26 Apr 2016 12:51:21 -0700
> "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:
> 
> > On Tue, Apr 26, 2016 at 03:44:14PM -0400, Steven Rostedt wrote:
> > > On Tue, 26 Apr 2016 12:39:50 -0700
> > > Tony Lindgren <tony@atomide.com> wrote:
> > > 
> > >   
> > > > With these omap4 is now OK. But omap3 produces yet another warning,
> > > > See below :)
> > > > 
> > > > Regards,
> > > > 
> > > > Tony
> > > > 
> > > > 8< ------------------
> > > > ===============================
> > > > [ INFO: suspicious RCU usage. ]
> > > > 4.6.0-rc5-next-20160426+ #1114 Not tainted
> > > > -------------------------------
> > > > include/trace/events/clk.h:59 suspicious rcu_dereference_check() usage!
> > > > 
> > > > other info that might help us debug this:
> > > > 
> > > > 
> > > > RCU used illegally from idle CPU!
> > > > rcu_scheduler_active = 1, debug_locks = 0
> > > > RCU used illegally from extended quiescent state!
> > > > 2 locks held by swapper/0/0:
> > > >  #0:  (&oh->hwmod_key#30){......}, at: [<c0121b40>] omap_hwmod_idle+0x18/0x44
> > > >  #1:  (enable_lock){......}, at: [<c0630998>] clk_enable_lock+0x18/0x124
> > > > 
> > > > stack backtrace:
> > > > CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.6.0-rc5-next-20160426+ #1114
> > > > Hardware name: Generic OMAP36xx (Flattened Device Tree)
> > > > [<c0110290>] (unwind_backtrace) from [<c010c3a8>] (show_stack+0x10/0x14)
> > > > [<c010c3a8>] (show_stack) from [<c047fd68>] (dump_stack+0xb0/0xe4)
> > > > [<c047fd68>] (dump_stack) from [<c0631618>] (clk_core_disable+0x17c/0x348)
> > > > [<c0631618>] (clk_core_disable) from [<c0632774>] (clk_disable+0x24/0x30)
> > > > [<c0632774>] (clk_disable) from [<c0120590>] (_disable_clocks+0x18/0x7c)
> > > > [<c0120590>] (_disable_clocks) from [<c0121680>] (_idle+0x12c/0x230)
> > > > [<c0121680>] (_idle) from [<c0121b4c>] (omap_hwmod_idle+0x24/0x44)
> > > > [<c0121b4c>] (omap_hwmod_idle) from [<c0122c24>] (omap_device_idle+0x3c/0x90)
> > > > [<c0122c24>] (omap_device_idle) from [<c052cc00>] (__rpm_callback+0x2c/0x60)
> > > > [<c052cc00>] (__rpm_callback) from [<c052cc54>] (rpm_callback+0x20/0x80)
> > > > [<c052cc54>] (rpm_callback) from [<c052d150>] (rpm_suspend+0x100/0x768)
> > > > [<c052d150>] (rpm_suspend) from [<c052ec58>] (__pm_runtime_suspend+0x64/0x84)
> > > > [<c052ec58>] (__pm_runtime_suspend) from [<c04bf25c>] (omap2_gpio_prepare_for_idle+0x5
> > > > c/0x70)
> > > > [<c04bf25c>] (omap2_gpio_prepare_for_idle) from [<c0125568>] (omap_sram_idle+0x140/0x2
> > > > 44)
> > > > [<c0125568>] (omap_sram_idle) from [<c01269dc>] (omap3_enter_idle_bm+0xfc/0x1ec)
> > > > [<c01269dc>] (omap3_enter_idle_bm) from [<c0601bdc>] (cpuidle_enter_state+0x80/0x3d4)
> > > > [<c0601bdc>] (cpuidle_enter_state) from [<c0183b08>] (cpu_startup_entry+0x198/0x3a0)
> > > > [<c0183b08>] (cpu_startup_entry) from [<c0b00c0c>] (start_kernel+0x354/0x3c8)
> > > > [<c0b00c0c>] (start_kernel) from [<8000807c>] (0x8000807c)  
> > > 
> > > *Whack* *Whack* *Whack*!!!
> > > 
> > > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>  
> > 
> > Or use Steven's identical patch, your choice.  ;-)
> 
> I don't care which you use. But if you use mine, you must keep the
> *Whack* *Whack* *Whack*!!! in the change log.

I included it in the last one.  ;-)

							Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index fb74dc1f7520..4fa43c02d682 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -682,12 +682,12 @@  static void clk_core_disable(struct clk_core *core)
 	if (--core->enable_count > 0)
 		return;
 
-	trace_clk_disable(core);
+	trace_clk_disable_rcuidle(core);
 
 	if (core->ops->disable)
 		core->ops->disable(core->hw);
 
-	trace_clk_disable_complete(core);
+	trace_clk_disable_complete_rcuidle(core);
 
 	clk_core_disable(core->parent);
 }