From patchwork Fri Aug 26 12:23:21 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Utkin X-Patchwork-Id: 9301231 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E73C8607F0 for ; Fri, 26 Aug 2016 12:25:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D83C1295AD for ; Fri, 26 Aug 2016 12:25:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CA52229599; Fri, 26 Aug 2016 12:25:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=2.0 tests=BAYES_00,DKIM_ADSP_ALL, DKIM_SIGNED,FREEMAIL_FROM,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 969AF29599 for ; Fri, 26 Aug 2016 12:25:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751997AbcHZMZW (ORCPT ); Fri, 26 Aug 2016 08:25:22 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:59957 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751014AbcHZMZV (ORCPT ); Fri, 26 Aug 2016 08:25:21 -0400 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 9B0AF206E1; Fri, 26 Aug 2016 08:25:19 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute7.internal (MEProxy); Fri, 26 Aug 2016 08:25:19 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.com; h=cc :date:from:message-id:subject:to:x-sasl-enc:x-sasl-enc; s= mesmtp; bh=3GGdanxv2SgvSaAfQWt8NW5NRMY=; b=TL9jvLZZ1V89n1ujXlZG1 DITr6qFCKNFiZkf39xRROsHb65zfQ2nDcPnr9czjMpIEjvR20PJ94tl0vE8EUahl FV5tHiSpRfOKquYD2DCYHbFq56dQHWZ7cJDwXizy9rwG7ODFCi/oP+6ZADsY2+6g Bc72MEOiHj9PH3EO5Tz+Ys= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:message-id:subject:to :x-sasl-enc:x-sasl-enc; s=smtpout; bh=3GGdanxv2SgvSaAfQWt8NW5NRM Y=; b=UegCiERuUQK5kCYetFZnG5Z9zYAC9w12U2qCGUfKRWAqnnFO+D1Kg1JykA XWoyajsf/PcdBIuEdOML8SXOI4qCdVY/bwlUJc/3DOioNDwUD+hX7t0WsBTaigFC CWL2bzDMH5yw5S4JfgjLxSGSKgg6l0OUHGiAtU34/Nm5Fox8U= X-Sasl-enc: n+2Qq+mQllghIZfLArtD7rxqhU2bpYJIB2tRRwa7ntZc 1472214319 Received: from localhost.localdomain (unknown [195.78.246.16]) by mail.messagingengine.com (Postfix) with ESMTPA id 2DA0ACCE69; Fri, 26 Aug 2016 08:25:17 -0400 (EDT) From: Andrey Utkin To: Tomi Valkeinen , David Airlie , Peter Ujfalusi , Dave Airlie , Peter Chen , Rob Clark , Matthijs van Duin , "Dr. H. Nikolaus Schaller" , Andrew Bradford , kernel@pyra-handheld.com, letux-kernel@openphoenux.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Cc: Andrey Utkin Subject: [PATCH] omapdrm: dss: drop unneeded of_node_put() on ref passed to of_get_next_parent() Date: Fri, 26 Aug 2016 15:23:21 +0300 Message-Id: <20160826122321.4787-1-andrey_utkin@fastmail.com> X-Mailer: git-send-email 2.9.2 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fixes runtime error: [ 8.842806] OF: ERROR: Bad of_node_put() on /encoder/ports/port@1/endpoint [ 8.842812] CPU: 1 PID: 1494 Comm: systemd-udevd Not tainted 4.8.0-rc1-letux-custom #17 [ 8.842815] Hardware name: Generic OMAP5 (Flattened Device Tree) [ 8.842831] [] (unwind_backtrace) from [] (show_stack+0xb/0xc) [ 8.842841] [] (show_stack) from [] (dump_stack+0x6d/0x98) [ 8.842849] [] (dump_stack) from [] (kobject_put+0x93/0x140) [ 8.842935] [] (kobject_put) from [] (omapdss_of_find_source_for_first_ep+0x2e/0x58 [omapdss]) [ 8.843014] [] (omapdss_of_find_source_for_first_ep [omapdss]) from [] (hdmic_probe+0x56/0x170 [connector_hdmi]) [ 8.843030] [] (hdmic_probe [connector_hdmi]) from [] (platform_drv_probe+0x33/0x62) [ 8.843040] [] (platform_drv_probe) from [] (driver_probe_device+0x11f/0x284) [ 8.843049] [] (driver_probe_device) from [] (__driver_attach+0x4d/0x98) [ 8.843057] [] (__driver_attach) from [] (bus_for_each_dev+0x3d/0x46) [ 8.843064] [] (bus_for_each_dev) from [] (bus_add_driver+0xe3/0x170) [ 8.843073] [] (bus_add_driver) from [] (driver_register+0x59/0x88) [ 8.843083] [] (driver_register) from [] (hdmi_connector_driver_init+0xa/0x13 [connector_hdmi]) [ 8.843095] [] (hdmi_connector_driver_init [connector_hdmi]) from [] (do_one_initcall+0xc5/0xf0) [ 8.843108] [] (do_one_initcall) from [] (do_init_module+0x3b/0x318) [ 8.843118] [] (do_init_module) from [] (load_module+0x13f3/0x1722) [ 8.843126] [] (load_module) from [] (SyS_finit_module+0x51/0x74) [ 8.843135] [] (SyS_finit_module) from [] (ret_fast_syscall+0x1/0x18) Signed-off-by: Andrey Utkin --- drivers/gpu/drm/omapdrm/dss/dss-of.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dss-of.c b/drivers/gpu/drm/omapdrm/dss/dss-of.c index e256d87..3e2b191 100644 --- a/drivers/gpu/drm/omapdrm/dss/dss-of.c +++ b/drivers/gpu/drm/omapdrm/dss/dss-of.c @@ -132,7 +132,6 @@ static struct device_node *omapdss_of_get_remote_port(const struct device_node * return NULL; np_parent = of_get_next_parent(np); - of_node_put(np); return np_parent; }