From patchwork Wed Nov 9 14:17:06 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ahaslam@baylibre.com X-Patchwork-Id: 9419425 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B3825601C2 for ; Wed, 9 Nov 2016 14:24:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A760E29350 for ; Wed, 9 Nov 2016 14:24:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9C0C029355; Wed, 9 Nov 2016 14:24:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 164C229350 for ; Wed, 9 Nov 2016 14:24:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753187AbcKIOS7 (ORCPT ); Wed, 9 Nov 2016 09:18:59 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:35119 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751317AbcKIOS5 (ORCPT ); Wed, 9 Nov 2016 09:18:57 -0500 Received: by mail-wm0-f54.google.com with SMTP id a197so309975300wmd.0 for ; Wed, 09 Nov 2016 06:18:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=jtI6a4EewqOfCf6tj7HMbTu7YMDRqfcVovjCRkuvh04=; b=vjaFbVyOb5gJ43HdLJhjD7TuLIUhiIyeGU3JKi/3g8IQzlzXPzjnDg/a6eu0eDcK0s mCdwcimvlnirJQAqqJUfWpq7DUeDbJMU/N0B+fVlpmQvX1+V0Wg9UrQwSgCkk2Okq9Ck HpB6LKuingNUCDc9h3TtQbasq3XqgzSpkvY887tUpq58zgLCD+WY9xdMOCEwEjL2pbVc 5D7+eQ3DdR1kTH+TG3+BzecHtVv8JXDozzS16jCAINmE4VyW7tuR3ap4A7jeIaOJg+KM 2sOspl2gxNE/Es7M92eNdGGlS8L+6Xa5+FAZBV9zlkiYItowb86FNfu+2EYaQY3bKAaQ 1EtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=jtI6a4EewqOfCf6tj7HMbTu7YMDRqfcVovjCRkuvh04=; b=MV4TkYb2HuTOOvlwtV/UEj+9vmJaLM/5LgdQHpqadTIwSEw8EY3jUm/s42+cDjfWRe +t59xXI+nRllrnVin0YLf0tDOTCE/0UvHZtCC3M4SVcmNp9H23diUhQd6Zje0e9pvG9S CAGZJ5HSnlPsHxfbZ82aC26Iq8MZIs5ONycT1znBmh/n9yc1U8gdv+3UViskIuhLF42o 5EVARweisYGscmnMNj3WVRJjX3sE7tAG2ufDIM0ZlbVbRMONxor8QWhrBSLyRmqvrOFt nz3iVeRpX9c6BcoB131ZpruWRICjbIxFd7Cpkd/IYnKBq120JFIpNBHEeNooLb5c1FMF +wqg== X-Gm-Message-State: ABUngvcwO/hb6W7B12EZEOpn8AFBcUHArqz2qXWB0MGYMJBq8jeDtymt1eJZvj4NGT/UqPit X-Received: by 10.28.140.129 with SMTP id o123mr475578wmd.51.1478701135819; Wed, 09 Nov 2016 06:18:55 -0800 (PST) Received: from localhost.localdomain ([90.63.244.31]) by smtp.gmail.com with ESMTPSA id 18sm7282648wmr.5.2016.11.09.06.18.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 09 Nov 2016 06:18:55 -0800 (PST) From: Axel Haslam To: tony@atomide.com, haojian.zhuang@linaro.org, linus.walleij@linaro.org, khilman@baylibre.com, nsekhar@ti.com Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Axel Haslam Subject: [PATCH] pinctrl: single: check for any error when getting rows Date: Wed, 9 Nov 2016 15:17:06 +0100 Message-Id: <20161109141706.12624-1-ahaslam@baylibre.com> X-Mailer: git-send-email 2.10.1.502.g6598894 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP pinctrl_count_index_with_args returns -ENOENT not -EINVAL. The return check would pass, and we would try to kzalloc with a negative error size throwing a warning. Instead of checking for -EINVAL specifically, lets check for any error and avoid negative size allocations. Signed-off-by: Axel Haslam Acked-by: Tony Lindgren --- drivers/pinctrl/pinctrl-single.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c index 539f31c..56e22be 100644 --- a/drivers/pinctrl/pinctrl-single.c +++ b/drivers/pinctrl/pinctrl-single.c @@ -1228,7 +1228,7 @@ static int pcs_parse_bits_in_pinctrl_entry(struct pcs_device *pcs, struct pcs_function *function; rows = pinctrl_count_index_with_args(np, name); - if (rows == -EINVAL) + if (rows < 0) return rows; npins_in_row = pcs->width / pcs->bits_per_pin;