diff mbox

ARM: dts: dra72/1-evm: add pcf8575 used for lcd

Message ID 20170118220241.7868-1-grygorii.strashko@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Grygorii Strashko Jan. 18, 2017, 10:02 p.m. UTC
DRA72 and DRA718 EVM boards has a pcf8575 gpio expander
which is used for the LCD/LEDs and USB vbus detection.
Add the node for the pcf8575.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
 arch/arm/boot/dts/dra71-evm.dts         |  5 +++++
 arch/arm/boot/dts/dra72-evm-common.dtsi | 10 ++++++++++
 2 files changed, 15 insertions(+)

Comments

Tony Lindgren Jan. 20, 2017, 6:47 p.m. UTC | #1
* Grygorii Strashko <grygorii.strashko@ti.com> [170118 14:05]:
> DRA72 and DRA718 EVM boards has a pcf8575 gpio expander
> which is used for the LCD/LEDs and USB vbus detection.
> Add the node for the pcf8575.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>

Hmm should this patch maybe be "From:" Tomi? Usually some change
history is mentioned if you've modified an earlier patch.

Regards,

Tony

> ---
>  arch/arm/boot/dts/dra71-evm.dts         |  5 +++++
>  arch/arm/boot/dts/dra72-evm-common.dtsi | 10 ++++++++++
>  2 files changed, 15 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/dra71-evm.dts b/arch/arm/boot/dts/dra71-evm.dts
> index 2b9a5a8..4d57a55 100644
> --- a/arch/arm/boot/dts/dra71-evm.dts
> +++ b/arch/arm/boot/dts/dra71-evm.dts
> @@ -138,6 +138,11 @@
>  	};
>  };
>  
> +&pcf_lcd {
> +	interrupt-parent = <&gpio7>;
> +	interrupts = <31 IRQ_TYPE_EDGE_FALLING>;
> +};
> +
>  &pcf_gpio_21 {
>  	interrupt-parent = <&gpio7>;
>  	interrupts = <31 IRQ_TYPE_EDGE_FALLING>;
> diff --git a/arch/arm/boot/dts/dra72-evm-common.dtsi b/arch/arm/boot/dts/dra72-evm-common.dtsi
> index e50fbee..2941722 100644
> --- a/arch/arm/boot/dts/dra72-evm-common.dtsi
> +++ b/arch/arm/boot/dts/dra72-evm-common.dtsi
> @@ -216,6 +216,16 @@
>  	status = "okay";
>  	clock-frequency = <400000>;
>  
> +	pcf_lcd: gpio@20 {
> +		compatible = "nxp,pcf8575";
> +		reg = <0x20>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +
> +		interrupt-controller;
> +		#interrupt-cells = <2>;
> +	};
> +
>  	pcf_gpio_21: gpio@21 {
>  		compatible = "ti,pcf8575", "nxp,pcf8575";
>  		reg = <0x21>;
> -- 
> 2.10.1.dirty
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Grygorii Strashko Jan. 20, 2017, 7:42 p.m. UTC | #2
On 01/20/2017 12:47 PM, Tony Lindgren wrote:
> * Grygorii Strashko <grygorii.strashko@ti.com> [170118 14:05]:
>> DRA72 and DRA718 EVM boards has a pcf8575 gpio expander
>> which is used for the LCD/LEDs and USB vbus detection.
>> Add the node for the pcf8575.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>
> Hmm should this patch maybe be "From:" Tomi? Usually some change
> history is mentioned if you've modified an earlier patch.
>

yeh. You are right - Tony added basic node for pcf8575 gpio expander
and then i added IRQ controller support.

i'll resend
diff mbox

Patch

diff --git a/arch/arm/boot/dts/dra71-evm.dts b/arch/arm/boot/dts/dra71-evm.dts
index 2b9a5a8..4d57a55 100644
--- a/arch/arm/boot/dts/dra71-evm.dts
+++ b/arch/arm/boot/dts/dra71-evm.dts
@@ -138,6 +138,11 @@ 
 	};
 };
 
+&pcf_lcd {
+	interrupt-parent = <&gpio7>;
+	interrupts = <31 IRQ_TYPE_EDGE_FALLING>;
+};
+
 &pcf_gpio_21 {
 	interrupt-parent = <&gpio7>;
 	interrupts = <31 IRQ_TYPE_EDGE_FALLING>;
diff --git a/arch/arm/boot/dts/dra72-evm-common.dtsi b/arch/arm/boot/dts/dra72-evm-common.dtsi
index e50fbee..2941722 100644
--- a/arch/arm/boot/dts/dra72-evm-common.dtsi
+++ b/arch/arm/boot/dts/dra72-evm-common.dtsi
@@ -216,6 +216,16 @@ 
 	status = "okay";
 	clock-frequency = <400000>;
 
+	pcf_lcd: gpio@20 {
+		compatible = "nxp,pcf8575";
+		reg = <0x20>;
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
 	pcf_gpio_21: gpio@21 {
 		compatible = "ti,pcf8575", "nxp,pcf8575";
 		reg = <0x21>;