diff mbox

[2/6] ARM: dts: omap4-droid4: Add LCD backlight

Message ID 20170305054359.8293-3-tony@atomide.com (mailing list archive)
State New, archived
Headers show

Commit Message

Tony Lindgren March 5, 2017, 5:43 a.m. UTC
The TI LMU driver has not yet been merged, but the device
tree binding for TI LMU drivers has been acked already
earlier by Rob Herring <robh+dt@kernel.org>. So it should
be safe to apply to cut down the number of pending patches.

Cc: devicetree@vger.kernel.org
Cc: Marcel Partap <mpartap@gmx.net>
Cc: Michael Scott <michael.scott@linaro.org>
Cc: Milo Kim <milo.kim@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 arch/arm/boot/dts/omap4-droid4-xt894.dts | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

Comments

Kim, Milo March 5, 2017, 11:24 p.m. UTC | #1
On 3/5/2017 2:43 PM, Tony Lindgren wrote:
> The TI LMU driver has not yet been merged, but the device
> tree binding for TI LMU drivers has been acked already
> earlier by Rob Herring <robh+dt@kernel.org>. So it should
> be safe to apply to cut down the number of pending patches.

Acked-by: Milo Kim <milo.kim@ti.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sebastian Reichel March 19, 2017, 1:18 a.m. UTC | #2
Hi,

On Sat, Mar 04, 2017 at 09:43:55PM -0800, Tony Lindgren wrote:
> The TI LMU driver has not yet been merged, but the device
> tree binding for TI LMU drivers has been acked already
> earlier by Rob Herring <robh+dt@kernel.org>. So it should
> be safe to apply to cut down the number of pending patches.
> 
> Cc: devicetree@vger.kernel.org
> Cc: Marcel Partap <mpartap@gmx.net>
> Cc: Michael Scott <michael.scott@linaro.org>
> Cc: Milo Kim <milo.kim@ti.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>

Tested-By: Sebastian Reichel <sre@kernel.org>

I had to add https://patchwork.kernel.org/patch/7704601/ in addition
to the patches recently queued into MFD. It would be nice to get that
into 4.12 - @Milo Kim: What's your plan on that patch?

-- Sebastian

> ---
>  arch/arm/boot/dts/omap4-droid4-xt894.dts | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/omap4-droid4-xt894.dts b/arch/arm/boot/dts/omap4-droid4-xt894.dts
> --- a/arch/arm/boot/dts/omap4-droid4-xt894.dts
> +++ b/arch/arm/boot/dts/omap4-droid4-xt894.dts
> @@ -180,6 +180,25 @@
>  	};
>  };
>  
> +&i2c1 {
> +	lm3532@38 {
> +		compatible = "ti,lm3532";
> +		reg = <0x38>;
> +
> +		enable-gpios = <&gpio6 12 GPIO_ACTIVE_HIGH>;
> +
> +		backlight {
> +			compatible = "ti,lm3532-backlight";
> +
> +			lcd {
> +				led-sources = <0 1 2>;
> +				ramp-up-msec = <1>;
> +				ramp-down-msec = <0>;
> +			};
> +		};
> +	};
> +};
> +
>  /*
>   * REVISIT: Add gpio173 reset pin handling to the driver, see gpio-hog above.
>   * If the GPIO reset is used, we probably need to have /lib/firmware/maxtouch.fw
> -- 
> 2.11.1
Kim, Milo March 20, 2017, 2:30 a.m. UTC | #3
Hi Sebastian,

On 3/19/2017 10:18 AM, Sebastian Reichel wrote:
> I had to add https://patchwork.kernel.org/patch/7704601/ in addition
> to the patches recently queued into MFD. It would be nice to get that
> into 4.12 - @Milo Kim: What's your plan on that patch?

Thanks for checking this.

I just sent the patch to backlight subsystem maintainers. Nothing new 
except adding a pwm helper, pwm_apply_args().

Best regards,
Milo
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/omap4-droid4-xt894.dts b/arch/arm/boot/dts/omap4-droid4-xt894.dts
--- a/arch/arm/boot/dts/omap4-droid4-xt894.dts
+++ b/arch/arm/boot/dts/omap4-droid4-xt894.dts
@@ -180,6 +180,25 @@ 
 	};
 };
 
+&i2c1 {
+	lm3532@38 {
+		compatible = "ti,lm3532";
+		reg = <0x38>;
+
+		enable-gpios = <&gpio6 12 GPIO_ACTIVE_HIGH>;
+
+		backlight {
+			compatible = "ti,lm3532-backlight";
+
+			lcd {
+				led-sources = <0 1 2>;
+				ramp-up-msec = <1>;
+				ramp-down-msec = <0>;
+			};
+		};
+	};
+};
+
 /*
  * REVISIT: Add gpio173 reset pin handling to the driver, see gpio-hog above.
  * If the GPIO reset is used, we probably need to have /lib/firmware/maxtouch.fw