From patchwork Tue Aug 22 10:22:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Reichel X-Patchwork-Id: 9914785 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 34C78603F9 for ; Tue, 22 Aug 2017 10:22:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 313052885B for ; Tue, 22 Aug 2017 10:22:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 228162885E; Tue, 22 Aug 2017 10:22:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_TVD_MIME_EPI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 54B642885B for ; Tue, 22 Aug 2017 10:22:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932350AbdHVKWU (ORCPT ); Tue, 22 Aug 2017 06:22:20 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:42033 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932317AbdHVKWT (ORCPT ); Tue, 22 Aug 2017 06:22:19 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: sre) with ESMTPSA id AA07A26C91B Date: Tue, 22 Aug 2017 12:22:14 +0200 From: Sebastian Reichel To: Pavel Machek Cc: pali.rohar@gmail.com, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com, serge@hallyn.com, abcloriens@gmail.com Subject: Re: device tree bindings for lp5523 leds on N950? Message-ID: <20170822102214.pmag4k2dxz4fdvq5@earth> References: <20170814133816.GA24493@amd> <20170815131518.jt4xff6qv4whebul@earth> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170815131518.jt4xff6qv4whebul@earth> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, On Tue, Aug 15, 2017 at 09:15:28AM -0400, Sebastian Reichel wrote: > Hi Pavel, > > On Mon, Aug 14, 2017 at 03:38:16PM +0200, Pavel Machek wrote: > > I'm (still) trying to debug "N950 not booting" situation. I'm stuck > > with black screen, so I thought it would be cool to use RGB led for > > debugging... > > > > Unfortunately, I don't see required dts bindings in the mainline. > > > > Does anyone have that working? > > I have some N950 DTS patches lying around, I think RGB led was one > of them. I'm currently in Canda for a company event without my N950, > but I should be able to send something tested before the weekend. Below is a DTS snippet for N950, that has been tested by me on top of 4.13-rc6. The left and right keyboard LEDs are also debug LEDs for cpu idle modes, so they will be lit without being enabled in lp5523. The status LED of N950 is not RGB, but just white. Also you need this to get the driver loading. Otherwise detection after reset fails even after quite increases waiting times. Looks like the lp5523 reset (which is not properly Ack'd by the device) breaks the omap-i2c state horribly. -- Sebastian ---------- &i2c2 { rgb-led@32 { compatible = "national,lp5523"; reg = <0x32>; enable-gpio = <&gpio2 9 GPIO_ACTIVE_HIGH>; /* 41 */ clock-mode = /bits/ 8 <2>; /* external */ chan0 { chan-name = "lp5523:kb5"; /* Keyboard ooooox */ led-cur = /bits/ 8 <50>; max-cur = /bits/ 8 <130>; }; chan1 { chan-name = "lp5523:kb4"; /* Keyboard ooooxo */ led-cur = /bits/ 8 <50>; max-cur = /bits/ 8 <130>; }; chan2 { chan-name = "lp5523:kb3"; /* Keyboard oooxoo */ led-cur = /bits/ 8 <50>; max-cur = /bits/ 8 <130>; }; chan3 { chan-name = "lp5523:kb2"; /* Keyboard ooxooo */ led-cur = /bits/ 8 <50>; max-cur = /bits/ 8 <130>; }; chan4 { chan-name = "lp5523:kb1"; /* Keyboard oxoooo */ led-cur = /bits/ 8 <50>; max-cur = /bits/ 8 <130>; }; chan5 { chan-name = "lp5523:kb0"; /* Keyboard xooooo */ led-cur = /bits/ 8 <50>; max-cur = /bits/ 8 <130>; }; chan6 { led-cur = /bits/ 8 <0>; max-cur = /bits/ 8 <0>; }; chan7 { led-cur = /bits/ 8 <0>; max-cur = /bits/ 8 <0>; }; chan8 { chan-name = "lp5523:status-led"; led-cur = /bits/ 8 <50>; max-cur = /bits/ 8 <130>; }; }; }; --- a/drivers/leds/leds-lp55xx-common.c +++ b/drivers/leds/leds-lp55xx-common.c @@ -413,7 +413,7 @@ int lp55xx_init_device(struct lp55xx_chip *chip) usleep_range(1000, 2000); /* 500us abs min. */ } - lp55xx_reset_device(chip); + //lp55xx_reset_device(chip); // FIXME: breaks omap-i2c /* * Exact value is not available. 10 - 20ms