| Message ID | 20170828211918.11573-12-tony@atomide.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 2017-08-29 00:19, Tony Lindgren wrote: > On omap4 we're missing the mcasp node with it's related "ti,hwmods" > property that the SoC interconnect code needs. > > Note that this will only show up as a bug with "doesn't have > mpu register target base" boot errors when the legacy platform > data is removed. > > Cc: Liam Girdwood <lgirdwood@gmail.com> > Cc: Mark Brown <broonie@kernel.org> > Cc: Peter Ujfalusi <peter.ujfalusi@ti.com> > Signed-off-by: Tony Lindgren <tony@atomide.com> > --- > Documentation/devicetree/bindings/sound/davinci-mcasp-audio.txt | 1 + > arch/arm/boot/dts/omap4.dtsi | 9 +++++++++ > 2 files changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.txt b/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.txt > --- a/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.txt > +++ b/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.txt > @@ -6,6 +6,7 @@ Required properties: > "ti,da830-mcasp-audio" : for both DA830 & DA850 platforms > "ti,am33xx-mcasp-audio" : for AM33xx platforms (AM33xx, AM43xx, TI81xx) > "ti,dra7-mcasp-audio" : for DRA7xx platforms > + "ti,omap4-mcasp-audio" : for OMAP4 platforms > > - reg : Should contain reg specifiers for the entries in the reg-names property. > - reg-names : Should contain: > diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi > --- a/arch/arm/boot/dts/omap4.dtsi > +++ b/arch/arm/boot/dts/omap4.dtsi > @@ -750,6 +750,15 @@ > status = "disabled"; > }; > > + mcasp: mcasp@40128000 { > + compatible = "ti,omap4-mcasp-audio"; > + reg = <0x40128000 0x400>, /* MPU private access */ > + <0x49028000 0x400>; /* L3 Interconnect */ > + reg-names = "mpu", "dma"; > + interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>; interrupt-names = "tx"; Can you add the DMA as well: dmas = <&sdma 8>; dma-names = "tx"; The RX of McASP is disabled, no RX DMA request. > + ti,hwmods = "mcasp"; > + }; > + > slimbus1: slimbus@4012c000 { > compatible = "ti,omap4-slimbus"; > reg = <0x4012c000 0x400>, /* MPU private access */ > - Péter -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.txt b/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.txt --- a/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.txt +++ b/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.txt @@ -6,6 +6,7 @@ Required properties: "ti,da830-mcasp-audio" : for both DA830 & DA850 platforms "ti,am33xx-mcasp-audio" : for AM33xx platforms (AM33xx, AM43xx, TI81xx) "ti,dra7-mcasp-audio" : for DRA7xx platforms + "ti,omap4-mcasp-audio" : for OMAP4 platforms - reg : Should contain reg specifiers for the entries in the reg-names property. - reg-names : Should contain: diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi --- a/arch/arm/boot/dts/omap4.dtsi +++ b/arch/arm/boot/dts/omap4.dtsi @@ -750,6 +750,15 @@ status = "disabled"; }; + mcasp: mcasp@40128000 { + compatible = "ti,omap4-mcasp-audio"; + reg = <0x40128000 0x400>, /* MPU private access */ + <0x49028000 0x400>; /* L3 Interconnect */ + reg-names = "mpu", "dma"; + interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>; + ti,hwmods = "mcasp"; + }; + slimbus1: slimbus@4012c000 { compatible = "ti,omap4-slimbus"; reg = <0x4012c000 0x400>, /* MPU private access */
On omap4 we're missing the mcasp node with it's related "ti,hwmods" property that the SoC interconnect code needs. Note that this will only show up as a bug with "doesn't have mpu register target base" boot errors when the legacy platform data is removed. Cc: Liam Girdwood <lgirdwood@gmail.com> Cc: Mark Brown <broonie@kernel.org> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com> Signed-off-by: Tony Lindgren <tony@atomide.com> --- Documentation/devicetree/bindings/sound/davinci-mcasp-audio.txt | 1 + arch/arm/boot/dts/omap4.dtsi | 9 +++++++++ 2 files changed, 10 insertions(+)