From patchwork Sat Oct 14 07:26:59 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ingo Molnar X-Patchwork-Id: 10006273 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9EB4260230 for ; Sat, 14 Oct 2017 07:27:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8D9C7290F6 for ; Sat, 14 Oct 2017 07:27:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 824F2291B8; Sat, 14 Oct 2017 07:27:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 21AF2290F6 for ; Sat, 14 Oct 2017 07:27:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751743AbdJNH1G (ORCPT ); Sat, 14 Oct 2017 03:27:06 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:37345 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751737AbdJNH1E (ORCPT ); Sat, 14 Oct 2017 03:27:04 -0400 Received: by mail-wr0-f196.google.com with SMTP id k15so1949754wrc.4; Sat, 14 Oct 2017 00:27:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZDUXm830bwik+hDfm0EbT5r6cnBputUMnrAnVKdpr+c=; b=EqY+3ZhQCqNleqMLBMXI46F1cRYouRtTcxrutZM5QTYz0muIz0sr8jJEX5y5MHkPoq aeH/B0OeTDXM55GPw+8kSR/F9G9TxdY4s8+pABbhSRnXs5yMQsuH92+9PZRSeO4S6WA9 LDiKHuNMZ58n7DrSUkWAc9J6GmneiZPxJarP70BcraU+YoM0Wt9wBl2WAe3bwrDXPpnd H4MJSwlSXlGZv3HxEqCZ0TrArZURuOBJqHLkW7Ge+y5tU9/c+WcGJhQxtMvUnx7QC613 JZeVS1Mjq1jk7B57E7m+yImtZDrvWwzugQETrWJ01JxcUy6zcmosL7YFpjeGlpC9MjpQ Bztw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=ZDUXm830bwik+hDfm0EbT5r6cnBputUMnrAnVKdpr+c=; b=iIUW1UaTNnutlzyLGcd6Csv/qZg1HQuqUB5wqH7YKHFy+FpAKLkN41j535m+E8McGV ad8WEVEWNlt8a6jDHzx1qyEd0ilnFIvhoXEISgiy70S9yaGRtcLM3fUIKtQxOq2mPYLM AAV5TXdLty6jPH43iv32uFBp0pnzf2zJKCtW/k3eyygg3yj0g6rwGvuG93wqEtRQ0cVQ srMSwfZ3lpSMKiJrv399PpHRDeoiQY4i6fo8bDYFlQSBPB0XyoEy/rhg0mddxOFIAVjJ 0aqB4n61Lxo+mLFuHQQNT3jJDKut4Y/LrlavIf7U5KTZMccnsC2FLl8/GlbreFczhZsX wpdg== X-Gm-Message-State: AMCzsaUWitsO5jbnh/i+3zL7A+972CYF/OY05cgIVCD76WSEvxWztmOz CEWjPtpbktIgO18JtQ9XMtE= X-Google-Smtp-Source: AOwi7QBzc/lnB/wzKmerzbCgHCdLb+sUhli89tc4WaBLB4+EjBQDtir6HOPvyxNkWmK+ukpKQp+RlQ== X-Received: by 10.223.164.206 with SMTP id h14mr3041053wrb.25.1507966022973; Sat, 14 Oct 2017 00:27:02 -0700 (PDT) Received: from gmail.com (2E8B0CD5.catv.pool.telekom.hu. [46.139.12.213]) by smtp.gmail.com with ESMTPSA id 9sm3297919wml.24.2017.10.14.00.27.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 14 Oct 2017 00:27:01 -0700 (PDT) Date: Sat, 14 Oct 2017 09:26:59 +0200 From: Ingo Molnar To: Johan Hovold Cc: Byungchul Park , Peter Zijlstra , linux-kernel@vger.kernel.org, tglx@linutronix.de, linux-mm@kvack.org, kernel-team@lge.com, Tony Lindgren , Arnd Bergmann , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: Dramatic lockdep slowdown in 4.14 Message-ID: <20171014072659.f2yr6mhm5ha3eou7@gmail.com> References: <20171013090333.GA17356@localhost> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20171013090333.GA17356@localhost> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP * Johan Hovold wrote: > Hi, > > I had noticed that the BeagleBone Black boot time appeared to have > increased significantly with 4.14 and yesterday I finally had time to > investigate it. > > Boot time (from "Linux version" to login prompt) had in fact doubled > since 4.13 where it took 17 seconds (with my current config) compared to > the 35 seconds I now see with 4.14-rc4. > > I quick bisect pointed to lockdep and specifically the following commit: > > 28a903f63ec0 ("locking/lockdep: Handle non(or multi)-acquisition > of a crosslock") > > which I've verified is the commit which doubled the boot time (compared > to 28a903f63ec0^) (added by lockdep crossrelease series [1]). > > I also verified that simply disabling CONFIG_PROVE_LOCKING on 4.14-rc4 > brought boot time down to about 14 seconds. > > Now since it's lockdep I guess this can't really be considered a > regression if these changes did improve lockdep correctness, but still, > this dramatic slow down essentially forces me to disable PROVE_LOCKING > by default on this system. > > Is this lockdep slowdown expected and desirable? It's not desirable at all. Does the patch below fix the regression for you - or does the introduction and handling of ->nr_acquire hurt as well? Thanks, Ingo --- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ====================> lib/Kconfig.debug | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index c6401d325b0e..f5b40c1668ea 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -1138,8 +1138,8 @@ config PROVE_LOCKING select DEBUG_MUTEXES select DEBUG_RT_MUTEXES if RT_MUTEXES select DEBUG_LOCK_ALLOC - select LOCKDEP_CROSSRELEASE - select LOCKDEP_COMPLETIONS +# select LOCKDEP_CROSSRELEASE +# select LOCKDEP_COMPLETIONS select TRACE_IRQFLAGS default n help