| Message ID | 20171114060648.frwveus2pjpx5idw@mwanda (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* Dan Carpenter <dan.carpenter@oracle.com> [171113 22:10]: > We need to set the error code if omap_device_alloc() fails. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > diff --git a/arch/arm/mach-omap2/omap_device.c b/arch/arm/mach-omap2/omap_device.c > index 184acd95c216..f0388058b7da 100644 > --- a/arch/arm/mach-omap2/omap_device.c > +++ b/arch/arm/mach-omap2/omap_device.c > @@ -514,8 +514,10 @@ struct platform_device __init *omap_device_build(const char *pdev_name, > goto odbs_exit1; > > od = omap_device_alloc(pdev, &oh, 1); > - if (IS_ERR(od)) > + if (IS_ERR(od)) { > + ret = PTR_ERR(od); > goto odbs_exit1; > + } > > ret = platform_device_add_data(pdev, pdata, pdata_len); > if (ret) Applying into omap-for-v4.15/fixes thanks. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-omap2/omap_device.c b/arch/arm/mach-omap2/omap_device.c index 184acd95c216..f0388058b7da 100644 --- a/arch/arm/mach-omap2/omap_device.c +++ b/arch/arm/mach-omap2/omap_device.c @@ -514,8 +514,10 @@ struct platform_device __init *omap_device_build(const char *pdev_name, goto odbs_exit1; od = omap_device_alloc(pdev, &oh, 1); - if (IS_ERR(od)) + if (IS_ERR(od)) { + ret = PTR_ERR(od); goto odbs_exit1; + } ret = platform_device_add_data(pdev, pdata, pdata_len); if (ret)
We need to set the error code if omap_device_alloc() fails. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html