From patchwork Thu Jan 18 21:13:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ladislav Michl X-Patchwork-Id: 10174105 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8ABFF60230 for ; Thu, 18 Jan 2018 21:13:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7E14D28469 for ; Thu, 18 Jan 2018 21:13:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 72AA328524; Thu, 18 Jan 2018 21:13:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 68E7D28469 for ; Thu, 18 Jan 2018 21:13:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753189AbeARVNV (ORCPT ); Thu, 18 Jan 2018 16:13:21 -0500 Received: from eddie.linux-mips.org ([148.251.95.138]:36938 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752100AbeARVNV (ORCPT ); Thu, 18 Jan 2018 16:13:21 -0500 Received: (from localhost user: 'ladis' uid#1021 fake: STDIN (ladis@eddie.linux-mips.org)) by eddie.linux-mips.org id S23990424AbeARVNTU7MmN (ORCPT + 1 other); Thu, 18 Jan 2018 22:13:19 +0100 Date: Thu, 18 Jan 2018 22:13:18 +0100 From: Ladislav Michl To: linux-usb@vger.kernel.org, linux-omap@vger.kernel.org Cc: Alan Stern , Greg Kroah-Hartman Subject: [PATCH v4] usb: ehci-omap: don't complain on -EPROBE_DEFER when no PHY found Message-ID: <20180118211317.GA27821@lenoch> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Don't complain on -EPROBE_DEFER when no PHY found, the driver probe will be retried later. Signed-off-by: Ladislav Michl Acked-by: Tony Lindgren Acked-by: Roger Quadros Acked-by: Alan Stern --- Changes: - v2: None, just added Tony's ack - v3: Fixed commit message typo spotted by Jaejoong Kim, added Roger's ack - v4: Do not break printk string, Alan's ack. I hope he forgives me changing error message a bit. IMHO shorter with the same meaning. (this patch gained unbelievable lines_changed/versions ratio ;-)) drivers/usb/host/ehci-omap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c index 854b146a457d..8d8bafc70c1f 100644 --- a/drivers/usb/host/ehci-omap.c +++ b/drivers/usb/host/ehci-omap.c @@ -167,7 +167,8 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev) continue; ret = PTR_ERR(phy); - dev_err(dev, "Can't get PHY device for port %d: %d\n", + if (ret != -EPROBE_DEFER) + dev_err(dev, "Can't get PHY for port %d: %d\n", i, ret); goto err_phy; }