From patchwork Fri Feb 16 22:30:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Machek X-Patchwork-Id: 10225851 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E3B4F603EE for ; Fri, 16 Feb 2018 22:30:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C397429543 for ; Fri, 16 Feb 2018 22:30:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B677329683; Fri, 16 Feb 2018 22:30:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_TVD_MIME_EPI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AE70429543 for ; Fri, 16 Feb 2018 22:30:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750734AbeBPWan (ORCPT ); Fri, 16 Feb 2018 17:30:43 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:51237 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750727AbeBPWam (ORCPT ); Fri, 16 Feb 2018 17:30:42 -0500 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id F013080179; Fri, 16 Feb 2018 23:30:40 +0100 (CET) Date: Fri, 16 Feb 2018 23:30:41 +0100 From: Pavel Machek To: pali.rohar@gmail.com, sre@kernel.org, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com, serge@hallyn.com, abcloriens@gmail.com, clayton@craftyguy.net, martijn@brixit.nl, sakari.ailus@linux.intel.com, Filip =?utf-8?Q?Matijevi=C4=87?= Subject: Nokia N900 camera in v4.16-rc1: ready for testing? Message-ID: <20180216223041.GA16010@amd> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi! Camera should work on N900, with v4.16-rc1. Autofocus should work; flash is in the queue. This patch is needed for non-square image. Patched v4l-utils is very much recommened for taking photos. Sakari: any ideas about this one? This is the bug I showed you in Prague... Best regards, Pavel commit b685b7b98fc50149779416b33d234e4f9ff6ad0e Author: Pavel Date: Mon Feb 13 21:26:51 2017 +0100 omap3isp: fix VP2SDR bit so capture (not preview) works This is neccessary for capture (not preview) to work properly on N900. Why is unknown. diff --git a/drivers/media/platform/omap3isp/ispccdc.c b/drivers/media/platform/omap3isp/ispccdc.c index b66276a..6435857 100644 --- a/drivers/media/platform/omap3isp/ispccdc.c +++ b/drivers/media/platform/omap3isp/ispccdc.c @@ -1182,7 +1182,8 @@ static void ccdc_configure(struct isp_ccdc_device *ccdc) /* Use the raw, unprocessed data when writing to memory. The H3A and * histogram modules are still fed with lens shading corrected data. */ - syn_mode &= ~ISPCCDC_SYN_MODE_VP2SDR; +// syn_mode &= ~ISPCCDC_SYN_MODE_VP2SDR; + syn_mode |= ISPCCDC_SYN_MODE_VP2SDR; if (ccdc->output & CCDC_OUTPUT_MEMORY) syn_mode |= ISPCCDC_SYN_MODE_WEN; @@ -1249,6 +1250,8 @@ static void ccdc_configure(struct isp_ccdc_device *ccdc) << ISPCCDC_VERT_LINES_NLV_SHIFT, OMAP3_ISP_IOMEM_CCDC, ISPCCDC_VERT_LINES); + printk("configuring for %d(%d)x%d\n", crop->width, ccdc->video_out.bpl_value, crop->height); + ccdc_config_outlineoffset(ccdc, ccdc->video_out.bpl_value, format->field);