From patchwork Thu May 3 19:38:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Machek X-Patchwork-Id: 10379033 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5689060159 for ; Thu, 3 May 2018 19:38:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4ABEF29253 for ; Thu, 3 May 2018 19:38:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3F67329265; Thu, 3 May 2018 19:38:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,T_TVD_MIME_EPI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A829329253 for ; Thu, 3 May 2018 19:38:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751133AbeECTik (ORCPT ); Thu, 3 May 2018 15:38:40 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:58345 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751125AbeECTij (ORCPT ); Thu, 3 May 2018 15:38:39 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 8CDD1804E5; Thu, 3 May 2018 21:38:38 +0200 (CEST) Date: Thu, 3 May 2018 21:38:38 +0200 From: Pavel Machek To: Tony Lindgren Cc: kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, sre@kernel.org, nekit1000@gmail.com, mpartap@gmx.net, merlijn@wizzup.org Subject: Re: Droid 4: very confusing config around OHCI_OMAP3_HCD Message-ID: <20180503193837.GC32572@amd> References: <20180503192510.GB32572@amd> <20180503192838.GY98604@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180503192838.GY98604@atomide.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu 2018-05-03 12:28:38, Tony Lindgren wrote: > * Pavel Machek [180503 19:27]: > > Hi! > > > > For power management experiments, I tried > > > > CONFIG_USB_OHCI_HCD=y > > CONFIG_USB_OHCI_HCD_OMAP3=m > > CONFIG_USB_OHCI_HCD_PLATFORM=y > > > > and could not find resulting .ko. > > > > Help text says: > > > > CONFIG_USB_OHCI_HCD_OMAP3: > > > > This option is deprecated now and the driver was removed, use > > USB_OHCI_HCD_PLATFORM instead. > > > > Enables support for the on-chip OHCI controller on > > OMAP3 and later chips. > > > > Which may partly explain it. But if the option no longer does > > anything, why keep it? Certainly second part is confusing if option is > > NOP... > > Yeah it's ohci-platform now, I think we decided to keep the old one > around to avoid breaking people's .config files for booting rather > than silently fail. Ok, what about this? (Should I do the same for the other drivers?) Or at least put (DEPRECATED) as other drivers do? Situation is quite confusing if you already have PLATFORM=y. OMAP=m can be selected, but nothing happens. diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index 5d958da..67c151a 100644 --- a/drivers/usb/host/Kconfig +++ b/drivers/usb/host/Kconfig @@ -455,7 +455,7 @@ config USB_OHCI_HCD_AT91 Atmel chips. config USB_OHCI_HCD_OMAP3 - tristate "OHCI support for OMAP3 and later chips" + tristate "dummy option for backwards compatibility" depends on (ARCH_OMAP3 || ARCH_OMAP4 || SOC_OMAP5) select USB_OHCI_HCD_PLATFORM default y @@ -463,9 +463,6 @@ config USB_OHCI_HCD_OMAP3 This option is deprecated now and the driver was removed, use USB_OHCI_HCD_PLATFORM instead. - Enables support for the on-chip OHCI controller on - OMAP3 and later chips. - config USB_OHCI_HCD_DAVINCI tristate "OHCI support for TI DaVinci DA8xx" depends on ARCH_DAVINCI_DA8XX