| Message ID | 20180621171645.29734-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Please, add netdev@vger.kernel.org for the future On 06/21/2018 12:16 PM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The function cpdma_desc_pool_create is local to the source and does not > need to be in global scope, so make it static. > > Cleans up sparse warning: > warning: symbol 'cpdma_desc_pool_create' was not declared. Should it > be static? > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/net/ethernet/ti/davinci_cpdma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c > index cdbddf16dd29..4f1267477aa4 100644 > --- a/drivers/net/ethernet/ti/davinci_cpdma.c > +++ b/drivers/net/ethernet/ti/davinci_cpdma.c > @@ -205,7 +205,7 @@ static void cpdma_desc_pool_destroy(struct cpdma_ctlr *ctlr) > * devices (e.g. cpsw switches) use plain old memory. Descriptor pools > * abstract out these details > */ > -int cpdma_desc_pool_create(struct cpdma_ctlr *ctlr) > +static int cpdma_desc_pool_create(struct cpdma_ctlr *ctlr) > { > struct cpdma_params *cpdma_params = &ctlr->params; > struct cpdma_desc_pool *pool; > Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
From: Colin King <colin.king@canonical.com> Date: Thu, 21 Jun 2018 18:16:45 +0100 > From: Colin Ian King <colin.king@canonical.com> > > The function cpdma_desc_pool_create is local to the source and does not > need to be in global scope, so make it static. > > Cleans up sparse warning: > warning: symbol 'cpdma_desc_pool_create' was not declared. Should it > be static? > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Applied, thanks Colin. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c index cdbddf16dd29..4f1267477aa4 100644 --- a/drivers/net/ethernet/ti/davinci_cpdma.c +++ b/drivers/net/ethernet/ti/davinci_cpdma.c @@ -205,7 +205,7 @@ static void cpdma_desc_pool_destroy(struct cpdma_ctlr *ctlr) * devices (e.g. cpsw switches) use plain old memory. Descriptor pools * abstract out these details */ -int cpdma_desc_pool_create(struct cpdma_ctlr *ctlr) +static int cpdma_desc_pool_create(struct cpdma_ctlr *ctlr) { struct cpdma_params *cpdma_params = &ctlr->params; struct cpdma_desc_pool *pool;