| Message ID | 20180928203457.121761-1-tony@atomide.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: am335x: Replace remaining legacy phy_id with phy-handle | expand |
On 09/28/2018 03:34 PM, Tony Lindgren wrote: > Looks like we still have two instances of phy_handle that did not > get update by Grygorii's series. Let's replace these too with > standard phy-handle. > > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Grygorii Strashko <grygorii.strashko@ti.com> > Cc: Koen Kooi <koen@dominion.thruhere.net> > Cc: Neeraj Dantu <dantuguf14105@gmail.com> > Reported-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Tony Lindgren <tony@atomide.com> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com> > --- > arch/arm/boot/dts/am335x-osd3358-sm-red.dts | 6 +++++- > arch/arm/boot/dts/am335x-sancloud-bbe.dts | 6 +++++- > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/am335x-osd3358-sm-red.dts b/arch/arm/boot/dts/am335x-osd3358-sm-red.dts > --- a/arch/arm/boot/dts/am335x-osd3358-sm-red.dts > +++ b/arch/arm/boot/dts/am335x-osd3358-sm-red.dts > @@ -424,7 +424,7 @@ > }; > > &cpsw_emac0 { > - phy_id = <&davinci_mdio>, <4>; > + phy-handle = <ðphy0>; > phy-mode = "rgmii-txid"; > }; > > @@ -441,6 +441,10 @@ > pinctrl-0 = <&davinci_mdio_default>; > pinctrl-1 = <&davinci_mdio_sleep>; > status = "okay"; > + > + ethphy0: ethernet-phy@4 { > + reg = <4>; > + }; > }; > > &mmc1 { > diff --git a/arch/arm/boot/dts/am335x-sancloud-bbe.dts b/arch/arm/boot/dts/am335x-sancloud-bbe.dts > --- a/arch/arm/boot/dts/am335x-sancloud-bbe.dts > +++ b/arch/arm/boot/dts/am335x-sancloud-bbe.dts > @@ -103,10 +103,14 @@ > pinctrl-0 = <&davinci_mdio_default>; > pinctrl-1 = <&davinci_mdio_sleep>; > status = "okay"; > + > + ethphy0: ethernet-phy@0 { > + reg = <0>; > + }; > }; > > &cpsw_emac0 { > - phy_id = <&davinci_mdio>, <0>; > + phy-handle = <ðphy0>; > phy-mode = "rgmii-txid"; > }; > >
> Op 28 sep. 2018, om 22:34 heeft Tony Lindgren <tony@atomide.com> het volgende geschreven: > > Looks like we still have two instances of phy_handle that did not > get update by Grygorii's series. Let's replace these too with > standard phy-handle. > > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Grygorii Strashko <grygorii.strashko@ti.com> > Cc: Koen Kooi <koen@dominion.thruhere.net> > Cc: Neeraj Dantu <dantuguf14105@gmail.com> > Reported-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Tony Lindgren <tony@atomide.com> Thanks for taking care of this! Acked-by: Koen Kooi <koen@dominion.thruhere.net> > --- > arch/arm/boot/dts/am335x-osd3358-sm-red.dts | 6 +++++- > arch/arm/boot/dts/am335x-sancloud-bbe.dts | 6 +++++- > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/am335x-osd3358-sm-red.dts b/arch/arm/boot/dts/am335x-osd3358-sm-red.dts > --- a/arch/arm/boot/dts/am335x-osd3358-sm-red.dts > +++ b/arch/arm/boot/dts/am335x-osd3358-sm-red.dts > @@ -424,7 +424,7 @@ > }; > > &cpsw_emac0 { > - phy_id = <&davinci_mdio>, <4>; > + phy-handle = <ðphy0>; > phy-mode = "rgmii-txid"; > }; > > @@ -441,6 +441,10 @@ > pinctrl-0 = <&davinci_mdio_default>; > pinctrl-1 = <&davinci_mdio_sleep>; > status = "okay"; > + > + ethphy0: ethernet-phy@4 { > + reg = <4>; > + }; > }; > > &mmc1 { > diff --git a/arch/arm/boot/dts/am335x-sancloud-bbe.dts b/arch/arm/boot/dts/am335x-sancloud-bbe.dts > --- a/arch/arm/boot/dts/am335x-sancloud-bbe.dts > +++ b/arch/arm/boot/dts/am335x-sancloud-bbe.dts > @@ -103,10 +103,14 @@ > pinctrl-0 = <&davinci_mdio_default>; > pinctrl-1 = <&davinci_mdio_sleep>; > status = "okay"; > + > + ethphy0: ethernet-phy@0 { > + reg = <0>; > + }; > }; > > &cpsw_emac0 { > - phy_id = <&davinci_mdio>, <0>; > + phy-handle = <ðphy0>; > phy-mode = "rgmii-txid"; > }; > > -- > 2.19.0
diff --git a/arch/arm/boot/dts/am335x-osd3358-sm-red.dts b/arch/arm/boot/dts/am335x-osd3358-sm-red.dts --- a/arch/arm/boot/dts/am335x-osd3358-sm-red.dts +++ b/arch/arm/boot/dts/am335x-osd3358-sm-red.dts @@ -424,7 +424,7 @@ }; &cpsw_emac0 { - phy_id = <&davinci_mdio>, <4>; + phy-handle = <ðphy0>; phy-mode = "rgmii-txid"; }; @@ -441,6 +441,10 @@ pinctrl-0 = <&davinci_mdio_default>; pinctrl-1 = <&davinci_mdio_sleep>; status = "okay"; + + ethphy0: ethernet-phy@4 { + reg = <4>; + }; }; &mmc1 { diff --git a/arch/arm/boot/dts/am335x-sancloud-bbe.dts b/arch/arm/boot/dts/am335x-sancloud-bbe.dts --- a/arch/arm/boot/dts/am335x-sancloud-bbe.dts +++ b/arch/arm/boot/dts/am335x-sancloud-bbe.dts @@ -103,10 +103,14 @@ pinctrl-0 = <&davinci_mdio_default>; pinctrl-1 = <&davinci_mdio_sleep>; status = "okay"; + + ethphy0: ethernet-phy@0 { + reg = <0>; + }; }; &cpsw_emac0 { - phy_id = <&davinci_mdio>, <0>; + phy-handle = <ðphy0>; phy-mode = "rgmii-txid"; };
Looks like we still have two instances of phy_handle that did not get update by Grygorii's series. Let's replace these too with standard phy-handle. Cc: Arnd Bergmann <arnd@arndb.de> Cc: Grygorii Strashko <grygorii.strashko@ti.com> Cc: Koen Kooi <koen@dominion.thruhere.net> Cc: Neeraj Dantu <dantuguf14105@gmail.com> Reported-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Tony Lindgren <tony@atomide.com> --- arch/arm/boot/dts/am335x-osd3358-sm-red.dts | 6 +++++- arch/arm/boot/dts/am335x-sancloud-bbe.dts | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-)