From patchwork Sat Nov 10 11:16:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 10677075 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 92BBF175A for ; Sat, 10 Nov 2018 11:16:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7748629DC9 for ; Sat, 10 Nov 2018 11:16:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6B8782C98E; Sat, 10 Nov 2018 11:16:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B5D0D29DC9 for ; Sat, 10 Nov 2018 11:16:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729022AbeKJVBY (ORCPT ); Sat, 10 Nov 2018 16:01:24 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:39110 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728910AbeKJVBY (ORCPT ); Sat, 10 Nov 2018 16:01:24 -0500 Received: from avalon.ideasonboard.com (unknown [212.213.198.112]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A9D6E1334; Sat, 10 Nov 2018 12:16:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1541848604; bh=KDrZZdypZXujCLXiUaE9xAlrMOctYHjX3vey/Qazfu0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sKqkm+jVml4tx8F96ypcNE0Y3bOmgNn8/+gUMQRkrUUUWNZ5pkdU1gIaQtVFVSMut Xg/MnAZroNzj3cgc24ISJGVW3dWgAefgloLfemPFuOIcvcVSx6lhTmxHPWCJtfiRQJ 2QdZx95zvg/hArRMfePtFoJxd4mU+1KNvuXinew8= From: Laurent Pinchart To: dri-devel@lists.freedesktop.org Cc: Tony Lindgren , Tomi Valkeinen , linux-omap@vger.kernel.org Subject: [PATCH v3 3/4] drm/omap: dsi: Ensure the device is active during probe Date: Sat, 10 Nov 2018 13:16:53 +0200 Message-Id: <20181110111654.4387-4-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20181110111654.4387-1-laurent.pinchart@ideasonboard.com> References: <20181110111654.4387-1-laurent.pinchart@ideasonboard.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The probe function performs hardware access to read the number of supported data lanes from a configuration register and thus requires the device to be active. Ensure this by surrounding the access with dsi_runtime_get() and dsi_runtime_put() calls. Fixes: edb715dffdee ("drm/omap: dss: dsi: Move initialization code from bind to probe") Signed-off-by: Laurent Pinchart Acked-by: Tony Lindgren Reviewed-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/dss/dsi.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c index 394c129cfb3b..b9d5ad7e67d8 100644 --- a/drivers/gpu/drm/omapdrm/dss/dsi.c +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c @@ -5409,11 +5409,14 @@ static int dsi_probe(struct platform_device *pdev) /* DSI on OMAP3 doesn't have register DSI_GNQ, set number * of data to 3 by default */ - if (dsi->data->quirks & DSI_QUIRK_GNQ) + if (dsi->data->quirks & DSI_QUIRK_GNQ) { + dsi_runtime_get(dsi); /* NB_DATA_LANES */ dsi->num_lanes_supported = 1 + REG_GET(dsi, DSI_GNQ, 11, 9); - else + dsi_runtime_put(dsi); + } else { dsi->num_lanes_supported = 3; + } r = dsi_init_output(dsi); if (r)