From patchwork Wed Feb 13 08:47:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 10809335 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1574C13BF for ; Wed, 13 Feb 2019 08:47:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F40412B272 for ; Wed, 13 Feb 2019 08:47:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E27262B29A; Wed, 13 Feb 2019 08:47:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8723B2B272 for ; Wed, 13 Feb 2019 08:47:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390812AbfBMIr2 (ORCPT ); Wed, 13 Feb 2019 03:47:28 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:37616 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389794AbfBMIr2 (ORCPT ); Wed, 13 Feb 2019 03:47:28 -0500 Received: by mail-lj1-f195.google.com with SMTP id r10-v6so1287704ljj.4 for ; Wed, 13 Feb 2019 00:47:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bQKwEsId6JLgTtjw3Rjr7HrL/WSfNzzQCt6QFtE+6CE=; b=huPTkm7YuTfgMiO3pS+jCGn8NhUCcSn8F3KQWlpn+sfAWdE03+0xZExbkXBqTQQ4Ms wSC5XGBYQ7n/wYVCJZxHRgNxIs0hdbjkEbiIaoincu8wJFzdVEshpaJd84a9VZnaoASY Wa6ExZJisdmciQHpsAk7/zKJeXa2gjhMLdH+QUhaJbDwDTUyBIj0opR/VRuerdRwNGyj N9X+1nLZ5zI6Zxcmf7tfsnG2iWQ7k4zFcRbQzQek1to6poNy/Pr3We/zzhbBAGbYO6Ro oA0YEz8XGmiBrSNZMRNtvdxS/XYybCvhCWzfnOj3l2QKu4NtZYQ5GbMXRXw8JVXFYSWv NaXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bQKwEsId6JLgTtjw3Rjr7HrL/WSfNzzQCt6QFtE+6CE=; b=rkZ27YjdeCmMlhvrRrDB6Ertzf67UYRnoyw/6dvoygDoo9g9DYfgqGEWZYtZ+ACAmL xtEZDHMusCfv7hYIrpPIhaQE6ijPLOTeYmEKihlOYRa+pbFLNcrO7YI7zu7oukm/9bjH g6xdDRQtjE0KKewjCywE+T8BKK/rarioSgpjMCtHiTVIXnTwX1VKI7cBWGBb+80/G/AV aTh/OhktMTUmUiqy/qNRJbLoap7eLxpP7kWggUQNF5F6ianBn8Sohd0Ogi0r9wC+gEen ROX54DgV/rOA76RM/onKhsafs3zJLXZIc6r6NXqlq7z7osJIKFxA8opcXuVwwBfjWdRg q8QQ== X-Gm-Message-State: AHQUAuYh1Pti1kGOcrNngKpvtqfYXVgO+u/P+/MZYxEoIZeV+g34WIoN WvBgX+hUJybzj4cyjx5RHA0aEg== X-Google-Smtp-Source: AHgI3IZws0QWK8imzOTRnZT9SCN+xIH6k+c+7yeJ5437xHEWz8ntkEZzVxRVx+i1Hhp2RtIhJyh02w== X-Received: by 2002:a2e:81c1:: with SMTP id s1mr202136ljg.29.1550047646117; Wed, 13 Feb 2019 00:47:26 -0800 (PST) Received: from localhost (c-573670d5.07-21-73746f28.bbcust.telenor.se. [213.112.54.87]) by smtp.gmail.com with ESMTPSA id g85-v6sm3325972lji.17.2019.02.13.00.47.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Feb 2019 00:47:25 -0800 (PST) From: Anders Roxell To: b.zolnierkie@samsung.com Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Anders Roxell Subject: [PATCH] fbdev: omap2: fix warnings in dss core Date: Wed, 13 Feb 2019 09:47:21 +0100 Message-Id: <20190213084721.29624-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit 60d2fa0dad06 ("fbdev: omap2: no need to check return value of debugfs_create functions") changed the declaration of the return value of function dss_debugfs_create_file() and the following two warnings appeared: drivers/video/fbdev/omap2/omapfb/dss/core.c: In function ‘dss_debugfs_create_file’: drivers/video/fbdev/omap2/omapfb/dss/core.c:139:9: warning: ‘return’ with a value, in function returning void return 0; ^ drivers/video/fbdev/omap2/omapfb/dss/core.c: In function ‘omap_dss_probe’: drivers/video/fbdev/omap2/omapfb/dss/core.c:172:6: warning: unused variable ‘r’ [-Wunused-variable] int r; ^ Rework so function dss_debugfs_create_file() that is declared to return void don't 'return 0' and remove the declaration of the unused variable 'r'. Signed-off-by: Anders Roxell --- drivers/video/fbdev/omap2/omapfb/dss/core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/dss/core.c b/drivers/video/fbdev/omap2/omapfb/dss/core.c index 7e6a3eb266d0..b5956a1a30d4 100644 --- a/drivers/video/fbdev/omap2/omapfb/dss/core.c +++ b/drivers/video/fbdev/omap2/omapfb/dss/core.c @@ -136,7 +136,6 @@ static inline void dss_uninitialize_debugfs(void) } void dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *)) { - return 0; } #endif /* CONFIG_FB_OMAP2_DSS_DEBUGFS */ @@ -169,8 +168,6 @@ static struct notifier_block omap_dss_pm_notif_block = { static int __init omap_dss_probe(struct platform_device *pdev) { - int r; - core.pdev = pdev; dss_features_init(omapdss_get_version());